From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932253AbcIRMFX (ORCPT ); Sun, 18 Sep 2016 08:05:23 -0400 Received: from mail-lf0-f49.google.com ([209.85.215.49]:36755 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755474AbcIRMFQ (ORCPT ); Sun, 18 Sep 2016 08:05:16 -0400 Subject: Re: [PATCH] net: mvneta: mark symbols static where possible To: Baoyou Xie , thomas.petazzoni@free-electrons.com References: <1474190445-5887-1-git-send-email-baoyou.xie@linaro.org> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn From: Sergei Shtylyov Message-ID: <8cba4a0e-cbf6-ca67-a117-4c558d2c36f1@cogentembedded.com> Date: Sun, 18 Sep 2016 15:05:12 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474190445-5887-1-git-send-email-baoyou.xie@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 9/18/2016 12:20 PM, Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/marvell/mvneta.c:639:27: warning: no previous prototype for 'mvneta_get_stats64' [-Wmissing-prototypes] > drivers/net/ethernet/marvell/mvneta.c:3529:5: warning: no previous prototype for 'mvneta_ethtool_set_link_ksettings' [-Wmissing-prototypes] > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/net/ethernet/marvell/mvneta.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index 32f0cc4..03be592 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -636,8 +636,9 @@ static void mvneta_mib_counters_clear(struct mvneta_port *pp) > } > > /* Get System Network Statistics */ > -struct rtnl_link_stats64 *mvneta_get_stats64(struct net_device *dev, > - struct rtnl_link_stats64 *stats) > +static struct > +rtnl_link_stats64 *mvneta_get_stats64(struct net_device *dev, I'd break the line after * heren not where you did it. This way the function type would remain all in one line. > + struct rtnl_link_stats64 *stats) > { > struct mvneta_port *pp = netdev_priv(dev); > unsigned int start; [...] MBR, Sergei