From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1AECC43219 for ; Wed, 16 Feb 2022 10:12:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232731AbiBPKNH (ORCPT ); Wed, 16 Feb 2022 05:13:07 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:41800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232707AbiBPKNE (ORCPT ); Wed, 16 Feb 2022 05:13:04 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 661C52A64F8 for ; Wed, 16 Feb 2022 02:12:52 -0800 (PST) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id DB8DC40812 for ; Wed, 16 Feb 2022 10:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645006365; bh=wCaJzKBNjd94VDAGdI4W+Ww4APWOyvEWc/qTbStSTaU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=T/g7ng7kp59MieYZoYwJUvs/cyp2snSH0Fl39LQj5x9qG1SfZAxWp224/kAUfSUIa zyMuE9E0kQzDUJ/X61N/gqjblyRHY3+NIQsheHYt9eMSyfZHXm9w5Oz6s1PtnQVWKI ET2wNRwA8QbWMfBIa05l1jUNb3KOTh/JwxXZxGNvQ7FHCSDLRJYdCYERhon4AngVDe FPVdEXjyWnE7CnqdqPDR/ig4txC5Z7bjVyNqJGdHKIMtQftZ+d/IDvxcfIbfb+WdFC KlZ285HjeprSdwooheE1gNxjKnTm0QG9kgFoaWsWdCp7hqA5gJ1whigGvQMydgSfqz otkA1M78pbQUg== Received: by mail-ed1-f69.google.com with SMTP id l14-20020aa7cace000000b003f7f8e1cbbdso1238527edt.20 for ; Wed, 16 Feb 2022 02:12:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wCaJzKBNjd94VDAGdI4W+Ww4APWOyvEWc/qTbStSTaU=; b=BcSiapEVbL3c736UEeUpTrNq/G6BX7PkFQ/0oLxmH467wb5BvXZyLSUoBS/MdCAjcr KXebqmsqFAMsw7CL4OOT4xxzHgR9Bna1SAgiX/Owhs2eD3FkC2xz7kc91HtsSPZCxhH0 OkfvH3yNFH0Ko6MDfj+0KQxRmUmD9T1SQrbf1htCEZGOl2s17tkIYhv8dFqD5isey3W6 WcwY6qgNg6VljuFLhDbk/YRePdCKAhW+OQUHh537COFKMGtEtpygc1ojLnWGiyRDXSfb 4ZsrRV7sisDMNFKNE90dHpZBZUTv2djkgRC2xnpGiqdaHMwp+er4MOyDk/loq5LKAgAE Mllg== X-Gm-Message-State: AOAM531ZwLBjEph8WljyLfkTvwS5NqK7pHyhb6V7WiqnU6Nlsl+XxwKe dYLZjz4Wjv3chKppZ1DsN39tZoPamEjCdqnmAbCR2yz3oM0rmRdTXfg0QC5AjLTvJ0KGlu5AxWG N7sO3yfHPxiT6SQSnwrKzSs8BXfiJSUjX7HBkn7LoJA== X-Received: by 2002:a17:906:1188:b0:6ce:f315:21df with SMTP id n8-20020a170906118800b006cef31521dfmr1649678eja.591.1645006365515; Wed, 16 Feb 2022 02:12:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJzFu3ZIcGVwlCyzC/7X5mFw001hnaSynx6a8cfVN417f5jmgKVCWYEUWtyjMNimqQbfS56JIw== X-Received: by 2002:a17:906:1188:b0:6ce:f315:21df with SMTP id n8-20020a170906118800b006cef31521dfmr1649657eja.591.1645006365327; Wed, 16 Feb 2022 02:12:45 -0800 (PST) Received: from [192.168.0.110] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id y9sm1354703edj.108.2022.02.16.02.12.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Feb 2022 02:12:44 -0800 (PST) Message-ID: <8cbbc565-738c-1e73-07b5-dc67ca55e920@canonical.com> Date: Wed, 16 Feb 2022 11:12:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 1/2] dt-bindings: input/touchscreen: bindings for Imagis Content-Language: en-US To: Markuss Broks , linux-kernel@vger.kernel.org Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Dmitry Torokhov , Rob Herring , Henrik Rydberg , Stephen Rothwell , linux-input@vger.kernel.org, devicetree@vger.kernel.org References: <20220215205153.57966-1-markuss.broks@gmail.com> <20220215205153.57966-2-markuss.broks@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220215205153.57966-2-markuss.broks@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/02/2022 21:51, Markuss Broks wrote: > This patch adds device-tree bindings for the Imagis > IST3038C touch screen IC. > > Signed-off-by: Markuss Broks > --- > .../input/touchscreen/imagis,ist3038c.yaml | 74 +++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > 2 files changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > new file mode 100644 > index 000000000000..f98e5dfa2bc4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml > @@ -0,0 +1,74 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/imagis,ist3038c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Imagis IST30XXC family touchscreen controller bindings > + > +maintainers: > + - Markuss Broks > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + $nodename: > + pattern: "^touchscreen@[0-9a-f]+$" > + > + compatible: > + - enum: This does not work. Please test your changes. "compatible:" does not list, so "enum" should not be an item. Drop the "-". > + - imagis,ist3038c > + Best regards, Krzysztof