From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Boerge Struempfel <boerge.struempfel@gmail.com>
Cc: bstruempfel@ultratronik.de, andy.shevchenko@gmail.com,
festevam@gmail.com, amit.kumar-mahapatra@amd.com,
broonie@kernel.org, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/5] spi: spi-imx: add support for SPI_MOSI_IDLE_LOW mode bit
Date: Wed, 24 May 2023 11:47:05 +0200 [thread overview]
Message-ID: <8cc00e92-512a-f65e-ef4a-4ea859ee3e31@kontron.de> (raw)
In-Reply-To: <20230524091948.41779-3-boerge.struempfel@gmail.com>
On 24.05.23 11:19, Boerge Struempfel wrote:
> By default, the spi-imx controller pulls the mosi line high, whenever it
> is idle. This behaviour can be inverted per CS by setting the
> corresponding DATA_CTL bit in the config register of the controller.
>
> Also, since the controller mode-bits have to be touched anyways, the
> SPI_CPOL and SPI_CPHA are replaced by the combined SPI_MODE_X_MASK flag.
>
> Signed-off-by: Boerge Struempfel <boerge.struempfel@gmail.com>
Thanks for working on this! We used a similar downstream patch for
driving NeoPixels with i.MX. I'm happy to see a proper upstream solution.
I also have this Python module [1] around for using spidev to drive the
LEDs. It would be nice to see support for SPI_MOSI_IDLE_LOW in py-spidev
[2] so we could use it there. Though the latter looks a bit like it is
not properly maintained anymore.
[1] https://github.com/fschrempf/py-neopixel-spidev
[2] https://github.com/doceme/py-spidev
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
next prev parent reply other threads:[~2023-05-24 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 9:19 [PATCH v6 0/5] spi: add " Boerge Struempfel
2023-05-24 9:19 ` [PATCH v6 1/5] " Boerge Struempfel
2023-05-24 9:19 ` [PATCH v6 2/5] spi: spi-imx: add support for " Boerge Struempfel
2023-05-24 9:47 ` Frieder Schrempf [this message]
2023-05-24 11:42 ` Börge Strümpfel
2023-05-30 12:46 ` Mark Brown
2023-05-30 13:27 ` Börge Strümpfel
2023-05-24 9:19 ` [PATCH v6 3/5] spi: spidev: add two new spi mode bits Boerge Struempfel
2023-05-24 9:19 ` [PATCH v6 4/5] spi: spidev_test: Sorted the options into logical groups Boerge Struempfel
2023-05-24 9:19 ` [PATCH v6 5/5] spi: spidev_test Add three missing spi mode bits Boerge Struempfel
2023-05-30 17:40 ` [PATCH v6 0/5] spi: add SPI_MOSI_IDLE_LOW mode bit Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cc00e92-512a-f65e-ef4a-4ea859ee3e31@kontron.de \
--to=frieder.schrempf@kontron.de \
--cc=amit.kumar-mahapatra@amd.com \
--cc=andy.shevchenko@gmail.com \
--cc=boerge.struempfel@gmail.com \
--cc=broonie@kernel.org \
--cc=bstruempfel@ultratronik.de \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®