From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86C9633D4E9 for ; Mon, 30 Mar 2026 20:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774903047; cv=none; b=Dj2lNS2DV0z2qq8urC1+yGgqMg8zC9Mie0dg7gibDukRYF2enuxugNK+h7Vuzy3tr2OztnJIyAJDCe9V86AUbq0gecBOjTKdCgOKGEcDwQjtvwtlY8k+EvY4tXB3TZYCU+3zw4UnaY+XjzLeRKfD3T6wThVlStjCBNEhmQK22Io= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774903047; c=relaxed/simple; bh=1vmPNLR+fCtPTWdkx4qkUqBSXreBxbrbpTKcaKKF2KM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=vB1eBGeQrHgbr3qsJRnah3YOHsnsc/zAL6bN/pOkZu++c/Q32bsucvHlCzKvVggGBOT7J15d2YHFqcFNoG9tU4Jzs4XNngJMrdyURAoRjYAoZy57x2m5Xalg9IkMGPooOGL4imRKG61xQpk/H6rpW86Gn4O1mhU+JR3knWOpJ0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h8pH9ESR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CxeiCzHD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h8pH9ESR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CxeiCzHD" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62UH0e4f4013480 for ; Mon, 30 Mar 2026 20:37:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yImGOfkvrPNf4nn8Y5ji+vWnvutW5wQn5OLphXqepxc=; b=h8pH9ESRUw8OQd9Z DrbVOl1897hzpjGCSTkjgIQIX/iyKB10CU9rXzUk6wgkjDEnQetMvn2414lyBQ16 x0oOLPeLLjwm6qntOVXWRYeaa0bOz5uZ096ZGbGTKrXqfZZmBEmdwULiVW9MtIXB XsMxa5l3NEwPAzHabr1E1AFVu+1M0bZ1tKhv/IKShJAjdb5/sg1zM+dU8esdTP/1 joCL7CpfzeRug30gUSM4xqUQzZcd3ypYTANGs8qvOIJx3bk9VT8qylq38BFvd5UW UTOmN2TstX9hplzwqSFZgFGD/nes2n8I3C/qX2GLzPx/Qz3XzYOlSsgz8AEyfesJ vUO0OA== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7regt3qs-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 20:37:25 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c76acbe2829so685772a12.3 for ; Mon, 30 Mar 2026 13:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774903045; x=1775507845; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yImGOfkvrPNf4nn8Y5ji+vWnvutW5wQn5OLphXqepxc=; b=CxeiCzHD3u1U2p7PIcdWGcNClh7c+OVWSBtqC+k7h+dQDhg3/BAuTSj0T/1dFENtt/ Wfc+Fn/ZjqmbEqvniF443B4CCCPKE7CqgcjckiQJRcjL2yBvGcH1X/2q4IJJUVw7H/7x 6d+JnpQln4Ufs1cuS9kDVTjRlr1mm4WAvM8wQNqy6pAgZl65Yha8GPJpUgRrLDbaJnX1 GlIA4HUEA5Lvt0M9b0GtHN5OK+U9qo0BaBZwcCJOlmlQjnSM61zJ7ezXQnbYDvys2TS/ 1/NU9/jGtpbwXej7hVPZoVnqiRIzdZGtx0RhtZ/QejDXk2bwx6nL5ZYbSLawNFSBLfpk 1viw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774903045; x=1775507845; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yImGOfkvrPNf4nn8Y5ji+vWnvutW5wQn5OLphXqepxc=; b=CZsZq4L3mY0uDZzrFpWMYXyRawWw7JwKKpCaugBOANBYZ7sQV9ELAzwQagCnvAI6Cc ui63X44EgTyQZmJS0c2QF9GSeq8PrLGkHZ+mDSVHYVNTOW8kYjWxWwaBuOhKC4urJg24 6FuK+nmgBa5K5/QnZvlrYg0+7NacojLIdAJFTgZ4TYtBl32/8KrjRgpb5vMIEDixOOe4 V1ekpHlGqKnGEmgThGJwZntt4ciur1XYw2yf28jEaTpKQ+YqGE3Xw3dDijU9ubBdcJ+w l1yoa8rlu32NuGShjlj+L2n5Gpkqj7cfgElgJABqpF6OchG0YS07emv0XGg92afqqj2g ETGQ== X-Forwarded-Encrypted: i=1; AJvYcCU84uv358Tuc4lOoo1NmZb0pEZGnYp4RT+kRNOr/VxpitzN8zj7n8Q5I7KqPmvtIFJpLfXne6wM/sbGiD8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1RwADwG4OKsLlKXFTIEri1deU+payZxA1+XI3SK4+rSkc7Phi SqrFj8csTDzHdEaN020PhZnQDNHNY9kf0ZZTVDDgVxgyOFxI3lJUYj9aP45frUKdcz0hMsUFiYM 4X4D/J6ml/8TbicjC8Pz9607kau/VDBBgt5Ol+ChHBV98LWZzciQLp4bd+JETE2CKTKc= X-Gm-Gg: ATEYQzwGhbNIEcJdJHPNY+q5HQSA4AWhmWJVL6wuZmn6xF03mKqHHxpTwR6a+LgZ4bm rv7iUWQuBWvtljyUdVGhTbuung/+RLm/Ywg5IMyyPtAUOALTbzeG+BhQPEoF9YCvfSbfo74cOOG 1deMZenqnykDPQJ/D20yHoWcTs9AD3Bo//2op5HDafhUAy0Eu99zoUJhmJ1JmLhBTqca7Om2mgP 6oBUapV/aW7aPdaW+DKAPA0KowWUV7q45wCbSvPorWx9JKNV0duFKszi0U5bdezQnfuVRORr/Dp yyQ6xjkEcdm0ck4g4uPATWGkcjOE/6lIJ24+y1PeApcAO3DX7KS5WGoLk61Oz3tWhfrkcfLXL7s sEwvHCaRESmPiDxDExxEgH4rRuSJU6aJ55Bx5rzRlS3hg X-Received: by 2002:a05:6a00:1488:b0:82c:247b:ffdc with SMTP id d2e1a72fcca58-82c95ee518bmr13677890b3a.29.1774903045000; Mon, 30 Mar 2026 13:37:25 -0700 (PDT) X-Received: by 2002:a05:6a00:1488:b0:82c:247b:ffdc with SMTP id d2e1a72fcca58-82c95ee518bmr13677865b3a.29.1774903044509; Mon, 30 Mar 2026 13:37:24 -0700 (PDT) Received: from [10.91.121.222] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86247c9sm8270549b3a.54.2026.03.30.13.37.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 13:37:24 -0700 (PDT) Message-ID: <8cc91ff8-55a4-4662-bea5-355524490591@oss.qualcomm.com> Date: Tue, 31 Mar 2026 02:07:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/16] drm/msm/a6xx: Fix gpu init from secure world To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-10-fc95b8d9c017@oss.qualcomm.com> <7d223573-438c-4e93-b4b4-64975c4da93f@oss.qualcomm.com> <4522e20c-70ab-48ef-8b0b-59f2548ebe64@oss.qualcomm.com> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <4522e20c-70ab-48ef-8b0b-59f2548ebe64@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=G6wR0tk5 c=1 sm=1 tr=0 ts=69cadf05 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=0_mfmPpWdV7espOYW9wA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDE3NCBTYWx0ZWRfX3g/jr/tejFLH ZVAywAH7u53d+ahLeZBBwJQBG2LT0At87d1QSy00phGfERfaGut9lc8fuMe6yHTegvXQNPWpPFr a/usrmisNFDM8JOFsZPl0ITYhohYs1mAQoOeJ6z4euiSm3Za9wrtF9Jv49x52l964Ub1VODZCKV eb43MeHpOuerbrElPFjbTT+b/F3YDMxcmz+X5Nm5MlNw1heA75oged7wzaL9bhmJuISPplD/Jiu lJv0Ufwh/fkJ29aJR/bstp0Jf3ORRpIsz503wdXr8TdCjtvJmL9uwc4UlAAPoJ3Y3sswb4/tKDN SuDwipN452I8FZhdiCeTFZqJxwugTMVHKjPnsXJxEvCZt5wLofofhEQOzo74AiqzMMMvMXfxTtW szy6TfiKfNguTB9vjshA2fNkTJkOertnX199ccLsUsUYUUqnRs173aDo1jDO4utCxi6OLg/HPj6 IrKNj31Z3E164qqdM5g== X-Proofpoint-ORIG-GUID: ODJFHApte5aOMubGuqU3z46ZDT42AcGc X-Proofpoint-GUID: ODJFHApte5aOMubGuqU3z46ZDT42AcGc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-30_01,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300174 On 3/27/2026 4:53 PM, Konrad Dybcio wrote: > On 3/26/26 9:12 PM, Akhil P Oommen wrote: >> On 3/24/2026 3:37 PM, Konrad Dybcio wrote: >>> On 3/23/26 9:12 PM, Akhil P Oommen wrote: >>>> A7XX_GEN2 and newer GPUs requires initialization of few configurations >>>> related to features/power from secure world. The SCM call to do this >>>> should be triggered after GDSC and clocks are enabled. So, keep this >>>> sequence to a6xx_gmu_resume instead of the probe. >>>> >>>> Fixes: 14b27d5df3ea ("drm/msm/a7xx: Initialize a750 "software fuse"") >>>> Signed-off-by: Akhil P Oommen >>>> --- >>> >>> This now makes this happen on *every GMU resume*, which sounds >>> undesirable (kgsl does this in gen7_gmu_first_boot) >> >> I had this in my TODO list, but forgot to update. Will fix. >> >>> >>> Similarly, we call a8xx_gpu_get_slice_info() on *every resume* >> >> No. We check then slice_mask and return early. > > Right, but we still branch into it > > I think the best solution would be to add something like > gmu_first_boot_setup() which would be tracked by something like that > bit you added in v2, where similar things could be moved > > That said, this is just an optimization Perhaps, a micro-optimization. ;) -Akhil > > Konrad