From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 725E1C433DF for ; Sun, 26 Jul 2020 20:48:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AA672065F for ; Sun, 26 Jul 2020 20:48:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726984AbgGZUs0 (ORCPT ); Sun, 26 Jul 2020 16:48:26 -0400 Received: from smtprelay0225.hostedemail.com ([216.40.44.225]:57328 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726467AbgGZUsZ (ORCPT ); Sun, 26 Jul 2020 16:48:25 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id C430D181D337B; Sun, 26 Jul 2020 20:48:24 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: salt89_0e0b54526f5b X-Filterd-Recvd-Size: 2643 Received: from perches-mx.perches.com (imap-ext [216.40.42.5]) (Authenticated sender: webmail@joe@perches.com) by omf13.hostedemail.com (Postfix) with ESMTPA; Sun, 26 Jul 2020 20:48:24 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sun, 26 Jul 2020 13:48:23 -0700 From: Joe Perches To: Randy Dunlap Cc: Christophe Leroy , linuxppc-dev@lists.ozlabs.org, Paul Mackerras , linux-kernel@vger.kernel.org, Michael Ellerman Subject: Re: [PATCH 0/9] powerpc: delete duplicated words In-Reply-To: <4e505c35-8428-89bb-7f9b-bc819382c3cd@infradead.org> References: <20200726162902.Horde.TCqHYaODbkzEpM-rFzDd8A2@messagerie.si.c-s.fr> <4e505c35-8428-89bb-7f9b-bc819382c3cd@infradead.org> User-Agent: Roundcube Webmail/1.4-rc2 Message-ID: <8ccba434d98ba1319dbb9a386f7a7450@perches.com> X-Sender: joe@perches.com X-Originating-IP: [172.58.17.243] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-26 12:08, Randy Dunlap wrote: > On 7/26/20 10:49 AM, Joe Perches wrote: >> On Sun, 2020-07-26 at 10:23 -0700, Randy Dunlap wrote: >>> On 7/26/20 7:29 AM, Christophe Leroy wrote: >>>> Randy Dunlap a écrit : >>>> >>>>> Drop duplicated words in arch/powerpc/ header files. >>>> >>>> How did you detect them ? Do you have some script for tgat, or you >>>> just read all comments ? >>> >>> Yes, it's a script that finds lots of false positives, so I have to >>> check >>> each and every one of them for validity. >> >> And it's a lot of work too. (thanks Randy) >> >> It could be something like: >> >> $ grep-2.5.4 -nrP --include=*.[ch] '\b([A-Z]?[a-z]{2,}\b)[ \t]*(?:\n[ >> \t]*\*[ \t]*|)\1\b' * | \ >> grep -vP '\b(?:struct|enum|union)\s+([A-Z]?[a-z]{2,})\s+\*?\s*\1\b' >> | \ >> grep -vP '\blong\s+long\b' | \ >> grep -vP '\b([A-Z]?[a-z]{2,})(?:\t+| {2,})\1\b' > > Hi Joe, Hi Randy > (what is grep-2.5.4 ?) It's the last version of grep that allowed spanning multiple lines. That's to find the comment second lines that start with * > It looks like you tried a few iterations of this -- since it drops > things > like "long long". There are lots of data types that are repeated & > valid. > And many struct names, like "struct kref kref", "struct completion > completion", > and "struct mutex mutex". I handle (ignore) those manually that's the first exclude pattern.