From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 921E4C433FE for ; Tue, 8 Dec 2020 01:00:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52BE223A22 for ; Tue, 8 Dec 2020 01:00:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726918AbgLHA7z (ORCPT ); Mon, 7 Dec 2020 19:59:55 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9550 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726545AbgLHA7z (ORCPT ); Mon, 7 Dec 2020 19:59:55 -0500 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Cqhd54FxVzM1N0; Tue, 8 Dec 2020 08:58:33 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 8 Dec 2020 08:59:12 +0800 Subject: Re: [f2fs-dev] [PATCH v5 RESEND] f2fs: compress: add compress_inode to cache compressed blocks To: Eric Biggers CC: , , References: <20201207095220.73093-1-yuchao0@huawei.com> From: Chao Yu Message-ID: <8cccbe7f-94c0-ddd0-4da5-234d02839ae0@huawei.com> Date: Tue, 8 Dec 2020 08:59:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/12/8 2:13, Eric Biggers wrote: > On Mon, Dec 07, 2020 at 05:52:20PM +0800, Chao Yu wrote: >> diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst >> index dae15c96e659..fd413d319e93 100644 >> --- a/Documentation/filesystems/f2fs.rst >> +++ b/Documentation/filesystems/f2fs.rst >> @@ -268,6 +268,9 @@ compress_mode=%s Control file compression mode. This supports "fs" and "user" >> choosing the target file and the timing. The user can do manual >> compression/decompression on the compression enabled files using >> ioctls. >> +compress_cache Support to use address space of inner inode to cache >> + compressed block, in order to improve cache hit ratio of >> + random read. > > What is an "inner inode"? Mount options should be understandable without > understanding filesystem implementation details. I'd like to use "a filesystem managed inode" instead, if there is no further comment. > >> +const struct address_space_operations f2fs_compress_aops = { >> + .releasepage = f2fs_release_page, >> + .invalidatepage = f2fs_invalidate_page, >> +}; >> + >> +struct address_space *COMPRESS_MAPPING(struct f2fs_sb_info *sbi) >> +{ >> + return sbi->compress_inode->i_mapping; >> +} >> + >> +void invalidate_compress_page(struct f2fs_sb_info *sbi, block_t blkaddr) >> +{ >> + if (!sbi->compress_inode) >> + return; >> + invalidate_mapping_pages(COMPRESS_MAPPING(sbi), blkaddr, blkaddr); >> +} > > Global functions should have the "f2fs_" prefix. Yup, Thanks, > > - Eric > . >