From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbdBYTSI (ORCPT ); Sat, 25 Feb 2017 14:18:08 -0500 Received: from mail-sn1nam02on0042.outbound.protection.outlook.com ([104.47.36.42]:52132 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751434AbdBYTSG (ORCPT ); Sat, 25 Feb 2017 14:18:06 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=matias@cnexlabs.com; Subject: Re: [PATCH 1/2] lightnvm: add generic ocssd detection To: Christoph Hellwig References: <20170224171649.27409-1-matias@cnexlabs.com> <20170225182117.GA26447@infradead.org> CC: , From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <8cce0bfd-a153-ba4e-0d84-bea29764982e@cnexlabs.com> Date: Sat, 25 Feb 2017 20:16:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170225182117.GA26447@infradead.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [188.183.135.134] X-ClientProxiedBy: AM5PR0701CA0057.eurprd07.prod.outlook.com (10.169.145.147) To BN6PR06MB2772.namprd06.prod.outlook.com (10.175.127.14) X-MS-Office365-Filtering-Correlation-Id: 8c92aeb4-e769-43c5-e17e-08d45db2cbc2 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR06MB2772; X-Microsoft-Exchange-Diagnostics: 1;BN6PR06MB2772;3:ramtrQFTc5VV0u27wW3wQdg7bxvi49kPbWXSyv5Y4H2gRufrL/8j0rq0Xu9rDa82L9KYBR8TBCNdFl7aQk1byQPMw6+YAgn3XgoEn1+hv5SadRnoTo+Bu1AePBwqbLXi3IscRiICFC5Xv1IpqZw+MoQOoi9MF0GEioI8naaEfUUgIEcJmfJBaetyQ709fZpH3HbCvMSPKhP2PDnqad0DyiNyswBHLoraGWvAOGRxkBl/pPBLGZn1svIkrmI2X9LBtR0oTC4FIBUhKkDsxiTFew==;25:VSIpRKlfSVL84zlwa8QgW6CoFlGsJyL44HwQaQR6yFRqgAVXJTx/S/KvXKaINjoQxyxoNftThCQwg+mvrkwoWHRUR2Qy5iFh1HgjaugyMXYkEDz1+IntR2GuKyNvFHfVMzt+7EobthnkRXS1tX4+MV7RuTuH/0A96AY8Epw3V8kow4ymmabUmOnzwNwIwDUV0kqREtyj4Eni9oyHWwF9kjHYnk1xx+LHE9tA/lUXzX9MHTkCIu1iu6SIhbVee5fpByosX8lDk/L93StPYHqoB2jOaFlslKlPpN+/OVdCdAgbzWvpEU57MQXI2oKypDYGZfpO1/iGgz9gvbv2Vd2WOT1T5evQKyglpeX3wKUHjQbYMdJOneuoEuOapu0Cu45Ewjcy/uSbtVwWAjkNTw50pBEev81BaaeptFwRDW7sx/Dqov+coxf5hcvt1u9xpdEL6uzj9M+qv3MGWa8daXS14A== X-Microsoft-Exchange-Diagnostics: 1;BN6PR06MB2772;31:iBnX33coYvM/gXX9Ad2AuaLTSjAzoXsfl54cKT8evyknL0/v36OLC0Hdgxrcg/MctYqNxitllwYXGJfRTDDqZdGsEtsV+e33mrEajBDwVtn69TBYpkAVCgir7Iiyi+FNmiciSqW3amcOfVgC3hFLkRlPvPjEh8iLo8yX/3lkthi2cAUu5l8EPHvQenti3KReVfmss3GVfOLAjObv4xHKJOLg+7FZTPNgOdisF/ZtM4QIZ2PZpMDPCkP9fTq175Z4fsI1YZ2Mg38nIcZygxMndw==;20:OrMSbD1yqx/U6AdE7T9BEr7buaLAPoNHURKC/r8dxo0aO1zBXexR9peEyi4qlLVAmYeuP+jwVRMLp4vJgWagGSzr6U0WL9U9iHV9wM0JO5ozGJR32e3hmsjUAhCr+WVCgugWtifBG5o9kdLM/VYOL8pm8PnAyoCkJYBmXtnfuY8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123564025)(20161123558025)(20161123562025)(20161123555025)(20161123560025)(6072148);SRVR:BN6PR06MB2772;BCL:0;PCL:0;RULEID:;SRVR:BN6PR06MB2772; X-Microsoft-Exchange-Diagnostics: 1;BN6PR06MB2772;4:3ZqDJOsAAYDX7Nsg0l/sXAhpYNhP+A/4D1QjkW7hMguLgMxbilJO9YF1zWetmYItPzbylT8WefMcBjDHpWHAPoLz3djzi1HQb5g+RmYKP4AkRNSDYdanI55lbvcLFa+sz1zHZfjhvKYxvkIOv79LxOVX/pjB1k89lDOUyYeL7PjbIt0kUysFb/9Hob14yxIpn0VD5B+A3dQvIX1JbXE/BLwOgsBzJ0Vm5yrooleS9Lw+NXBtagnOI0mgia+QxVrw2FwA7f017M8fgsHUTxYYufbcw1ncvHtVSQpGTdNejpUS9PNYbbzuqXGpQylEa63b6cOO/qYtHZebhecu8pp0z5ABzxA6FegAj7LCNbspyRSqDaBqJYdz9uOTXMw79HOwyNEegxgukiKVQAkX/2cXi2orHbaF+wqDJ3Y50qRhEGLcxE00Pk+k885KvDadSEwrXK7Hesdf6vWgo41JBOSy3M5TccyCI6D13GU98jdqKsiVrdO3dIlgm6bWYN7WInUXfPIu+NsTqDJTxTnkidESMXEIr4yppmph3/wl7CrSskqfdA8orPnQ4OQVgkdlAX59W8N4NiHXnM4/yadrU+zM+0CQQ6wh5S+9Rqt19r4e+V8= X-Forefront-PRVS: 02296943FF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(39450400003)(189002)(199003)(55674003)(24454002)(377454003)(305945005)(68736007)(2950100002)(6916009)(65806001)(81166006)(81156014)(8676002)(3846002)(5660300001)(54356999)(76176999)(47776003)(36756003)(6116002)(101416001)(83506001)(105586002)(106356001)(6666003)(7736002)(50466002)(25786008)(54906002)(2870700001)(42186005)(229853002)(117156001)(86362001)(110136004)(38730400002)(53546006)(31696002)(4001350100001)(4326007)(33646002)(50986999)(66066001)(65956001)(65826007)(6246003)(64126003)(189998001)(23746002)(92566002)(31686004)(53936002)(2906002)(6486002)(90366009)(77096006)(97736004)(41533002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR06MB2772;H:[192.168.0.15];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR06MB2772;23:MIu90jLrUs5eONnoRJjFLIMQg0zRxwIblIOZq?= =?Windows-1252?Q?r7YRZOo0Ta1iw/fcB5Ovivgk3k/3YLVvxPNqOk6U8WCJ8zERyb2Iqirg?= =?Windows-1252?Q?HutN55YJvcqLyaUy/u9q+wsup55vw2iGcRnqJn15OXkDWl+ctiSMbvuf?= =?Windows-1252?Q?3IBrtGY5RvDqii8OIBcucmmZ+mU9xRX/stdypHZNkP7ux5ZtIbTAefdZ?= =?Windows-1252?Q?wJ3iA968uZcU+w5iTuqQXQFTsNPGVi08oXgbzO5k5sCcAqu85nbKFOas?= =?Windows-1252?Q?RrEK2yd0TWSHysW8EHnbYkv7oEw32kDHr4/o6EtWyMFeybTKMeN52yIt?= =?Windows-1252?Q?lwuIfCF852Y4CBjDVNtpL0qb4UFeoBcv4n0rISHCDVD6vSQo4K/OQNa+?= =?Windows-1252?Q?9p/Ohztjq/5mzdF4eiPneg2Awc5klmLEhVSzGCNtwOFYfhJ3Y6RdG1dN?= =?Windows-1252?Q?Wgcn5srMLWzJSB69R+Ql0ZpSiosYkMWsN+NbECs14HKByL38yTwq8Am3?= =?Windows-1252?Q?E7aOoBA98iSzM2sE4hAIWsiKkYOf/7MjgX0tZm8qTVZF7vOjz+IFNJNA?= =?Windows-1252?Q?Kk00REbmzKRo5eAwMZ7louQaW001qrkX4p+TlIRYXzqX4JZPX67Gpm0+?= =?Windows-1252?Q?DLQXWr7hDt+aADNeiiVIq8pQzVt/0mFYwbpkTEaOhZ3U0bY9GhkieF6G?= =?Windows-1252?Q?j+Yh9WYpCxtAcgW9spempH5vbgt3taEF6ThBlk96IzBJ83XCp8yfitAN?= =?Windows-1252?Q?6BFF+1EVFfuTnkiLNKjYmn6EQIISauicV4kexOVb49GqBN3FT5/NyEKt?= =?Windows-1252?Q?qryXRFeuLtT0ATfNsCe87ll4kVseYE1Nmjb6VXTVMYx2zMHrXcVi6dXP?= =?Windows-1252?Q?iWDAMKUYFevkMuAgZnPmdJ3jPHLLpi2IKGw//n/PIYVT7Db0qVhOh7+/?= =?Windows-1252?Q?O9jxB1x01SKo78CDZQlwJoVlN++SEzrP2HCm4+hHenYKoBbc0seUdgSO?= =?Windows-1252?Q?Z1qO/D/saCCRQ+JQveicbKobEpXxSHItUSHgQK3RzAJkslyRSjL86u69?= =?Windows-1252?Q?fCoNWz9Y0EU4pq8XcuB5WLsmNFuQoHdM6Znqhtr6pb6ygB07FUcC8ofQ?= =?Windows-1252?Q?4jPZatqFXCYgrLmvzcQm8CaUOVdGBgPdfQ9HQ3Aq0HWemdzZ7NMZhTFP?= =?Windows-1252?Q?byca+CL14okbiXBIm0MtC4TTk7cOQ+/WDOHRIFFRmQWmkJ57JD0ccZjr?= =?Windows-1252?Q?7FE+XKmH7AenYRcf5NUMOb7mJWp9CkOIS4NAZfpfGO2DZudkUyjKYhxI?= =?Windows-1252?Q?9IIGJxsckPZ2+VTelv8/gxXy+tF6eI9YfkNR0CDAQiEkBto7DxjQqbz8?= =?Windows-1252?Q?2TgAtAMzU3ws5PuZRSPwMk/85+yH1UljbWJ928ofgfC8hkHM74cUbklt?= =?Windows-1252?Q?1N0+WCHVHxVmlS1ocGj/+EeCHYnfOtvpLRpWXFpcDmA+VODShJPfI2qw?= =?Windows-1252?Q?oyjh/9AU9tNU8cc+JhF/ukAak039Y7QFvlwmDZsLdK2ymIZjvxmtYYi2?= =?Windows-1252?Q?xFAwlfUCtLoS+fvvKYr7UAsHOaJd0cBMmgVOsdY+QnqHFhVBc2btNqok?= =?Windows-1252?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR06MB2772;6:mNOf2j7zddCr289H0FKP4g9IctOEDAEa5krO3avxgLujJyLMtPa8b8GDT9LBRu+fGouQbe82m5Le32NXgf7o1z4yxRt/VLuBxXxUOiYdsVw1wvZ+smVAV2qTGw8E3G9YVuBLuQufTOUzwOkSmLd5QoG0uMx+sEEKIyFtGnldOXk7fHd42DdDJBcXmMkIH5dlNhhDe9ScD2HFij+r98WDeoc8XZTYHEE4yCS1HmqLm6eIEkbPzhJb2qiJJdL3gWuBTvJUknWP/UnQ8RdNBxU+eGfYdBau+tB1exuyFwPFFt8FIAxXNpuWVQj4o1U1W1QusDGgCNiay6iTnIc+xx7UDQSuQRHbF0JJE6S3Zr+YFQ4Ynx2+2fOg1nqJwSeMMoU9cUGWQFvCHinEPH4f5CwbLA==;5:hIu2l7VRc+cH1J0RZOSKbPkBXvCsHSmlKBCLxvvrQZ/PI7vviq/ep9b5hNnlu17D8f6M+uqTxbo9/Ny6DoxXzSDeq3WgyttJbR4MrTqinfJMVOR6l31XiKJOwmv8YrqEO1rljME6Q12ZbRSClmdplg==;24:n1p/5GAopRp8TsOimnqhx8otUNhI0nNHfHmdhbwyfwjtxLwP4Jlo7k7URRQXI0CAoPkmwtDKVxaK/j7uZ2ge3HeyuJtZW6m1m+mUVzdU128= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR06MB2772;7:EfBM6p1bBBr3bHRwBAnkw6K3Rhtw2HcrU0dNc6Ra1z5WePC+WgYOQlL+FbjtLB9hyoPrUXbfY0PwHIVJPZxSFcYQhlC1UK2Qaq/eE+IzTSmsSAchm8LluA56MihYj3KA+sUV1SVj6GGOh/G+haUIumA5/SiPRvIP7fbQxmnWNgTVPHdTYFjuJExp2xZNL1qXRgniLC5JBSRcpCx6enWWQt6mJ2SxHNrsC42vfE/w9ZGsGE4hS7kPulrqdMyW2QgYVMz4fgjvFZXusJ9La8u4VJZE1VpMHaVhg0aL+LG5g1M3BhCbxH9ytia9pkGgEj06+SWNpOLLLHQpp4ZJzsNNKQ== X-OriginatorOrg: cnexlabs.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2017 19:16:26.4377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR06MB2772 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/2017 07:21 PM, Christoph Hellwig wrote: > On Fri, Feb 24, 2017 at 06:16:48PM +0100, Matias Bjørling wrote: >> More implementations of OCSSDs are becoming available. Adding each using >> pci ids are becoming a hassle. Instead, use a 16 byte string in the >> vendor-specific area of the identification command to identify an >> Open-Channel SSD. >> >> The large string should make the collision probability with other >> vendor-specific strings to be near nil. > > No way in hell. vs is vendor specific and we absolutely can't overload > it with any sort of meaning. Get OCSSD support properly standardized and > add a class code for it. Until then it's individual PCI IDs. > You are right, that is the right way to go, and we are working on it. In the meantime, there are a couple of reasons I want to do a pragmatic solution: 1. Enabling open-channel SSDs on NVMeoF. Customers are asking to use OCSSDs with NVMoeF. I do not think detection of PCI ids works with that. 2. Some vendors are circumventing the OCSSD detection by utilizing the CNEX Labs PCI ids. That is not very helpful and shows that there is a need for a generic approach. When they become public and will use their PCI id (if they will do that...), it is cumbersome to backport their PCI ids back to previous kernel versions to detect support. 3. Things are not a technical issue for why this is not adopted today. It will be soon enough one way or another, but until then, a pragmatic approach would go a long way. If identify VS is too specific, is there another combination that solves the above in a generic and practical way that would satisfy you and the above? -Matias