From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 879553A6B9C for ; Tue, 10 Mar 2026 12:57:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773147457; cv=none; b=WYLcM5xHneKLfwLF267+/1ORj2KloRwszBfWkKgYY2ys3yvIK8RLco7W/XISpBK0pCPUKwWouWBdNLA77UZ3cEYGvELlmA2weZr4Qr2b8h22l2OC9e/xCrMKCnf+rVThXuP/xeURKA2QfrBxL+7KaAPWQmCEoem5GIvW/HYepvI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773147457; c=relaxed/simple; bh=tu2Gxm6migseLbVRCGxJBC9msahNRSNXxjCo6hBhLPk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f+0RAwvJMOnwJbRV+rQgDRiZcaicwuuiuLnjWSR57TwS4Kv/56ZEbj9IATtf3ToIW4NZ75pl7v1Ef6fy0e6I/HGvFGnWkVAlO3mDHkI6buKue1w+ikJibAc9Jdv2WYMap5tGHRfhUhXVCFfVuRj7GDmhobCGnQXajLDHZaEg35s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fvWU2tMQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gwZUmQxv; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fvWU2tMQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gwZUmQxv" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ACaYsr303910 for ; Tue, 10 Mar 2026 12:57:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dbpq8Q3E6rdb+1y5IxmKtuLhvmPIDFUCQzWva345ooY=; b=fvWU2tMQKg7wjDiJ hN47G14LOWFg7XpsLLWBz60qPbI84BtEhKVtWAa78U97uyWkli27Twrb/TLko+At U5lAahNCBKsXE659McDjQ8VWGE4ouN2ENhEtAt2ZaEtskYZfQeLKMNb7n6lZAOvw B1eQ3QjWc4N12bEEp0x6yiK5C8A8mzc/1cQBl9xY2+ittoLQTXATz83j4ezKB2Q9 8dtd3DoGzBfQs5pnGwGkDdZVtE/wgo+lhsnDyqcJgFw2qShhTOQiP0VMlVokJOeC fKZ3qR9uGOm8KdUVjuiBbL4N6OX3AdoUQ3LUM3sjAO6/Nc4PAuWM+Wfa5V7kEkrV KCCKCQ== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cthjf0hys-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 12:57:35 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb39de5c54so832137085a.0 for ; Tue, 10 Mar 2026 05:57:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773147455; x=1773752255; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dbpq8Q3E6rdb+1y5IxmKtuLhvmPIDFUCQzWva345ooY=; b=gwZUmQxvkloDeP2tUOh+Nh3XNafUga0FFkF1XFUD4s+a0B60IfaXz4jmwh2isSrqrW WLlpYlGyJ+TtoUnHh1T73i8SWMnm4OZzEh7IVvpdYjqwpSGBuu6D2CgoJVtq9HCdAyoL +z41YQF/KxytEBS0/dWkoXzuPZxIwG1l9Vx3t8jijxwb/zGRr78ASyDJumBp8DMdnSnB blPTw9PB18qartQZLnSIpCpYq5vzsmG/Nj8MdR9a9id8xsGmUTZCGQkeMPAmvPSpVo6F r+Q/j4wk+SkXGwLNPAy8azJX271vl7iotIxFEm/KvwvmgBhvC9I2BN7qMAKOldVWalsJ SIZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773147455; x=1773752255; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dbpq8Q3E6rdb+1y5IxmKtuLhvmPIDFUCQzWva345ooY=; b=lxBgMxqr8/M12oww+sYOLhWC8Y7yRp3TnThqe5w7k+ltnLTdq0uEtlrqePNRfSxme6 lZ/kNZQGpvMG7EvlmahrrnQWORODZY0hgaRMZwWwPBxwT6qS+ZWs3Dr7QnhFGZiF67wd iiYiJnUqAvDWjPgIE9qyhX4Fqm/LDPz6KhkU3zifYquEI++pko7j7P6Rzoe0HHOnYOvs vBbPLL5MPLllY+zzgq4T8q+8YngwaA6xfxXRYu5txsrhf9N3lq+/DmqQvVvvWPR3LYB1 2TLPMx7IkDnc9s8hjXCSTQ3HDiaNt12oEcfK/FDpIkib6chQV1U2kcelaHxgCz8tk3E8 iXHQ== X-Forwarded-Encrypted: i=1; AJvYcCWgMRKwm2lrFaQ0+pEz5ZW9RRZYA7xltWMZf5UvEuzgUANE0uAxxRHMPsiLMh5TdwSSWhVv05NWs2G+hi0=@vger.kernel.org X-Gm-Message-State: AOJu0YytjKccpT0vHrByyxlfFOq2SnitRYnUfhlLWhC5OW6Akmap6sYY 6OFhYmjZmVJ/mnWRFQT7TDgoLiKT9y41EFA6qHqxPLobHHjfsav7rF15ut/YfeY921+3J/aBsBg HkNTf9eu/Ux8afDuVfpETamLyc+PpZkARgtQ1nlzxq//uYuLWNY31cNZqzN5Y91KlsAM= X-Gm-Gg: ATEYQzyarjIJsCkz8/tddNN6/9KXzGVQZIO4YuVykWBYL9+5NeMoPGEZF8zO18Wua2t FKuKaySFXJhfuiNKJxe0VIZ97qutN8QMryVIf9b/aihFptg2BX9EvKOcPsYGYVvhP0ivWumqrJ7 83KHSKpXsXbGQL7/frwEf53esOjfMc8nL6mReJpIV9XYZzT8iJzNxuK0gKZxIO0cGOliEoTJC+t FqaTLEnU1A+0KbqcGbpTY8XSEH+0vIIJ5YrIzRjgbzop9QyPv9Gp+ylvrCO4Vcadp9GR5fldcrW IkxlzdCSSd2PEui7Wzo92wtdQZ2G4byOxWA5L1MfH6/pVlL6zi0PbZoG/gBj30i9ZQZKWIe/tzZ HXm3e0YsX8n5yFaiZMjEzFosCpHnv85t50tlen4EXEhJd+vOfG67f8y3FftBTcv+MOzmIXhHZwd GoYjI= X-Received: by 2002:a05:620a:1a92:b0:8cd:9599:b7c6 with SMTP id af79cd13be357-8cd9599bab0mr184206085a.2.1773147454856; Tue, 10 Mar 2026 05:57:34 -0700 (PDT) X-Received: by 2002:a05:620a:1a92:b0:8cd:9599:b7c6 with SMTP id af79cd13be357-8cd9599bab0mr184201785a.2.1773147454284; Tue, 10 Mar 2026 05:57:34 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942ef8b6a1sm473128566b.18.2026.03.10.05.57.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 05:57:33 -0700 (PDT) Message-ID: <8ccf631d-9423-4997-b142-64d36afb25fe@oss.qualcomm.com> Date: Tue, 10 Mar 2026 13:57:30 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 23/24] soc: qcom: ubwc: sort out the rest of the UBWC swizzle settings To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260306-ubwc-rework-v1-0-9cfdff12f2bb@oss.qualcomm.com> <20260306-ubwc-rework-v1-23-9cfdff12f2bb@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260306-ubwc-rework-v1-23-9cfdff12f2bb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: aM7cM5gvrEP99NcakqTic4-K9p6oKFfO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDExMiBTYWx0ZWRfXx40Tt0Ce/4Jq 2Q38XIhF8Dqhc97Vb8wfAPBtTTUtG+/ywiocIijiooijpXeU6drf9TchZmUxpUgalYTx8eCGEcp OdhN2tY8P00Mo1K0g8+hxJOimv8qGcq8vxpspJlS2fdQDwJul/ha/rVXUTPAwxwwt8iL1vECuT4 YeMLjRpMUAxduRxYhF3gYUE0YpAYjE2rLHfvjZRCjWWpu1RtxIE5qesQXOqkEa1g/8R0mW44iP2 sDIddMzlSTVnQF8UwEw8OIpPnfP+WwOoqdX7tYps73v0vwe8T2Lrb4cty4a7RqemjogAQwlkYFT AaENQhk5k2uZFKkbAXg4/VIWxwI5gpYMoWA3Pj8zHuPLS5BOFFofBw78h16cSKef+nVgjr/phYq CQHBR696WmmOOFlZOczfvo3mXnmgsNWiCyrJi5GEfd2j/9GyfLxAf1e9/lKCv3ez0pu/qBydTfQ Bs2hgm/OvNaGKiGXNrQ== X-Authority-Analysis: v=2.4 cv=A71h/qWG c=1 sm=1 tr=0 ts=69b0153f cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=KV6pvVub3WdHM6TKT1gA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: aM7cM5gvrEP99NcakqTic4-K9p6oKFfO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100112 On 3/6/26 5:47 PM, Dmitry Baryshkov wrote: > Sort out the remaining UBWC swizzle values, using flags to control > whether level 2 and level 3 swizzling are enabled or not. > > Signed-off-by: Dmitry Baryshkov > --- [...] > @@ -101,11 +96,16 @@ static inline u32 qcom_ubwc_swizzle(const struct qcom_ubwc_cfg_data *cfg) > UBWC_SWIZZLE_ENABLE_LVL2 | > UBWC_SWIZZLE_ENABLE_LVL3; > > - if (cfg->ubwc_enc_version < UBWC_4_0) > - return UBWC_SWIZZLE_ENABLE_LVL2 | > - UBWC_SWIZZLE_ENABLE_LVL3; > + u32 ubwc_swizzle = UBWC_SWIZZLE_ENABLE_LVL2 | > + UBWC_SWIZZLE_ENABLE_LVL3; > + > + if (cfg->flags & UBWC_FLAG_DISABLE_SWIZZLE_LVL2) > + ubwc_swizzle &= ~UBWC_SWIZZLE_ENABLE_LVL2; > + > + if (cfg->flags & UBWC_FLAG_DISABLE_SWIZZLE_LVL3) > + ubwc_swizzle &= ~UBWC_SWIZZLE_ENABLE_LVL3; > > - return cfg->ubwc_swizzle; > + return ubwc_swizzle; This is a little messy, but so is the valid configuration matrix.. Reviewed-by: Konrad Dybcio Konrad