From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A06272E77 for ; Thu, 8 May 2025 14:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746715174; cv=none; b=n2e8Wm/0E07zH52DuqrWoC9JjU7mOembuf5F+bxZ/1h8R5/VKaXMSJ+2GRierDeBvUJ/TOniu+7BVheXEBUrw/p7g52rG7bY1vZNZAVmdEsawmTg+APcBtwENZFg3Lkpz/JMk2KhDfdPUGLletvEaHCrEqSVyFyET+KOWLTrJog= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746715174; c=relaxed/simple; bh=7SFIfuSIdF6iwTYDjR9PodBeYZwFPC0HP1GBoBKDJWY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JiggOPl+fLdhykT3ki+3CV5D/2+zpc40RPCBJrGerzzUAfUTGEfgT0midLSYpo4wgPP+HH/qJeE2LpdGUcoK7rJDxhxwal870OW4HdwLRy9g3Idq1dWFyJBXewr7huf0ZiRLyDHEyb0g5YWbHCtwx0m3rjx3IUUOoO6CDZ4rmQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YP6Hh1Vv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YP6Hh1Vv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746715171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yY5DszwP1cavz4WI2RRVaVBg9VnEs1aOFrxrSP0UlNQ=; b=YP6Hh1Vvp0QkTCmtoW6pqP7nekswbfQgKBq6H8heJMnqxhi0oMTALzWdGXTvzpp/ZG3Jam 8HhxLyoyyGfKXdzh7KUHaQIsSCRwoHMtZ7HuKuucDD0mZ+zUT4Dcd+QtnhPqgAYQ/1gI9o uyiCusATI84t5N4k7BNCVuUElzK6Mh4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-6912qFRsMMahhTcSNdrKiw-1; Thu, 08 May 2025 10:39:30 -0400 X-MC-Unique: 6912qFRsMMahhTcSNdrKiw-1 X-Mimecast-MFC-AGG-ID: 6912qFRsMMahhTcSNdrKiw_1746715169 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a0af6219a5so511597f8f.1 for ; Thu, 08 May 2025 07:39:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746715169; x=1747319969; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yY5DszwP1cavz4WI2RRVaVBg9VnEs1aOFrxrSP0UlNQ=; b=SOYr5Kz4fN/dvDI18E+QHxvpFLWDVqqVvnxgqInub3LXX+UX+FDBDhwgSPnX5lallG VjPcNjAbSw5Th/ZK3aeFX64LEFCmdM+5P5ieACQYAy8zRARy2krA90gjQ8BS+JD+I7lq fOvWMMHdcDl6HNJYtAvGs1jZ6iNeJZznEI6VBBaIq6k8B8Wk7pblm0rsSWZsNuMG5TJM dvcIzuA3qrLX7okpUmw+730NShdMOIRZZxTRGspVcNIOkA0Jc5GunBoih+mtYgD3e4+n K2D9vAhj57/P5+g/XRRSLClIYuKjvQwnbm2cnrtEjRMAz7CpaGcCdhSr7cZuYZyTBUlO lBXA== X-Forwarded-Encrypted: i=1; AJvYcCVlu1WmOZAtXJMpnrREWRskjajOes/DQYTDA4bp8yz1hMozDHJrIsoGbX1JadJZ0fQyLxOjVrGA5RUDlaE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyv7Y+5a/VIqj/OxxQd+ATE6QWGVPuw7AMOptvImPww2lFkK3au 1WaHhA9Zj8V2eDnMdFEk2/xrM7eNTgb3MpGmZRfWbooNOsWN1+1Ur/1EfNtSbnZeYhuEvjbYBy4 ulPEBoDYB4duGTDAAr5qxZus4Eof+fNyZvMFdHghe3i+s5OPypGU036i5JiVgOQ== X-Gm-Gg: ASbGncvgqKsv5MsCbqPO7z+gQkhj87max6XX7YKKIhOwnODfBZGC87Yv8kuLCngrl2y jCqnSngDzHBmOnTh3iM2spRqGIrYsW35NUFimprw3Y7Wx3SAQS65ThDmnZ8qAWxAz2scDnOEAL6 r01gBqxkewS0SY2CPmgqspi079rTw/Aued6MG4kJjEpvnG+pqgUaOt0NAgZjVnKGwrzh9P/JE65 JeyEHXs1mmXkkFr3dJBXqJbDp2WM7A70kNRgongKuGKKhkaiJVQSayRvY6VIfdCwueBsfvlaF9T kKPN8XFht+ytqSIn2ytUfl62PHnDRhEFzQiBZKWbutj7aolzyMc71WLgYmXn+wuzpHTssk1BU0A gcc0LGAyCn4RgrKfoCn+Hue5HsJKnnVofwbXvEaM= X-Received: by 2002:a05:6000:1882:b0:3a1:f563:f84e with SMTP id ffacd0b85a97d-3a1f563f85cmr367562f8f.16.1746715169057; Thu, 08 May 2025 07:39:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxtZ6thPqjeYlxAAREXHjuk7U+W+F2Tv+JwCIRk6UUwfdFHzaginUeFhucR8+1PaA+56M7wQ== X-Received: by 2002:a05:6000:1882:b0:3a1:f563:f84e with SMTP id ffacd0b85a97d-3a1f563f85cmr367542f8f.16.1746715168682; Thu, 08 May 2025 07:39:28 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c? (p200300d82f3e590027aa5f4ab65c3d3c.dip0.t-ipconnect.de. [2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f5a4d21esm138843f8f.99.2025.05.08.07.39.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 07:39:28 -0700 (PDT) Message-ID: <8cd1e38d-cc80-40ac-bb7a-ca45b37f45df@redhat.com> Date: Thu, 8 May 2025 16:39:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: remove useless code To: Barry Song <21cnbao@gmail.com> Cc: Feng Lee <379943137@qq.com>, akpm@linux-foundation.org, ryan.roberts@arm.com, libang.li@antgroup.com, peterx@redhat.com, maobibo@loongson.cn, lance.yang@linux.dev, anshuman.khandual@arm.com, trivial@kernel.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> Yeah, but this is GUP ... ("user") ... looks like that check/handling >> was in there ever since git happened. >> >> get_gate_vma() only exists on x86-64 and uml. >> >> I wonder if that could ever actually reside > TASK_SIZE such that we >> would even need that. > > I assume that reside > TASK_SIZE can only be true on IA64? > > /* Look up a pgd entry in the gate area. On IA-64, the gate-area > resides in the kernel-mapped segment, hence we use pgd_offset_k() > here. */ > #define pgd_offset_gate(mm, addr) pgd_offset_k(addr) > > Since IA64 is dead, is the code also dead? It seems we can safely move > forward with the approach you're proposing. Thanks for verifying! -- Cheers, David / dhildenb