From: Rong Qianfeng <11065417@vivo.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Rong Qianfeng <rongqianfeng@vivo.com>
Cc: Keerthy <j-keerthy@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, opensource.kernel@vivo.com
Subject: Re: [PATCH] gpio: Simplify using devm_clk_get_enabled()
Date: Tue, 20 Aug 2024 17:01:44 +0800 [thread overview]
Message-ID: <8cd47dde-07cd-42e9-b6a5-144a61243677@vivo.com> (raw)
In-Reply-To: <CAMRc=MdN045+6LzxeWa9VwuzDDbVy7o0pESXc3hrCxrnatSSLw@mail.gmail.com>
在 2024/8/20 16:36, Bartosz Golaszewski 写道:
> On Tue, Aug 20, 2024 at 10:33 AM Rong Qianfeng <rongqianfeng@vivo.com> wrote:
>> devm_clk_get_enabled() will call devm_clk_get() + clk_prepare_enable()
>> and the clock will automatically be disabled, unprepared and freed when
>> the device is unbound from the bus. So simplify .probe() and .remove()
>> accordingly.
>>
>> Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com>
>> ---
>> drivers/gpio/gpio-davinci.c | 13 ++-----------
>> drivers/gpio/gpio-stp-xway.c | 10 ++--------
>> drivers/gpio/gpio-zynq.c | 10 +---------
>> 3 files changed, 5 insertions(+), 28 deletions(-)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> I already sent a patch like that for davinci, please drop that part.
> Please split the other two into their separate per-driver patches.
Ok.
Best regards,
Qianfeng
>
> Bart
prev parent reply other threads:[~2024-08-20 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-20 8:33 Rong Qianfeng
2024-08-20 8:36 ` Bartosz Golaszewski
2024-08-20 9:01 ` Rong Qianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cd47dde-07cd-42e9-b6a5-144a61243677@vivo.com \
--to=11065417@vivo.com \
--cc=brgl@bgdev.pl \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=opensource.kernel@vivo.com \
--cc=rongqianfeng@vivo.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®