mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] tracing/probes: Mark expected switch fall-through
Date: Wed, 13 Feb 2019 12:18:56 -0600	[thread overview]
Message-ID: <8cd6bd9c-8724-ccb5-f83d-6367dac465a7@embeddedor.com> (raw)
In-Reply-To: <20190213090401.5b501e15@gandalf.local.home>



On 2/13/19 8:04 AM, Steven Rostedt wrote:
> On Tue, 12 Feb 2019 15:10:40 -0600
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:
> 
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> kernel/trace/trace_probe.c: In function ‘parse_probe_arg’:
>> kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    arg++; /* Skip '+', because kstrtol() rejects it. */
>>    ~~~^~
>> kernel/trace/trace_probe.c:303:2: note: here
>>   case '-':
>>   ^~~~
> 
> I also already applied this patch (still need to run through tests)
> 
>   http://lkml.kernel.org/r/20190114203039.16535-1-malat@debian.org
> 

Oh, that's great. :)

Thanks
--
Gustavo

      reply	other threads:[~2019-02-13 18:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-12 21:10 Gustavo A. R. Silva
2019-02-13 14:04 ` Steven Rostedt
2019-02-13 18:18   ` Gustavo A. R. Silva [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cd6bd9c-8724-ccb5-f83d-6367dac465a7@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®