From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C6A6CCA479 for ; Wed, 13 Jul 2022 14:53:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236498AbiGMOxC (ORCPT ); Wed, 13 Jul 2022 10:53:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229654AbiGMOw7 (ORCPT ); Wed, 13 Jul 2022 10:52:59 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF2543C14D; Wed, 13 Jul 2022 07:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657723978; x=1689259978; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=CNNiJMucRthl7fECf9E6Pn8zMqMHyA+cokmpGr/PmFI=; b=WnYtnqOVBbsATaC/Q6BWCrxGRDRsF3c1dJuo/XQi9uW+CIFsHwhIxQMs 6f7npLNQDw+lsGxcmaDfpeDXfT4ZTF30dWDGQgOCUt7S6k6nPwXMqWk9n YwO1LhIGeTxCsRdvy3Gi192QqYJ/IXZqUSmywRrnjLSN2dyYYabzCnwul 8=; Received: from unknown (HELO ironmsg03-sd.qualcomm.com) ([10.53.140.143]) by alexa-out-sd-01.qualcomm.com with ESMTP; 13 Jul 2022 07:52:58 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg03-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 07:52:58 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 13 Jul 2022 07:52:57 -0700 Received: from [10.216.22.132] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Wed, 13 Jul 2022 07:52:52 -0700 Message-ID: <8cde58d2-3b10-b88b-2d10-88e76fbcac06@quicinc.com> Date: Wed, 13 Jul 2022 20:22:48 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] soundwire: qcom: Update error prints to debug prints Content-Language: en-US To: Pierre-Louis Bossart , , , , , , , , , , , , , , , , , , References: <1657714921-28072-1-git-send-email-quic_srivasam@quicinc.com> <75e9b775-3bbe-0b34-2bd6-b4ac74620672@linux.intel.com> From: Srinivasa Rao Mandadapu Organization: Qualcomm In-Reply-To: <75e9b775-3bbe-0b34-2bd6-b4ac74620672@linux.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/2022 7:53 PM, Pierre-Louis Bossart wrote: Thanks for your time Pierre-Louis!!! > > On 7/13/22 07:22, Srinivasa Rao Mandadapu wrote: >> Upadte error prints to debug prints to avoid redundant logging in kernel > update Okay. Will change it. > >> boot time, as these prints are informative prints in irq handler. >> >> Signed-off-by: Srinivasa Rao Mandadapu >> --- >> drivers/soundwire/qcom.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c >> index 9df970e..a4293d0 100644 >> --- a/drivers/soundwire/qcom.c >> +++ b/drivers/soundwire/qcom.c >> @@ -573,11 +573,10 @@ static irqreturn_t qcom_swrm_irq_handler(int irq, void *dev_id) >> break; >> case SWRM_INTERRUPT_STATUS_NEW_SLAVE_ATTACHED: >> case SWRM_INTERRUPT_STATUS_CHANGE_ENUM_SLAVE_STATUS: >> - dev_err_ratelimited(swrm->dev, "%s: SWR new slave attached\n", >> - __func__); >> + dev_dbg(swrm->dev, "%s: SWR new slave attached\n", __func__); > any reason why the rate limitation was dropped? No Specific Reason as such. Will add ratelimited and re-spin it. > >> swrm->reg_read(swrm, SWRM_MCP_SLV_STATUS, &slave_status); >> if (swrm->slave_status == slave_status) { >> - dev_err(swrm->dev, "Slave status not changed %x\n", >> + dev_dbg(swrm->dev, "Slave status not changed %x\n", >> slave_status); >> } else { >> qcom_swrm_get_device_status(swrm);