From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C40881720 for ; Sat, 18 Oct 2025 12:35:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760790909; cv=none; b=OgVM5IUNH7fRzEXpLTdn3GFSMsqeQVKwlq7G6Vi2xT7bL1kOhDKoBk85QMKA+LeVfZ+ZH0IIXNfhCBeinV2Azsq/XKkQAId5nV9plPDI9ATYT9qmEvnY2fTZ2va64zZUauGkkt9RcHBbX1RvzfRuYbh77tvzpIoz7ELjE5YB43g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760790909; c=relaxed/simple; bh=zubtkUp2yt3JEr+8+Hl4KpwF7FbZB+OQgzpUVKT1W0Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qvM1nxy87akuerNHY2yFU9rmKk2Gs6PcZ4WXydn/d+35Hv9n3FCq5FsPxyJmha561EAQgosJgzQk1EODUSgWvUQ/ilcGBmnvWCcFCF97uQnDCbKGqqvFIng5+LRMAFnrh0VVJDc9tJfCD/vR5pl5uo4Ty4cA0BaR0yfAR+3gHOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wp7t0Tsc; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wp7t0Tsc" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-267facf9b58so19741985ad.2 for ; Sat, 18 Oct 2025 05:35:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760790907; x=1761395707; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=LWHTNJbyaS31DH5v4N3tc7dWchDlomjozkszGkRyjQQ=; b=Wp7t0TscZzG3OeM19q2Mi4JyrsoEt5fbq7vdBt1XpmYo10h2bhXLVhBiBwgJpE2Eva EweYphIWtZYXXUECcmOORgKnsbYcOr7H8VPj/vRQFs69brxNFRAr5fumf1SH2c9rbeNl aJdWHDKkEire33uG2pAwfZf5ER1L44iR/3co1Pb3QOXn8/99VnvDNGMrVFsWXjY4gQvM WjsXPscT2ZBhMsIKpMxMPE1Q26w0BJnDv3pPU8oJFw9oACdrMUx7ookFbRiE9rfBidiu 25RyrtRSjTnon13bG7aH9P2jQqZN2AaTRn0/ev+YZiWTvsYN5AH/+6n4ndMmtlm276Z+ tvvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760790907; x=1761395707; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LWHTNJbyaS31DH5v4N3tc7dWchDlomjozkszGkRyjQQ=; b=ejLzSQKy0a8ATS+b9uCXF3mnl1hT8GzRxjMy2Am2BU5utd8y+9CskULGnyyobq6lUQ jNxh3TwHKrwxuHFvUYD+rZZyPS9sNNGbJ8zA4wUDKHvRbhloyBnANy10B1yQXVqlfVBE Sym88hwSWGGBY1EayaS2mM43Gy4zXNG9t5TwEdZvzLOpOdXICRs9cszycW6OgAq+um0p iS50eDCeaEtAVFSAiYZC5ZbArBMrb73ArBAQ98+bDN6l8Y634wAhKOGyKBUX7QUcK815 TS8t4sO2OO9icuchceYYR8TKds4kFN7gZvE4oBA/wFhPNryMcRojvNgR0HYmaY3vJ/Sg 87qA== X-Forwarded-Encrypted: i=1; AJvYcCVhjrjHEWEn/piz4BICh5ek2LeXz0G05PSSVWCXpI81X/NyceLgimLMAkkDXMJ8X1ljxtCfYEMNghXmBcM=@vger.kernel.org X-Gm-Message-State: AOJu0YzO2bvGYC+kJgs23Bb4MP8WRynS0bqtM4aZzXugK7WA9Kb8B/lZ khZ3I4TtfYE14XwIKJah15XV9n9MJ+Uwxk2wdNYyvfTMqxs7oKu11I73 X-Gm-Gg: ASbGncvmyaDgt+FqVnxzAffckZqj7MbCKnQDuz5fHilOPpWirn3jfr+gxMxgwbPjZ8V qUrbtwW4hB8d6wpMxKtzWpEnEjdLo3EV94k06Ku20MQqIyDquVPMN7broRlqlIzkFXHWI6jLPsa Tpui5NOq9aNyROUPxJ3sd+G9zTGOrhbcSwps1sc0FCBW3ykPx7VsV6TO4sZRegkepE+dpkCfWTV kqtXweFELNAPzyzjqdTt9zLz3D7KkaG/ggQ0YjSl30/4OZT3scOtwAbcdMRoaKwXG+aFDQmLEv1 wavsxa5WQHcK87dpXwD+/Ui9/kyjgpUu0EycoFXAGR36xZem5nSxqvIvkkdrcYv2JRfZ1JCGaRI eExlr9FH/64eFz4D5vEI/XOAheoRg06FMhnD1zKXU5JJLvliFAGu22zvoYMAj29RHooQXHAO14A Od3MvbcpjSJBqi X-Google-Smtp-Source: AGHT+IH0Isbj1cOmj9B6RLl67WZWl/f5gDxBFTYoh/GDd4p0sblT1uv6SbNNW/CZV0z6mtaOmb0YQA== X-Received: by 2002:a17:903:3d0d:b0:268:1034:ac8b with SMTP id d9443c01a7336-290d14e83cemr79158005ad.26.1760790906505; Sat, 18 Oct 2025 05:35:06 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-292471d7e41sm25467105ad.57.2025.10.18.05.35.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Oct 2025 05:35:06 -0700 (PDT) Sender: Guenter Roeck Date: Sat, 18 Oct 2025 05:35:04 -0700 From: Guenter Roeck To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= Cc: linux-pci@vger.kernel.org, "Maciej W . Rozycki" , Thomas Bogendoerfer , Bjorn Helgaas , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] MIPS: Malta: Use pcibios_align_resource() to block io range Message-ID: <8cdedbc4-4073-44a5-8ebf-2c8aa9da702c@roeck-us.net> References: <20251017110903.1973-1-ilpo.jarvinen@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251017110903.1973-1-ilpo.jarvinen@linux.intel.com> On Fri, Oct 17, 2025 at 02:09:03PM +0300, Ilpo Järvinen wrote: > According to Maciej W. Rozycki , the > mips_pcibios_init() for malta adjusts root bus IO resource start > address to prevent interfering with PIIX4 I/O cycle decoding. Adjusting > lower bound leaves PIIX4 IO resources outside of the root bus resource > and assign_fixed_resource_on_bus() does not link the resources into the > resource tree. > > Prior to commit ae81aad5c2e1 ("MIPS: PCI: Use pci_enable_resources()") > the arch specific pcibios_enable_resources() did not check if the > resources were assigned which diverges from what PCI core checks, > effectively hiding the PIIX4 IO resources were not properly within the > resource tree. After starting to use pcibios_enable_resources() from > PCI core, enabling PIIX4 fails: > > ata_piix 0000:00:0a.1: BAR 0 [io 0x01f0-0x01f7]: not claimed; can't enable device > ata_piix 0000:00:0a.1: probe with driver ata_piix failed with error -22 > > MIPS PCI code already has support for enforcing lower bounds using > PCIBIOS_MIN_IO in pcibios_align_resource() without altering the IO > window start address itself. Make malta PCI code too to use > PCIBIOS_MIN_IO. > > Fixes: ae81aad5c2e1 ("MIPS: PCI: Use pci_enable_resources()") > Fixes: aa0980b80908 ("Fixes for system controllers for Atlas/Malta core cards.") > Link: https://lore.kernel.org/linux-pci/9085ab12-1559-4462-9b18-f03dcb9a4088@roeck-us.net/ > Link: https://lore.kernel.org/linux-pci/alpine.DEB.2.21.2510132229120.39634@angie.orcam.me.uk/ > Reported-by: Guenter Roeck > Suggested-by: Maciej W. Rozycki > Signed-off-by: Ilpo Järvinen Tested-by: Guenter Roeck Guenter