From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2157FCD54A4 for ; Tue, 19 Sep 2023 08:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230417AbjISIUb convert rfc822-to-8bit (ORCPT ); Tue, 19 Sep 2023 04:20:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231390AbjISIUW (ORCPT ); Tue, 19 Sep 2023 04:20:22 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3691E135 for ; Tue, 19 Sep 2023 01:20:16 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiVxf-0003uN-7N; Tue, 19 Sep 2023 10:19:59 +0200 Message-ID: <8ce3f7e172a747100366ebd14d3bd74fe549ae10.camel@pengutronix.de> Subject: Re: [PATCH] arm64: dts: imx8mp: assign parent clock and rate for audio clocks From: Lucas Stach To: Shengjiu Wang , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, marex@denx.de, peng.fan@nxp.com, alexander.stein@ew.tq-group.com, laurent.pinchart@ideasonboard.com, aford173@gmail.com, Frank.Li@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, shengjiu.wang@gmail.com Date: Tue, 19 Sep 2023 10:19:57 +0200 In-Reply-To: <1695108775-22924-1-git-send-email-shengjiu.wang@nxp.com> References: <1695108775-22924-1-git-send-email-shengjiu.wang@nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shengjiu, Am Dienstag, dem 19.09.2023 um 15:32 +0800 schrieb Shengjiu Wang: > Assign parent clock for audio AHB and AXI clocks, and assign > clock rate for audio PLL1 and PLL2. > Please don't do this. Configuring all those clocks in the clock controller is a pain to override if the board uses the PLLs in any other way than the reference design. The audio AXI and AHB clocks are already properly configured with Adams patch [1], so there is no need for the changes in this patch. Please set up the audio PLLs in the board DT in peripheral nodes that are actually using those clocks. Regards, Lucas [1] https://lore.kernel.org/all/20230819105002.132750-1-aford173@gmail.com/ > Signed-off-by: Shengjiu Wang > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 6f2f50e1639c..8a8a2c4aff9f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -734,16 +734,26 @@ clk: clock-controller@30380000 { > <&clk IMX8MP_CLK_A53_CORE>, > <&clk IMX8MP_CLK_NOC>, > <&clk IMX8MP_CLK_NOC_IO>, > - <&clk IMX8MP_CLK_GIC>; > + <&clk IMX8MP_CLK_GIC>, > + <&clk IMX8MP_CLK_AUDIO_AHB>, > + <&clk IMX8MP_CLK_AUDIO_AXI_SRC>, > + <&clk IMX8MP_AUDIO_PLL1>, > + <&clk IMX8MP_AUDIO_PLL2>; > assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>, > <&clk IMX8MP_ARM_PLL_OUT>, > <&clk IMX8MP_SYS_PLL2_1000M>, > <&clk IMX8MP_SYS_PLL1_800M>, > - <&clk IMX8MP_SYS_PLL2_500M>; > + <&clk IMX8MP_SYS_PLL2_500M>, > + <&clk IMX8MP_SYS_PLL1_800M>, > + <&clk IMX8MP_SYS_PLL1_800M>; > assigned-clock-rates = <0>, <0>, > <1000000000>, > <800000000>, > - <500000000>; > + <500000000>, > + <400000000>, > + <800000000>, > + <393216000>, > + <361267200>; > }; > > src: reset-controller@30390000 {