mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aleksander Jan Bajkowski <olek2@wp.pl>
To: Andrew Lunn <andrew@lunn.ch>
Cc: olteanv@gmail.com, davem@davemloft.net, edumazet@kernel.org,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Enable LED control on 88E6171
Date: Mon, 16 Nov 2026 21:49:53 +0100	[thread overview]
Message-ID: <8ce3fdd2-2312-4a5b-8f36-7d1414ab3f83@wp.pl> (raw)
In-Reply-To: <501adfa2-70dd-4fc0-b972-eb29785116e2@lunn.ch>

Hi Andrew,

On 15/11/2026 19:54, Andrew Lunn wrote:
> On Sun, Nov 15, 2026 at 07:12:36PM +0100, Aleksander Jan Bajkowski wrote:
>> Enable LED control on the Marvell 88E6171. This switch uses a register
>> layout similar to the 6352 family, but has 4 LEDs instead of 2. Hardware
>> triggers are not supported at this moment.
> Please break this patch up.
>
> .num_leds makes a lot of sense, but please introduce it as a patch.
>
> .led_hw_triggers i'm not sure about. But please add it as a patch of
> its own.
>
>> @@ -4609,6 +4609,7 @@ static const struct mv88e6xxx_ops mv88e6171_ops = {
>>   	.port_pause_limit = mv88e6097_port_pause_limit,
>>   	.port_disable_learn_limit = mv88e6xxx_port_disable_learn_limit,
>>   	.port_disable_pri_override = mv88e6xxx_port_disable_pri_override,
>> +	.port_setup_leds = mv88e6xxx_port_setup_leds,
>>   	.port_get_cmode = mv88e6352_port_get_cmode,
>>   	.port_setup_message_port = mv88e6xxx_setup_message_port,
>>   	.stats_snapshot = mv88e6xxx_g1_stats_snapshot,
> static const struct mv88e6xxx_ops mv88e6171_ops = {
> 	/* MV88E6XXX_FAMILY_6351
>
> I assume these changes work for all members of the family?

Most likely. The ON/OFF and BLINK controls should work the
same across variious Marvell switch families. I think only
the hardware triggers differ between switch families. I can
also confirm that the 88E6341 shares the same register layout.
However, this switch has 3 LEDs. I don't have access to other
Marvell switches.

Best regards,
Aleksander


  reply	other threads:[~2026-11-16 20:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 18:12 Aleksander Jan Bajkowski
2026-11-15 18:54 ` Andrew Lunn
2026-11-16 20:49   ` Aleksander Jan Bajkowski [this message]
2026-11-16 18:28 ` netdev-bot+sashiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ce3fdd2-2312-4a5b-8f36-7d1414ab3f83@wp.pl \
    --to=olek2@wp.pl \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®