From: matt mooney <mfm@muteddisk.com>
To: kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 11/24] memstick: change to new flag variable
Date: Fri, 24 Sep 2010 12:17:21 -0700 [thread overview]
Message-ID: <8cea68a58c5ddba79fc96e93fa0b23681e6a7ffe.1285355033.git.mfm@muteddisk.com> (raw)
In-Reply-To: <ec9520aca140f253d8bad33cf35b8e668e7e9c9c.1285355033.git.mfm@muteddisk.com>
In-Reply-To: <e0bdab5d2e8c52041c003de68ba774c3e706716c.1285355033.git.mfm@muteddisk.com>
The EXTRA_CFLAGS assignment in memstick/Makefile was not accomplishing
anything because this flag only has effect on sources at the same level
as the makefile (i.e., per directory). Since both core/ and host/ rely
on MEMSTICK_DEBUG, the subdir-ccflags-y variant seems to be the
appropriate choice.
Signed-off-by: matt mooney <mfm@muteddisk.com>
---
drivers/memstick/Makefile | 4 +---
drivers/memstick/core/Makefile | 4 ----
drivers/memstick/host/Makefile | 4 ----
3 files changed, 1 insertions(+), 11 deletions(-)
diff --git a/drivers/memstick/Makefile b/drivers/memstick/Makefile
index dc160fb..9862359 100644
--- a/drivers/memstick/Makefile
+++ b/drivers/memstick/Makefile
@@ -2,9 +2,7 @@
# Makefile for the kernel MemoryStick device drivers.
#
-ifeq ($(CONFIG_MEMSTICK_DEBUG),y)
- EXTRA_CFLAGS += -DDEBUG
-endif
+subdir-ccflags-$(CONFIG_MEMSTICK_DEBUG) := -DDEBUG
obj-$(CONFIG_MEMSTICK) += core/
obj-$(CONFIG_MEMSTICK) += host/
diff --git a/drivers/memstick/core/Makefile b/drivers/memstick/core/Makefile
index 8b2b529..ecd0299 100644
--- a/drivers/memstick/core/Makefile
+++ b/drivers/memstick/core/Makefile
@@ -2,10 +2,6 @@
# Makefile for the kernel MemoryStick core.
#
-ifeq ($(CONFIG_MEMSTICK_DEBUG),y)
- EXTRA_CFLAGS += -DDEBUG
-endif
-
obj-$(CONFIG_MEMSTICK) += memstick.o
obj-$(CONFIG_MSPRO_BLOCK) += mspro_block.o
diff --git a/drivers/memstick/host/Makefile b/drivers/memstick/host/Makefile
index 12530e4..a1815e9 100644
--- a/drivers/memstick/host/Makefile
+++ b/drivers/memstick/host/Makefile
@@ -2,9 +2,5 @@
# Makefile for MemoryStick host controller drivers
#
-ifeq ($(CONFIG_MEMSTICK_DEBUG),y)
- EXTRA_CFLAGS += -DDEBUG
-endif
-
obj-$(CONFIG_MEMSTICK_TIFM_MS) += tifm_ms.o
obj-$(CONFIG_MEMSTICK_JMICRON_38X) += jmb38x_ms.o
--
1.7.2.1
next prev parent reply other threads:[~2010-09-24 19:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 19:17 [PATCH 01/24] base: " matt mooney
2010-09-24 19:17 ` [PATCH 02/24] char: " matt mooney
2010-09-24 19:17 ` [PATCH 03/24] dma: " matt mooney
2010-09-24 19:17 ` [PATCH 04/24] hwmon: " matt mooney
2010-09-24 19:17 ` [PATCH 05/24] i2c: " matt mooney
2010-09-24 19:17 ` [PATCH 06/24] ide: " matt mooney
2010-09-24 19:17 ` [PATCH 07/24] ieee802154: " matt mooney
2010-09-24 19:17 ` [PATCH 08/24] infiniband: " matt mooney
2010-09-24 19:17 ` [PATCH 09/24] input: " matt mooney
2010-09-24 19:17 ` [PATCH 10/24] isdn: " matt mooney
2010-09-24 19:17 ` matt mooney [this message]
2010-09-24 19:17 ` [PATCH 12/24] message: " matt mooney
2010-09-24 19:17 ` [PATCH 13/24] misc: " matt mooney
2010-09-24 19:17 ` [PATCH 14/24] mmc: " matt mooney
2010-09-24 19:17 ` [PATCH 15/24] net: " matt mooney
2010-09-24 19:17 ` [PATCH 16/24] pci: " matt mooney
2010-09-24 19:17 ` [PATCH 17/24] power: " matt mooney
2010-09-24 19:17 ` [PATCH 18/24] pps: " matt mooney
2010-09-24 19:17 ` [PATCH 19/24] rapidio: " matt mooney
2010-09-24 19:17 ` [PATCH 20/24] rtc: " matt mooney
2010-09-24 19:17 ` [PATCH 21/24] scsi: " matt mooney
2010-09-24 19:17 ` [PATCH 22/24] spi: " matt mooney
2010-09-24 19:17 ` [PATCH 23/24] usb: " matt mooney
2010-09-24 19:17 ` [PATCH 24/24] video: " matt mooney
2010-09-24 20:02 ` [usb-storage] [PATCH 23/24] usb: " Matthew Dharm
2010-09-24 20:28 ` matt mooney
2010-09-24 23:21 ` matt mooney
2010-10-08 18:33 ` [PATCH 22/24] spi: " Grant Likely
2010-09-25 1:37 ` [rtc-linux] [PATCH 20/24] rtc: " Wan ZongShun
2010-10-15 19:54 ` [PATCH 16/24] pci: " Jesse Barnes
2010-09-24 19:25 ` [PATCH 15/24] net: " John W. Linville
2010-09-24 20:01 ` David Miller
2010-09-28 13:02 ` [PATCH 13/24] misc: " Michał Mirosław
2010-09-29 22:55 ` matt mooney
2010-09-24 20:01 ` [PATCH 10/24] isdn: " David Miller
2010-09-26 10:31 ` [PATCH 07/24] ieee802154: " Dmitry Eremin-Solenikov
2010-09-24 20:01 ` [PATCH 06/24] ide: " David Miller
2010-09-25 11:26 ` [PATCH 05/24] i2c: " Jean Delvare
2010-09-26 2:12 ` matt mooney
2010-09-26 7:29 ` Jean Delvare
2010-09-26 18:07 ` matt mooney
2010-09-29 13:56 ` Jean Delvare
2010-09-24 23:54 ` [lm-sensors] [PATCH 04/24] hwmon: " Guenter Roeck
2010-09-27 15:04 ` Valdis.Kletnieks
2010-09-27 17:23 ` matt mooney
2010-09-25 2:52 ` [PATCH 01/24] base: " Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cea68a58c5ddba79fc96e93fa0b23681e6a7ffe.1285355033.git.mfm@muteddisk.com \
--to=mfm@muteddisk.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®