From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C357AC433F5 for ; Fri, 30 Sep 2022 19:45:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231582AbiI3TpY (ORCPT ); Fri, 30 Sep 2022 15:45:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231204AbiI3TpS (ORCPT ); Fri, 30 Sep 2022 15:45:18 -0400 Received: from mail-oo1-xc30.google.com (mail-oo1-xc30.google.com [IPv6:2607:f8b0:4864:20::c30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C95EE2D1ED for ; Fri, 30 Sep 2022 12:45:16 -0700 (PDT) Received: by mail-oo1-xc30.google.com with SMTP id d74-20020a4a524d000000b004755f8aae16so2904192oob.11 for ; Fri, 30 Sep 2022 12:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kali.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=m4m3sjgLDE+/ONrvXDCMDbMUrc0dF2u9xPL/tSwjQTU=; b=PMJp9UEV6calyOMaNaIFQLBiUAnI0ygAWWxw04JKFOEkMBqNaT0NytXpBLaPBezSQ+ kgyGAyLsPPgBr1XmBt4eXUVQtCGn98+p/d5HzEDHKCQi4he4TlAdbT+mi+eqy1vnb4Yq XumkvS+RZfqySXlOWoP+to9G1osC+jsOFRaU5PjTS8ak9Uv6A09h6ztcUQomq6S9kkrD bofF0/wucJGNMpWwfhN6l7TsX94Jclyaz/+e8Y4Kg+JAOXjjq/nxk+AxFrDstduVcWH+ XZuwhdFoI4aFWtHd0dr0ZNawchHVoiC8yikIBYDICLGYR1EjOjnty/MjQQCaHn0dr+ag UuZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=m4m3sjgLDE+/ONrvXDCMDbMUrc0dF2u9xPL/tSwjQTU=; b=6ZNSAm0u1v/BxIHzE/IdNSm5cR+Uxt87L4nfVNp4b0w7ba9myd2QlfveU8puoxyoAw 8Dt25rvQyetUVdcGCQh2KnNCfBY7XmWZtRasrrJD2Tk78KBS7IdPjbAlquZx3K8piImW XxafNgb5EObEx4X6PBtgFX6ddqORadgm7nSVBIrbylh+M4QToBCZGKV9gjB4aYxiSqNs JoZFbvaCDJMndh76+j83usBNmxH2qr7OSK0htbt1/mGQzwVEM48LUxQj9+pDhseNjosL OoKrpIhqF/Y0+n5sgIgHDWpErTi7Lv8mHSG/3XJf3UFGyC+ewkLcEspQ1c6rlQoj/Z2+ Uq9A== X-Gm-Message-State: ACrzQf1MaTZ4N49OicexzqyezrZWuFRWVLFovUR7RCRyYqyBkHPm7Bli DlQ+8WHzwsPVoUK1/RmGTNDAeg== X-Google-Smtp-Source: AMsMyM7bD9TGDk6oI2MAvPg/h/AW/SzY20K8Y4e5K/IJ5U6nlmPuG1ueW2fbwgzgvbTsWxyt9mRH6g== X-Received: by 2002:a9d:7c89:0:b0:655:dfb1:331c with SMTP id q9-20020a9d7c89000000b00655dfb1331cmr3968455otn.224.1664567116057; Fri, 30 Sep 2022 12:45:16 -0700 (PDT) Received: from [192.168.11.16] (cpe-173-173-107-246.satx.res.rr.com. [173.173.107.246]) by smtp.gmail.com with ESMTPSA id p21-20020a9d6955000000b00657a221eb71sm743272oto.65.2022.09.30.12.45.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 12:45:14 -0700 (PDT) Message-ID: <8cead1ca-e293-5172-d305-f8d308f93379@kali.org> Date: Fri, 30 Sep 2022 14:45:12 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH 1/3] arm64: dts: qcom: sdm850-lenovo-yoga-c630: correct I2C12 pins drive strength Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Sudeep Holla , Lee Jones , Arnd Bergmann , Vinod Koul , Xilin Wu , Molly Sophia , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20220930192039.240486-1-krzysztof.kozlowski@linaro.org> From: Steev Klimaszewski In-Reply-To: <20220930192039.240486-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/30/22 2:20 PM, Krzysztof Kozlowski wrote: > The pin configuration (done with generic pin controller helpers and > as expressed by bindings) requires children nodes with either: > 1. "pins" property and the actual configuration, > 2. another set of nodes with above point. > > The qup_i2c12_default pin configuration used second method - with a > "pinmux" child. > > Fixes: 44acee207844 ("arm64: dts: qcom: Add Lenovo Yoga C630") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > index be59a8ba9c1f..74f43da51fa5 100644 > --- a/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > +++ b/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts > @@ -487,8 +487,10 @@ pinconf { > }; > > &qup_i2c12_default { > - drive-strength = <2>; > - bias-disable; > + pinmux { > + drive-strength = <2>; > + bias-disable; > + }; > }; > > &qup_uart6_default { Tested-by: Steev Klimaszewski