From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C49CEC27C40 for ; Wed, 22 Nov 2023 20:22:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343681AbjKVUWV (ORCPT ); Wed, 22 Nov 2023 15:22:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232106AbjKVUWT (ORCPT ); Wed, 22 Nov 2023 15:22:19 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB93D1BF for ; Wed, 22 Nov 2023 12:22:14 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-50aaaf6e58fso156787e87.2 for ; Wed, 22 Nov 2023 12:22:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700684533; x=1701289333; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WBmHXv1LFLt1CUldNSms0b65giZwYaTIfaDf3i1BEjc=; b=f2A9hrcKziz4DmQj8LJNwJ3Fu0UjjLWJ0lgtiHC2bVfisJR6yT8f1iFAeiUuOTt2KK 06bQfzJHXe6HI/UhLM3W2VeAF65eFKDxfXjqlUxfpgpXxMSs0/iLOw0m+/1O2zJl9i8C MVnw/EAk2j67Ogo20Ook/qME373Wevc41ZMxvzNGLJgkzmaIl17sDcx3yvnb7aWDIvPY ksemWt/7C5kVYkRjcP3+aiVFbNMZUXy+mVumjRsurxnDrs1svufQ1JUkP5eTcTA0ggKz 03yx6pFzU6ZuIrLDzu2SqKO2Q29y+w6VQCvLxCpLVJso+Y73TghE/egUr1Aa4eKJOuUL np5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700684533; x=1701289333; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WBmHXv1LFLt1CUldNSms0b65giZwYaTIfaDf3i1BEjc=; b=A5G8Vnf8DorfzLWkeO46CoOfQ4k56+3bTtLgIbTQ8uThjnY6v4DDpzmbuV5S8eWXCz xMvMCNYHwXD8VVcEy4oGToVS5/L9sxB3fx4S5XtvF3xf70JKRHwa+VQef+5TYNDBN4vp ty5NwZ6k6QFOEVZ5hCRc7MgOSPZg9tVPngvClr7co7I7ljeg8eof69ZTKNCYTBbnjneO +qK844HfFl4V/w82hxpAjOe0iGimawd7XCM8g9FxUGpAQT3BUH5FM0AdbyxzGQ9n965L 0KlyMgX1nfPifWpREXotbbndSbPUS4erB9hQ76b7FcvEC3I2isLgHCJeOOHrXwW4S6NT dKqA== X-Gm-Message-State: AOJu0YyumXhMe8j4Cx1y2PmmPXxawDywDlF8jagH+jfa5ow4PURLxtyy IDaewuxGwj1+u1vsGY60sLMytA== X-Google-Smtp-Source: AGHT+IHGxTrXXz1SuL83vrF7iMrR32b3rAoIFAEJa+OZPMHpiDYsFrzbO0DTAdeo8G60yK8xL1j5+A== X-Received: by 2002:a05:6512:4020:b0:507:a0d7:bd19 with SMTP id br32-20020a056512402000b00507a0d7bd19mr1298557lfb.13.1700684532935; Wed, 22 Nov 2023 12:22:12 -0800 (PST) Received: from [172.30.204.74] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id d24-20020a056512369800b005091314185asm1952576lfs.285.2023.11.22.12.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 12:22:12 -0800 (PST) Message-ID: <8cece5d7-0fcb-4366-be72-6494842b7c41@linaro.org> Date: Wed, 22 Nov 2023 21:22:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 8/9] arm64: dts: qcom: ipq5332: add support for the NSSCC Content-Language: en-US To: Kathiravan Thirumoorthy , Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Catalin Marinas , Will Deacon Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20231121-ipq5332-nsscc-v2-0-a7ff61beab72@quicinc.com> <20231121-ipq5332-nsscc-v2-8-a7ff61beab72@quicinc.com> From: Konrad Dybcio In-Reply-To: <20231121-ipq5332-nsscc-v2-8-a7ff61beab72@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/23 15:30, Kathiravan Thirumoorthy wrote: > Describe the NSS clock controller node and it's relevant external > clocks. > > Signed-off-by: Kathiravan Thirumoorthy > --- > Changes in V2: > - Update the node names with proper suffix > --- > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > index 42e2e48b2bc3..5cbe72f03869 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi > @@ -15,6 +15,18 @@ / { > #size-cells = <2>; > > clocks { > + cmn_pll_nss_200m_clk: cmn-pll-nss-200m-clk { > + compatible = "fixed-clock"; > + clock-frequency = <200000000>; > + #clock-cells = <0>; > + }; > + > + cmn_pll_nss_300m_clk: cmn-pll-nss-300m-clk { > + compatible = "fixed-clock"; > + clock-frequency = <300000000>; > + #clock-cells = <0>; > + }; > + > sleep_clk: sleep-clk { > compatible = "fixed-clock"; > #clock-cells = <0>; > @@ -473,6 +485,22 @@ frame@b128000 { > status = "disabled"; > }; > }; > + > + nsscc: clock-controller@39b00000{ > + compatible = "qcom,ipq5332-nsscc"; > + reg = <0x39b00000 0x80000>; > + clocks = <&cmn_pll_nss_200m_clk>, > + <&cmn_pll_nss_300m_clk>, > + <&gcc GPLL0_OUT_AUX>, > + <0>, > + <0>, > + <0>, > + <0>, > + <&xo_board>; > + #clock-cells = <0x1>; > + #reset-cells = <0x1>; 0x1 -> 1, it's a number and not a register Konrad