From: Javier Martinez Canillas <javierm@redhat.com>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel <dri-devel@lists.freedesktop.org>,
kernel-janitors@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH][next] drm: ssd130x: remove redundant initialization of pointer mode
Date: Thu, 3 Mar 2022 09:38:03 +0100 [thread overview]
Message-ID: <8cef7451-ac6a-9ca5-b521-1eec53d30880@redhat.com> (raw)
In-Reply-To: <CAFOAJEfS9dMY5nudeFxtwchTtLnBCh7N4qKaCdqvaodnRUFKzA@mail.gmail.com>
On 3/2/22 19:29, Javier Martinez Canillas wrote:
> Hello Colin,
>
> Thanks for the patch.
>
> On Wed, Mar 2, 2022 at 6:53 PM Colin Ian King <colin.i.king@gmail.com> wrote:
>>
>> Pointer mode is being assigned a value that is never read, it is
>> being re-assigned later with a new value. The initialization is
>> redundant and can be removed.
>>
>
> Indeed.
>
> Acked-by: Javier Martinez Canillas <javierm@redhat.com>
>
Pushed to drm-misc-next (with fixed drm/ssd130x subject prefix).
Thanks!
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
prev parent reply other threads:[~2022-03-03 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 17:53 Colin Ian King
2022-03-02 18:29 ` Javier Martinez Canillas
2022-03-03 8:38 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cef7451-ac6a-9ca5-b521-1eec53d30880@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=colin.i.king@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®