From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 814A11D67BE for ; Fri, 13 Sep 2024 09:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726218938; cv=none; b=Z9+IhmBjviMpPwj2MYGkopJ2z07vFsrOMGMxC3FuL3NWMN2f0JX2q4YGcTeoFSYhYvNWEl5uXWMANq2F2BEJ3SO0OoZuBl0X4BoBSB5D/voefoqYxmjIJ3HQdw2i1HNkxrP+j9AifpyHuguLOP8KXhBnSsiQhBc7Wym06Uf4Jtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726218938; c=relaxed/simple; bh=yjxj0FSJpzDqTDqbkb+Ys5lDxT533fcsCSKxOxLDXqE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=czNilRDgTFjEKZcI4ETJB5mb7c6LxmMQbVa3LzjeSuCwcOIi8WkU5MiLuJsVoS0+NDBptgYyGXnbNI4AEWuEdshkwWG7aTK7u1WTNWUpTi1uoDCgPwouhNkiH1K+kEK2bFZ2Efj2pAS0TynaJmy8rkIK6GmyKR2l0ciCKnDMNrs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org; spf=none smtp.mailfrom=blackwall.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b=hcW6oCG7; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=blackwall.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=blackwall.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=blackwall-org.20230601.gappssmtp.com header.i=@blackwall-org.20230601.gappssmtp.com header.b="hcW6oCG7" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5c26311c6f0so2478739a12.3 for ; Fri, 13 Sep 2024 02:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20230601.gappssmtp.com; s=20230601; t=1726218935; x=1726823735; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zP7o2lXiLqDCW/l4Y6N12juw+Nevs/iHS84Bz9Lspa0=; b=hcW6oCG7UsWg8lqj1SfpbfEYgFYHzvc8MRSQFB/afVCmLbLYKL3MiCqkl0d2emVWYd nvRqV4ojd/+Jau6JFuxvGJQ/zAcn/TBhb30ud/kQU0eMb7Syuge/REB/v+24vztNWFQf oPaCyMD344Upcg6J8Hz/T0hGkfk0G423DJ6z3OEjZkU+UGNtPTgX8MxtjITkyWu8OByq ZJSitXmGPA08O1Z+lpNt3Qfkew2x93D1PmszK16drxktOqGBp3kKx4CzlqY/3o44X35c deotYhfUvTwHgmYn3VNqPtXGtRdfKuFoA6b/7OJ1O/aWJcJRNKrPSx1mVk/UtVnhEOF2 eB7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726218935; x=1726823735; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zP7o2lXiLqDCW/l4Y6N12juw+Nevs/iHS84Bz9Lspa0=; b=IVCKQO0tDR7mNUvQR4PQtwkQcAZTlQoqS2KdgJ30KtMOpyMO8A3j4i+jG3HsjhBjHB HpPeFSLMQ/ArPue4zaP96EaOYxiMli3qsPkBPzUqjXVQiAEL835E+Ic9Cy17p2ltSSTg DUoPdCBe3NG4zYpf2dlbrHvd7zMk6HyIokzUd4iYvY0qbzAaLHqByjNVMpJRtE8SPQjt x6M8xkoeoAT9z4ZQut4aSA0nHYFy8tuvz5asth+DZCBOXHcMdi2pfR+VTSvH2PFlB0Nr 0QbPF+dZt2hOzy70nj7HG/vW6vT8iz5zx3v146O0W0VEzFZk534WNVuQskZYpFPzbT9m bH1g== X-Forwarded-Encrypted: i=1; AJvYcCXGpx291M5Jkxpt1KWys6+U2yY7CRxd1/dGJZtKv7wiQWOrPsWwHsJWl7kQq3JixqCixXV91EbKfRR9CUw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy08OzhhPWkteeE6eTklpa71uVr3H9YIfkBsv6IFJ2vpfxd49Ai rGSvyMm3nJg++Pa+aCuaY60q8OjLkhIz/ySqn3Nc9ht/NiQ0gt4mgKlO84+N0Dg= X-Google-Smtp-Source: AGHT+IFVFni4KQY31tZpsekaGm1UaBb7ZpdiuaYbjs6baOy/7SSOoWK2lsopYFzaF0hFcAvrJOrKow== X-Received: by 2002:a17:907:3e1d:b0:a83:8591:7505 with SMTP id a640c23a62f3a-a902966f459mr584642266b.59.1726218933949; Fri, 13 Sep 2024 02:15:33 -0700 (PDT) Received: from [192.168.0.148] ([93.93.8.5]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25c72e9asm849536866b.115.2024.09.13.02.15.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Sep 2024 02:15:33 -0700 (PDT) Message-ID: <8cf0b25f-2b7f-478e-af14-b0ebd5905a79@blackwall.org> Date: Fri, 13 Sep 2024 12:15:30 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] netkit: Assign missing bpf_net_context To: Breno Leitao , kuba@kernel.org, bpf@vger.kernel.org, Daniel Borkmann , "David S. Miller" , Eric Dumazet , Paolo Abeni , Alexei Starovoitov , =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Jesper Dangaard Brouer , Sebastian Andrzej Siewior Cc: vadim.fedorenko@linux.dev, andrii@kernel.org, "open list:BPF [NETKIT] (BPF-programmable network device)" , open list References: <20240912155620.1334587-1-leitao@debian.org> Content-Language: en-US From: Nikolay Aleksandrov In-Reply-To: <20240912155620.1334587-1-leitao@debian.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/12/24 18:56, Breno Leitao wrote: > During the introduction of struct bpf_net_context handling for > XDP-redirect, the netkit driver has been missed, which also requires it > because NETKIT_REDIRECT invokes skb_do_redirect() which is accessing the > per-CPU variables. Otherwise we see the following crash: > > BUG: kernel NULL pointer dereference, address: 0000000000000038 > bpf_redirect() > netkit_xmit() > dev_hard_start_xmit() > > Set the bpf_net_context before invoking netkit_xmit() program within the > netkit driver. > > Fixes: 401cb7dae813 ("net: Reference bpf_redirect_info via task_struct on PREEMPT_RT.") > Signed-off-by: Breno Leitao > Acked-by: Daniel Borkmann > Reviewed-by: Sebastian Andrzej Siewior > --- > drivers/net/netkit.c | 3 +++ > 1 file changed, 3 insertions(+) > Acked-by: Nikolay Aleksandrov