From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF82E3E49D7 for ; Mon, 24 Aug 2026 07:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787555100; cv=none; b=MvJE/fovKTqFlnC1YBuf1dBZPS9/LmT+EfoIBzJxR5O8qaQDofDdLOZ+HGcSJoggvN7GHDpZS+7btTPvMECwAfTbatg9l1bC8fG/HcLo6qvaIYKW9/LBpFQiE4jCbZFJwTKlpEKalhGfcrdLyyxhPGxVOR1fncE9VqCe6GVt9mA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787555100; c=relaxed/simple; bh=QMYFbzkxXdNZRXYVvAPehdezlxw3oxhkLPSV5YEgZoo=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=IJ0ecSAzZqJ+CsT7y92WeySb+87CJ4UmF7EM0kPAwlWqMTQNwJbPfDIL7XOpxr728f3Go/MXJEpswWN/i2YODChz+tIobqthvkYxONG/1YDVcHdATkoEmR58Z9zRdAN4SCCaoz4kHxQjIW+q9pfehkmXJVzdY6Kys1N3YaFLOkY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IKNrMaUM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IKNrMaUM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 448BD1F000E9; Mon, 24 Aug 2026 07:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787555099; bh=13D2wQkBlESk0b3d5zsepVQdWpjB09Jw9tANNIK+4Lk=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=IKNrMaUMxCuKTbBViW+M+inSSWZIiXe4i7yfxfyTMrOoup3m+78PHBP0LZTJOgunx PIyLfVnlNcRhNrNmX/Pizf8gGHVeIVDRK5vRgeNSMcUO5MPJjJFHpjGEds19EnmlXv 7ucoMCwQ5kwVsrXctuMJ7OpEyDEEQDtGyz1zgFnVatCBYFy6WWOSxk9W3h0fPO9UOY 3gnAUAfUnMc2kEynrvnNmbrYNPSdN1lWNQ/Obfw+G5kDM4H9nDfp8ys5MISj24KiLf KW6EsOeFUj8iPenFnFdrFSmMjqBH244IRz+WuxZ17s2uWGLjZDWZ9muOJ+soQfScYF 9RNj/HPgwPgww== Message-ID: <8cf1a7a6-d2dd-4241-baf6-0ec3bd9b860a@kernel.org> Date: Mon, 24 Aug 2026 15:04:56 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Wenjie Qi , Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v1 04/12] f2fs: cache: introduce writeback thread To: Wenjie Qi References: <20260820031721.12218-1-chao@kernel.org> <20260820031721.12218-5-chao@kernel.org> <20260823125448.3228967-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260823125448.3228967-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/23/26 20:54, Wenjie Qi wrote: > Hi Chao, > >> cache_thread->cache_wb_task = kthread_run(f2fs_cache_writeback_kthread, >> sbi, "%s", name); >> if (IS_ERR(cache_thread->cache_wb_task)) >> return PTR_ERR(cache_thread->cache_wb_task); > > After `kthread_run()` returns an error pointer, `cache_wb_task` retains that > value. The later startup and stop paths distinguish only NULL from non-NULL, > and the stop path passes a non-NULL value to `kthread_stop()`. > > Is `cache_wb_task` expected to remain an error pointer after > `f2fs_start_cache_wb_thread()` returns an error? Will fix. Thanks,