mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Egger <siccegge@cs.fau.de>
To: "David S. Miller" <davem@davemloft.net>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Jiri Pirko <jpirko@redhat.com>, Joe Perches <joe@perches.com>,
	Stephen Hemminger <shemminger@vyatta.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: vamos-dev@i4.informatik.uni-erlangen.de
Subject: [PATCH 04/11] Removing dead CASSINI_MULTICAST_REG_WRITE
Date: Wed, 14 Jul 2010 14:40:53 +0200	[thread overview]
Message-ID: <8cf1d83f53d9cedceaf7567deb03bb211a83d32c.1279110895.git.siccegge@cs.fau.de> (raw)
In-Reply-To: <cover.1279110894.git.siccegge@cs.fau.de>

CASSINI_MULTICAST_REG_WRITE doesn't exist in Kconfig, therefore
removing all references for it from the source code.

Signed-off-by: Christoph Egger <siccegge@cs.fau.de>
---
 drivers/net/cassini.c |   20 +-------------------
 1 files changed, 1 insertions(+), 19 deletions(-)

diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c
index 04a03f7..0d911ba 100644
--- a/drivers/net/cassini.c
+++ b/drivers/net/cassini.c
@@ -3063,9 +3063,6 @@ static void cas_init_mac(struct cas *cp)
 {
 	unsigned char *e = &cp->dev->dev_addr[0];
 	int i;
-#ifdef CONFIG_CASSINI_MULTICAST_REG_WRITE
-	u32 rxcfg;
-#endif
 	cas_mac_reset(cp);
 
 	/* setup core arbitration weight register */
@@ -3133,23 +3130,8 @@ static void cas_init_mac(struct cas *cp)
 	writel(0xc200, cp->regs + REG_MAC_ADDRN(43));
 	writel(0x0180, cp->regs + REG_MAC_ADDRN(44));
 
-#ifndef CONFIG_CASSINI_MULTICAST_REG_WRITE
 	cp->mac_rx_cfg = cas_setup_multicast(cp);
-#else
-	/* WTZ: Do what Adrian did in cas_set_multicast. Doing
-	 * a writel does not seem to be necessary because Cassini
-	 * seems to preserve the configuration when we do the reset.
-	 * If the chip is in trouble, though, it is not clear if we
-	 * can really count on this behavior. cas_set_multicast uses
-	 * spin_lock_irqsave, but we are called only in cas_init_hw and
-	 * cas_init_hw is protected by cas_lock_all, which calls
-	 * spin_lock_irq (so it doesn't need to save the flags, and
-	 * we should be OK for the writel, as that is the only
-	 * difference).
-	 */
-	cp->mac_rx_cfg = rxcfg = cas_setup_multicast(cp);
-	writel(rxcfg, cp->regs + REG_MAC_RX_CFG);
-#endif
+
 	spin_lock(&cp->stat_lock[N_TX_RINGS]);
 	cas_clear_mac_err(cp);
 	spin_unlock(&cp->stat_lock[N_TX_RINGS]);
-- 
1.7.0.4


  parent reply	other threads:[~2010-07-14 12:40 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-14 12:39 [PATCH 00/11] Removing dead code Christoph Egger
2010-07-14 12:39 ` [PATCH 01/11] Removing dead RT2800PCI_SOC Christoph Egger
2010-07-14 12:46   ` Luis Correia
2010-07-14 12:52     ` Ivo Van Doorn
2010-07-14 13:15       ` John W. Linville
2010-07-14 14:44         ` Felix Fietkau
2010-07-15  8:41           ` Bartlomiej Zolnierkiewicz
     [not found]             ` <AANLkTilqoYMMKYJT-YYbEzdnytUSYa0EylEiJ4x5xXXH@mail.gmail.com>
2010-07-16  7:18               ` Gertjan van Wingerde
2010-07-16 10:08                 ` Helmut Schaa
2010-07-16 15:46                   ` Gertjan van Wingerde
2010-07-16 17:44                     ` Helmut Schaa
2010-07-14 14:14       ` Bartlomiej Zolnierkiewicz
2010-07-14 12:39 ` [PATCH 02/11] Removing dead {AR,WAVE}LAN Christoph Egger
2010-07-14 19:17   ` David Miller
2010-07-14 12:39 ` [PATCH 03/11] Removing dead CASSINI_QGE_DEBUG Christoph Egger
2010-07-14 19:18   ` David Miller
2010-07-14 12:40 ` Christoph Egger [this message]
2010-07-14 12:40 ` [PATCH 05/11] Removing dead CASSINI_NAPI Christoph Egger
2010-07-14 20:36   ` David Miller
2010-07-14 12:41 ` [PATCH 06/11] Removing dead CHELSIO_T1_COUGAR Christoph Egger
2010-07-14 20:37   ` David Miller
2010-07-14 12:41 ` [PATCH 07/11] Removing dead ARCH_PNX010X Christoph Egger
2010-07-14 20:39   ` David Miller
2010-07-19 14:37     ` Christoph Egger
2010-07-14 12:41 ` [PATCH 08/11] Removing dead SH_HICOSH4 Christoph Egger
2010-07-14 20:40   ` David Miller
2010-07-14 12:41 ` [PATCH 09/11] Removing dead ETRAX_NETWORK_RED_ON_NO_CONNECTION Christoph Egger
2010-07-14 20:42   ` David Miller
2010-07-30 17:28   ` Jesper Nilsson
2010-07-14 12:41 ` [PATCH 10/11] Removing dead NETWINDER_{T,R}X_DMA_PROBLEMS Christoph Egger
2010-07-14 20:43   ` David Miller
2010-07-14 12:41 ` [PATCH 11/11] Removing dead REDWOOD_{5,6} Christoph Egger
2010-07-14 12:48   ` Nicolas Pitre
2010-07-14 20:44   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cf1d83f53d9cedceaf7567deb03bb211a83d32c.1279110895.git.siccegge@cs.fau.de \
    --to=siccegge@cs.fau.de \
    --cc=adobriyan@gmail.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=jpirko@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=vamos-dev@i4.informatik.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®