From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 884285FDA7 for ; Sat, 28 Feb 2026 13:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772285618; cv=none; b=jDtjN4o9pFvZ+t9LNYrUd5YnPMeortEBFIZ0/sPLow6yHwVbpiEYtUPEmWkkIrHHcbyyOciyVlalTvkQlSGhP0ywsIh1dXna3yhmgJOy9iT/Zl31z39otQJoGTgwlPyAbwLgCR0EIVFajeteNWepkwwF9F2jvn27W9hWkdutZJY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772285618; c=relaxed/simple; bh=gp6pd1wLFrvlv+Ak487hRTVHB348mjPXKb3hetJsyXg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aVLVcDo0aSgLQNZTeklhHao+Y7nLHylapAWzODzKxRaFX3gt8aDRfUbzhH3IjDb+Pnkzn+kUHRIW05Iqj5FHSLIbgxXnZ7lQN18Ex3wZRmrOuKcoBDZToSoznJRLDRqt+Tgx/8L7cDL5r7Oe7ef3dSadEPA1ikSMxiGTYgDu5wo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=a0clzu4c; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="a0clzu4c" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-436e8758b91so1912920f8f.0 for ; Sat, 28 Feb 2026 05:33:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1772285616; x=1772890416; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AOwo+gr17+PaBI/SlU7H+W7TFawNfdrbhqFXyTJsWvU=; b=a0clzu4c0GlFwsvBSuIgUVUJu5tBphpn+/iAoutoj/mQtNRLRk1uSpGDutAzCW1+u2 OMPGGyMcfEvqpVAIZH/m+6HQMQrWfrqODUY4cMzuyFgSE2eIzQPYuLrue08rSWBhW+zQ 5ztjLIXrgdodMzV6ceOUV+fvzTaa5GnsckY+Ns7Wue9O0iCaYyqk/Mdg6WMBTe9VTbm3 Unzs6oGCFo8/ggafMQTkLgoiAPGmTjvFnRoJVRiUaoyRbNILZ5kSb0edcYZxScHICXCW PjELlopcD+GUgPk1GKvP+bwoePJxvZGK35vEuixsHGIkJGFUFuT7+3LeFloGGlnDPepW CeJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772285616; x=1772890416; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AOwo+gr17+PaBI/SlU7H+W7TFawNfdrbhqFXyTJsWvU=; b=J8x8S+MtRAWXEMDrov3POVzZsuf/jPSXXwoSoioGqJph7exnk12YvaSO9NRxr94a74 hLyx3kGvgIg1Wp1IYk3+jmkKKq6nJdPTKhdK41lEwanMmonRtHvptoRjahCmpnWznUQk sbQ/myi5UZZMR7dSekz1QpEJvtGczSNelPH6zTH5z6IThlZ0UzMB4LFdni1QFLqu6PdT L++AE7V3moQFP6RLWS2pND2X8gg4VXaI5rWmSvrcajXRARJAGRAA2YgXcENoVs/jrX/F cQjGJ97nRwqKFgQGStB9GGoZNHRUCjDDEMFlohNp+1xfYOtqQDp1k99tgXt9/AJu4RKa PYPA== X-Forwarded-Encrypted: i=1; AJvYcCU6RLnTr7nxlZh4Bo7i3k32l4VC1OLYE/GY/cJSWhu6vbM3hoI5X5KkPZDCd+m+OHtWRjkMJ7xDssoq9lA=@vger.kernel.org X-Gm-Message-State: AOJu0YzCr2nOdPx/jTiWChhNPQFwKfSVIw3Zz6Kfimgl4E42FpwYdKZ2 R8zbDx9ZgbIIrwdcHIJ2JuwSNJ40TRGkRki+qJV6a6GFqBV0BRce8Bs0GlmVG8pUWu4= X-Gm-Gg: ATEYQzw45RPrR1k5UvIXiKCARxgusGbJQUPekRJi7g++kZHnaLq3dSP9vyzbIBuGn6n JCEViItz4kk7JZl6H7YEvfiMgZ/vTe+V13cTYMm7QuTuynvVu8c4LHt2/sQ31FwzUXCfEI2nF6t gvFRCT0ewCVWgVE5X9tlVV67oG2YVk4OZLGCTl2Nz1gAvMXRjiZDQNNqW7l00tMVQ4iJZfUzH57 VW+4d2gamnkmmHlgEBtLXccDnKKSPtAnqM8xfEJcuD7jtQQvazny7CfF7i5yRMcHdPP+Ryr6Ytb 7w4nOu2qvRo4adXUoOY4gF6pXoVyg2SJpXM9MstxG9WvpHnK1OvwStCY582aHdqmas7o2StjJL3 AedV+3iAd/zzPw426gPWBVX32d+rxLI23ZTtaSmHA/bA7lRFn7PUha8X0UCp9U0f9KnK0jF7krT Bxe8PXIoxV4Vi9wkKo2BG5lART/qfYAg== X-Received: by 2002:a5d:5f89:0:b0:439:8f86:e60f with SMTP id ffacd0b85a97d-4399de27794mr11997866f8f.32.1772285615892; Sat, 28 Feb 2026 05:33:35 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4399c70e8dasm14209355f8f.9.2026.02.28.05.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Feb 2026 05:33:35 -0800 (PST) Message-ID: <8cf89fcc-f45a-474d-b2fe-2f90352c2ab3@tuxon.dev> Date: Sat, 28 Feb 2026 15:33:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 1/5] net: cadence: macb: add EEE LPI statistics counters To: Nicolai Buchwitz , netdev@vger.kernel.org Cc: davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk, nicolas.ferre@microchip.com, linux-kernel@vger.kernel.org, theo.lebrun@bootlin.com, phil@raspberrypi.com References: <20260227150610.242215-1-nb@tipi-net.de> <20260227150610.242215-2-nb@tipi-net.de> Content-Language: en-US From: Claudiu Beznea In-Reply-To: <20260227150610.242215-2-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/27/26 17:06, Nicolai Buchwitz wrote: > The GEM MAC provides four read-only, clear-on-read LPI statistics > registers at offsets 0x270-0x27c: > > GEM_RXLPI (0x270): RX LPI transition count (16-bit) > GEM_RXLPITIME (0x274): cumulative RX LPI time (24-bit) > GEM_TXLPI (0x278): TX LPI transition count (16-bit) > GEM_TXLPITIME (0x27c): cumulative TX LPI time (24-bit) > > Add register offset definitions, extend struct gem_stats with > corresponding u64 software accumulators, and register the four > counters in gem_statistics[] so they appear in ethtool -S output. > Because the hardware counters clear on read, the existing > macb_update_stats() path accumulates them into the u64 fields on > every stats poll, preventing loss between userspace reads. > > These registers are present on SAMA5D2, SAME70, PIC32CZ, and RP1 > variants of the Cadence GEM IP and have been confirmed on RP1 via > devmem reads. > > Reviewed-by: Théo Lebrun > Signed-off-by: Nicolai Buchwitz Reviewed-by: Claudiu Beznea