From: Alexander Popov <alex.popov@linux.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Christoph Hellwig <hch@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Marc Zyngier <marc.zyngier@arm.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Dmitry Vyukov <dvyukov@google.com>,
Jiang Liu <jiang.liu@linux.intel.com>,
Jason Cooper <jason@lakedaemon.net>,
Radim Krcmar <rkrcmar@redhat.com>, Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH 1/1] x86/apic: Introduce paravirq irq_domain
Date: Mon, 15 Aug 2016 14:51:38 +0300 [thread overview]
Message-ID: <8cfa4c43-85d1-462b-176d-c14bf2a0afb5@linux.com> (raw)
In-Reply-To: <a64678c3-3993-8fe0-42dc-328d38ad05e9@redhat.com>
On 13.08.2016 09:20, Paolo Bonzini wrote:
> On 13/08/2016 00:07, Alexander Popov wrote:
>> I.e. our irq_mask()/irq_unmask() callbacks get irq_desc of the interrupt
>> which should be masked/unmasked and can ask the hypervisor to stop/start
>> injecting the vector of that particular interrupt.
>
> So just let the irqdomain know about your hypervisor and avoid the
> pointless indirection through function pointers, and only call
> arch_init_paravirq_domain in a file specific to your hypervisor.
Paolo, I would like paravirq irq_domain to be useful for many hypervisors,
not only for one developed by Positive Technologies.
It seems to me that the idea of an irq_domain for interrupts injected
by a hypervisor is quite generic.
I don't like such a way of initializing paravirq_chip very much too.
But to my mind, putting some custom hypervisor API to the generic code
in Linux kernel mainline is less attractive. Can we find another solution?
Thank you.
Best regards,
Alexander
next prev parent reply other threads:[~2016-08-15 11:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 14:02 Alexander Popov
2016-08-11 16:44 ` Paolo Bonzini
2016-08-12 10:56 ` Alexander Popov
2016-08-12 11:43 ` Paolo Bonzini
2016-08-12 22:07 ` Alexander Popov
2016-08-13 6:20 ` Paolo Bonzini
2016-08-15 11:51 ` Alexander Popov [this message]
2016-08-15 12:37 ` Paolo Bonzini
2016-08-16 20:00 ` Alexander Popov
2016-08-17 14:36 ` Jan Kiszka
2016-08-17 22:58 ` Alexander Popov
2016-08-19 10:47 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cfa4c43-85d1-462b-176d-c14bf2a0afb5@linux.com \
--to=alex.popov@linux.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=joro@8bytes.org \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome