From: Manu Gautam <mgautam@codeaurora.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Felipe Balbi <balbi@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
"open list:GENERIC PHY FRAMEWORK" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 14/16] phy: Add USB speed related PHY modes
Date: Mon, 8 Jan 2018 10:16:01 +0530 [thread overview]
Message-ID: <8cff4f9d-4ff3-f7a5-cbb2-677c34c1a637@codeaurora.org> (raw)
In-Reply-To: <15b9b9e7-ae4f-2b40-4bf5-265534d4605e@ti.com>
Hi,
On 1/5/2018 4:31 PM, Kishon Vijay Abraham I wrote:
>> +enum phy_mode phy_get_mode(struct phy *phy)
>> +{
>> + enum phy_mode ret;
>> +
>> + if (!phy || !phy->ops->get_mode)
>> + return PHY_MODE_INVALID;
>> +
>> + mutex_lock(&phy->mutex);
>> + ret = phy->ops->get_mode(phy);
> Since get_mode only has to return the phy mode, there is no need for an ops
> here. Just add phy_mode in phy_attrs in set_mode and return it here.
Sure, will re-send patch set with this change.
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-01-08 4:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1514978930-31341-1-git-send-email-mgautam@codeaurora.org>
2018-01-03 11:28 ` [PATCH v4 01/16] phy: qcom-qmp: Fix phy pipe clock gating Manu Gautam
2018-01-03 11:28 ` [PATCH v4 02/16] phy: qcom-qmp: Adapt to clk_bulk_* APIs Manu Gautam
2018-01-03 11:28 ` [PATCH v4 03/16] phy: qcom-qmp: Power-on PHY before initialization Manu Gautam
2018-01-12 8:27 ` Vivek Gautam
2018-01-03 11:28 ` [PATCH v4 04/16] phy: qcom-qusb2: " Manu Gautam
2018-01-12 8:29 ` Vivek Gautam
2018-01-03 11:28 ` [PATCH v4 05/16] phy: qcom-qmp: Fix PHY block reset sequence Manu Gautam
2018-01-12 8:44 ` Vivek Gautam
2018-01-12 8:46 ` Manu Gautam
2018-01-12 9:12 ` Vivek Gautam
2018-01-03 11:28 ` [PATCH v4 06/16] phy: qcom-qmp: Move SERDES/PCS START after PHY reset Manu Gautam
2018-01-03 11:28 ` [PATCH v4 07/16] phy: qcom-qusb2: Add support for different register layouts Manu Gautam
2018-01-12 9:18 ` Vivek Gautam
2018-01-03 11:28 ` [PATCH v4 08/16] dt-bindings: phy-qcom-qusb2: Update binding for QUSB2 V2 version Manu Gautam
2018-01-03 11:28 ` [PATCH v4 09/16] phy: qcom-qusb2: Add support " Manu Gautam
2018-01-12 9:29 ` Vivek Gautam
2018-01-03 11:28 ` [PATCH v4 10/16] phy: qcom-qmp: Move register offsets to header file Manu Gautam
2018-01-12 6:26 ` Vivek Gautam
2018-01-03 11:28 ` [PATCH v4 11/16] phy: qcom-qmp: Add register offsets for QMP V3 PHY Manu Gautam
2018-01-03 11:28 ` [PATCH v4 12/16] dt-bindings: phy-qcom-qmp: Update bindings for QMP V3 USB PHY Manu Gautam
2018-01-03 11:28 ` [PATCH v4 13/16] phy: qcom-qmp: Add support for QMP V3 USB3 PHY Manu Gautam
2018-01-03 11:28 ` [PATCH v4 14/16] phy: Add USB speed related PHY modes Manu Gautam
2018-01-05 11:01 ` Kishon Vijay Abraham I
2018-01-08 4:46 ` Manu Gautam [this message]
2018-01-03 11:28 ` [PATCH v4 15/16] phy: qcom-qusb2: Add support for runtime PM Manu Gautam
2018-01-03 11:28 ` [PATCH v4 16/16] phy: qcom-qmp: " Manu Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cff4f9d-4ff3-f7a5-cbb2-677c34c1a637@codeaurora.org \
--to=mgautam@codeaurora.org \
--cc=balbi@kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®