From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3904CC2BA19 for ; Sat, 11 Apr 2020 19:43:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09CF520787 for ; Sat, 11 Apr 2020 19:43:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726779AbgDKTne (ORCPT ); Sat, 11 Apr 2020 15:43:34 -0400 Received: from smtprelay0010.hostedemail.com ([216.40.44.10]:41654 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726204AbgDKTnd (ORCPT ); Sat, 11 Apr 2020 15:43:33 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 70B222C9D; Sat, 11 Apr 2020 19:43:33 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: owl05_1ed6d11cbc207 X-Filterd-Recvd-Size: 1962 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Sat, 11 Apr 2020 19:43:31 +0000 (UTC) Message-ID: <8d097283a4676f7e1050c9d6664d89d710e21bcf.camel@perches.com> Subject: Re: [PATCH] taging: android: ashmem: Declared const key From: Joe Perches To: MugilRaj Cc: mugil2301 <110117057@nitt.edu>, Greg Kroah-Hartman , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Sat, 11 Apr 2020 12:41:26 -0700 In-Reply-To: <1586633396-24237-1-git-send-email-dmugil2000@gmail.com> References: <1586633396-24237-1-git-send-email-dmugil2000@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-04-12 at 00:59 +0530, MugilRaj wrote: > From: mugil2301 <110117057@nitt.edu> You need to verify the patch subject. You need a change log message too. > Signed-off-by: mugil2301 <110117057@nitt.edu> You need to put your legal name here > diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c [] > @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, > > static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) > { > - static struct file_operations vmfile_fops; > + static const struct file_operations vmfile_fops; > struct ashmem_area *asma = file->private_data; > int ret = 0; (this won't compile) checkpatch is not always right. Do please compile the files changed by your patch and verify change correctness before sending any proposed patch.