From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04EB6198A17 for ; Mon, 21 Oct 2024 20:18:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729541909; cv=none; b=stccZKqUXIzxuDkWI5Q5hMF6uqTxqvrxCbVwRTv2TVbh5bM36/2852/PIPtcer8HuPrJGG7yF1/OP2E2X+Znk6LI2bBkT3RHORZjv4n4f9tgasCu49Q4LfWfvjLEnyx+Vwz/xWZQObkZmwCLW3l0iKqJAccZpKaM2jZ+5X8oxxI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729541909; c=relaxed/simple; bh=g+qM+EmG1EuR7qOAZIG5ufF8O5B9aOyec717x9J0tIo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sfbzl+QmZG6U+bnSaUBzsVGLF+gn3k7TnTGiXle0ZKitlwpYC0naW5gRKfzb/m8WNUEumi1NwxmrbVzOx+6Hnm9hakNmjHm6wP8hKswSirzmsBivnkCyx7pgMBxtAURdhbnd8NCEQwGGO48kLln2mAQyDzviHb7GvOvyRfmlMI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz; spf=pass smtp.mailfrom=suse.cz; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=eGMgwgZv; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=ivIXHVmq; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b=eGMgwgZv; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b=ivIXHVmq; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.cz Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="eGMgwgZv"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="ivIXHVmq"; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.b="eGMgwgZv"; dkim=permerror (0-bit key) header.d=suse.cz header.i=@suse.cz header.b="ivIXHVmq" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3357221CC7; Mon, 21 Oct 2024 20:18:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729541906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5uWR0mU37fye3/9R4OxuoaHgo58uTw9nPUFbFTEfXTM=; b=eGMgwgZvfBf9rijCPjSZMIyhCCR+UQaGk15VTd+8e3WJ0Sl7DwKJwUqmGjLrIzV1xgettB tVJsFPh6QkpHGV+TiHm7EmTJQA4+B730Nb0EWvyJTpx2mV3BdrU7A/yEHcmv58cvGIZZlQ 5bWI3EWRwgtTtMArW7aOe2gQiD1lbuY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729541906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5uWR0mU37fye3/9R4OxuoaHgo58uTw9nPUFbFTEfXTM=; b=ivIXHVmqxhHhCLF3CxA628XZqfXh4/lAu6f1/YZ354In267Z4ZY6lBWUPjj2ngjw2FXfyN 4O1gZhzMfqMJJSCg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1729541906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5uWR0mU37fye3/9R4OxuoaHgo58uTw9nPUFbFTEfXTM=; b=eGMgwgZvfBf9rijCPjSZMIyhCCR+UQaGk15VTd+8e3WJ0Sl7DwKJwUqmGjLrIzV1xgettB tVJsFPh6QkpHGV+TiHm7EmTJQA4+B730Nb0EWvyJTpx2mV3BdrU7A/yEHcmv58cvGIZZlQ 5bWI3EWRwgtTtMArW7aOe2gQiD1lbuY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1729541906; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5uWR0mU37fye3/9R4OxuoaHgo58uTw9nPUFbFTEfXTM=; b=ivIXHVmqxhHhCLF3CxA628XZqfXh4/lAu6f1/YZ354In267Z4ZY6lBWUPjj2ngjw2FXfyN 4O1gZhzMfqMJJSCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 19561139E0; Mon, 21 Oct 2024 20:18:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ORnTBRK3FmeNPwAAD6G6ig (envelope-from ); Mon, 21 Oct 2024 20:18:26 +0000 Message-ID: <8d09dcdc-b8bc-4d25-9afb-5eec8fb11a27@suse.cz> Date: Mon, 21 Oct 2024 22:18:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] 9p: Avoid creating multiple slab caches with the same name Content-Language: en-US To: Omar Sandoval Cc: Dominique Martinet , Thorsten Leemhuis , Linus Torvalds , Eric Van Hensbergen , Christian Schoenebeck , v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, regressions@lists.linux.dev, Jason Gunthorpe , Pedro Falcato References: <20240807094725.2193423-1-pedro.falcato@gmail.com> <20241018172804.GA2151929@nvidia.com> <1cb07628-269c-4d6c-9936-f3a2b233165f@leemhuis.info> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Level: X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_SEVEN(0.00)[11]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; TAGGED_RCPT(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[codewreck.org,leemhuis.info,linux-foundation.org,kernel.org,crudebyte.com,lists.linux.dev,vger.kernel.org,nvidia.com,gmail.com]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-Spam-Score: -2.80 X-Spam-Flag: NO On 10/21/24 20:37, Omar Sandoval wrote: > On Mon, Oct 21, 2024 at 10:42:02AM +0200, Vlastimil Babka wrote: > > FYI, drgn's CI started getting EIO errors from > getdents("/sys/kernel/slab") that I bisected to this patch. The problem > is that dev_name can be an arbitrary string. In my case, it is > "/dev/root". This trips verify_dirent_name(), which fails if a filename > contains a slash. > > This needs to use a different unique identifier. Maybe clnt->msize? But > then the kmem_caches will need to be shared between different mounts > using the same msize. Yep, Dominique mentioned that here too: https://lore.kernel.org/all/ZvBIl8b9RRK9jgtJ@codewreck.org/ And yes, slab has internal merging of compatible caches enabled by default. But since it can be disabled, that would indeed result in duplicate names again if 9p mounts didn't track and reuse caches with same msize accross mounts on its own. Linus's suggestion seems like the easiest fix for now. > In any case, can this be reverted for now? > > Thanks, > Omar