From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30ECF40242D for ; Fri, 31 Jul 2026 11:41:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785498090; cv=none; b=kKWE/ec5iluKNf/tbZuVVb74umtdWohUNzia2gg7EdiWLnb8LSoqxAlruQ0rk42WbG0i4HjD3R/JxMByr2n90XtUYmsC8DtKO1tV5Z6xm5KtbkjtRBneBLOg3aOHuk4L8OTuBYDLQ77T7wOgAXDLYM3O/PfnLpg2pHqHI/hjcKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785498090; c=relaxed/simple; bh=t/AEkos+c9EqibZwHZd/yyWTAgGTemJDxjqXLp+xsmE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PCqj5FoC0Nc8ybupYSpM5ixZENrMty3L81JgWaVl/vEu65xampmM3cMexSxO3ZiTF9XnADSYnAM9ZKyaI3oC5+vbMrx7O6av8DZEaRLQhDXLNFwJcA1li1+qmQfQCq5cnA2TxusMlzHti6AKJectyOYxHy/cPRW1BaLNdWNzM7M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Al84V0sM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JpWYcnEF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Al84V0sM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JpWYcnEF" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66VBf3pm892764 for ; Fri, 31 Jul 2026 11:41:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Su0oDlMbfDedbPdZAAnG9t8RidvVr7z4UsL5r+t2C4A=; b=Al84V0sMZ4qO9Xcz kqiAIhFYS6nv7gG3KvhImTx3pF3oHTdPA1hKlUJ1xrUxDfpknYpqnxJIYyVFP5V8 u19DoBaSFw7EfnxVF/KjqqmLL932ios+D4DUjUoIf8sLFsHJQnOgGb7JpxsvPhQH 5J2fy7xaOq3Es7UyUMa7CghqH4RXHtdHZln9JihyqiBjPqYTOqyiB0IZNCZ+cIIV cYwWgLMk3sz6SfndWZUowlopuralexPxByzvKQ/0SmNM0b/KxJp0acQSV9QR8/qI mrTKatOtTWKRTPi7/oXyn12m0akwmmoms1ABtO5OSXEvutCpqssx92cGAqCVhaVB 0JSZ+w== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fru1x8032-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 11:41:26 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51ca37ce4c3so1698781cf.3 for ; Fri, 31 Jul 2026 04:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785498085; x=1786102885; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Su0oDlMbfDedbPdZAAnG9t8RidvVr7z4UsL5r+t2C4A=; b=JpWYcnEFzyGB2FSz8T7orV3+WkVRMyfE1YFbVVSg21bMGyWGTky29qD4jJfK2yIsIu /Ntdqzt/F+fHlR8vrYiYGK28ODag7a93dzXQ7kvflCqu73OGtzMPilUoEDpsNURzPs6k fnK5BRCuf5WbEIL8nk4p8eCdAWw5R5PP01GnTDVsiFH1Cxv4tTZmQxSp+b0MLDtEqszY z8qsLKVQ4YTiYXnDzI7JhFCWvHrhgZZQsEWPnhJJB8sG/Mj8gfcQ2s5cglcQGSg8SIHS xpqCGMo11lEMKP15zQEvIT1uIyRqZ87LIOnHCLdNKT0E2FhVIa2qjmzIzmGCgMh0CFgX 42/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785498085; x=1786102885; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Su0oDlMbfDedbPdZAAnG9t8RidvVr7z4UsL5r+t2C4A=; b=SgyCvIKX3jNpi2Q13aHUtwGUriH5yVYgUK6ITTsCXhGxx2O6qHIf+XbYBP0E1Xdplr UYIu55jjR8PhS9UMXMNfL0yRu6xzWTNgx+M0Tm37s3hIZ/lHjtnUeT4jbOr0cPRWnK7m Wa1k/8n7hIEBNnL8wlAnU92eenzkcLEoTxbaHhX+JkCTQgJ88Lffvyb/NEcUicaAdXkR Ted/c6fsHULYOt6w4I6aZhLbBbaPrkcKXeOp4mM5WmGuPnfk3DLfO+kUf8pPY4EgGWjJ erilN3SJtAWb7s0V6VVz/iY2HcNd4VeAg6v7+2fDN72ch5ojvwOZ4YZNz0GAyMGyxUlf lWvw== X-Forwarded-Encrypted: i=1; AHgh+RqYQHEFlG6DxTPnXSatfOnFOy/TIGM6XWLLLl4aNqW6eG9zMB6oZpoOY6gyfI0xqY6S8o02e4zufxUFkgs=@vger.kernel.org X-Gm-Message-State: AOJu0YxTk4kw0DvZu2fByyf8Q0SPOy2rOjKGtauRcBm6I0tSTHVoRdYr 2EQSd1RmbnHvMs27rre2YXXiuR5BMqM9mI5WILbSuhbuWTJEYJncK+GWZnfQemrqZIQZwqvUB84 pZgzlmE5ob2J9P1uwlTcvQfqxwmx6+rAaWrWkjOqZxKvpnuEzcVbCrMpA/u1tFipy7RM= X-Gm-Gg: AR+sD11zXFW6xjjWhe9QGmRS0btFiaK74EAgBRK501VAfXejEdWYsSibP3sQotArFT2 4qI2CLoHux7O8fuehOgitCkTVCn+Hg52dMAet8BAjJEHn4L3jNLzfNoM2eGmaIrGquh0Pyv8o0E g0FDFy4bpTqdoZOUbLPRh0zTSmckk++1pG5xosHxwCPKhSKQQR1MtX6nO2BHQqLGJ26n4N6fs5F gtfgN8Rdzg54gdJ9AJxfOiJRWbQkaSany8kiqsf/v0fKjlFLuvwA3ndIeuv51JrAGRGnWWPgqtn KMf940WkUOv/okvtZP+CKjac2t75DniAVNIExZke6iGS5W1KWV7+Tn5GTrnPGHKQ0Zi+boZjlJl nbizOwA+Ee4qbc2cM0y3HK3Ej X-Received: by 2002:ac8:7d83:0:b0:51c:d8f:d77a with SMTP id d75a77b69052e-52b4aebcae7mr19725331cf.1.1785498085493; Fri, 31 Jul 2026 04:41:25 -0700 (PDT) X-Received: by 2002:ac8:7d83:0:b0:51c:d8f:d77a with SMTP id d75a77b69052e-52b4aebcae7mr19724941cf.1.1785498085053; Fri, 31 Jul 2026 04:41:25 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd4453823sm129487066b.40.2026.07.31.04.41.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 04:41:24 -0700 (PDT) Message-ID: <8d0c418d-849f-440a-aa56-110e8b7dfc07@oss.qualcomm.com> Date: Fri, 31 Jul 2026 13:41:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] media: iris: reject open() when the session limit is reached To: Dmitry Baryshkov , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Vedang Nagar Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260731-iris-fixes-v2-0-94c002016a09@oss.qualcomm.com> <20260731-iris-fixes-v2-4-94c002016a09@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260731-iris-fixes-v2-4-94c002016a09@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDA4OCBTYWx0ZWRfX/W0eB5QfbdB9 ghlmbi6Ohgro/4WK9EYVzxo3TkGajd+f+bKecH71XecC9hu7AdodAGtHoFwyFB2JucMzirfiRmM jF0aIGYshyx88l/rLqCGcKp988U4ZGY= X-Authority-Analysis: v=2.4 cv=GpByPE1C c=1 sm=1 tr=0 ts=6a6c89e6 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=_us7XynFyZs99I6bamQA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDA4OCBTYWx0ZWRfXymZDsciio2YN hntZYsdYUAZa3OJp3Knw7SVJOYo3AbwI9nxDcIwTq467eeFTVpJRnG+byrHnYUIfB/qwtoqXy40 g4mRFD+Gl8ofFCFKldJ/GoUxJFyDYQ8yoE2p+BLgXP+g9bwqXLEgUCnqj5kyvvkZrZr8xHICZF/ J40vLnkYoTeTAZdY7pFd41pVsCwpdyUFas/TyOis5PXzKu9TlSyxHGTJVtxrToMlewUUicpeagM ZJI91Rm8ZFzStS2CFgHaeh9+AgMYZVzBWaPgTXh037W72DkMFwPszvelD2ZqRBdfH/Q1YZDQHkN 8cBfHsmZ+spJsctTASq71N43HPUa0Esn2EUss6qPBmXCIy3qx8YedjdnT3jDjeh4X0x/dv9olQp qlZlIef5ICXkRYpQF4zZWtkTREJiGgzFFOGTMftX8jBU87Ip96X9j4A27okN0MLwT/QnR/qDZt2 G0SMZX5bSJLdnNaOeew== X-Proofpoint-ORIG-GUID: CEhL5GhZ4QvLksXF_e0SvPYG-ZNGVieW X-Proofpoint-GUID: CEhL5GhZ4QvLksXF_e0SvPYG-ZNGVieW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_04,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 impostorscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 adultscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310088 On 7/31/26 2:31 AM, Dmitry Baryshkov wrote: > iris_add_session() silently skips adding the instance to core->instances > once max_session_count is reached, but returns void, so iris_open() > continues as if it succeeded and hands a file descriptor back to > userspace. As the instance is not on core->instances, firmware responses > for it are dropped and every subsequent ioctl times out. > > Make iris_add_session() return an error when the limit is reached and > fail iris_open() accordingly, freeing the partially initialised instance. > > Fixes: 38fc8beaba55 ("media: iris: implement reqbuf ioctl with vb2_queue_setup") > Assisted-by: Claude:claude-opus-4-8 > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad