mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Stephen Boyd <sboyd@kernel.org>,
	Fabio Estevam <festevam@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: imx: clk-pllv3: mark expected switch fall-throughs
Date: Tue, 30 Apr 2019 12:28:32 -0500	[thread overview]
Message-ID: <8d0d12ae-ce67-5480-49be-893fbdbb6998@embeddedor.com> (raw)
In-Reply-To: <155664492283.168659.5604495418413396919@swboyd.mtv.corp.google.com>



On 4/30/19 12:22 PM, Stephen Boyd wrote:
> Quoting Gustavo A. R. Silva (2019-04-30 07:32:06)
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> drivers/clk/imx/clk-pllv3.c: In function ‘imx_clk_pllv3’:
>> drivers/clk/imx/clk-pllv3.c:446:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    pll->div_shift = 1;
>>    ~~~~~~~~~~~~~~~^~~
>> drivers/clk/imx/clk-pllv3.c:447:2: note: here
>>   case IMX_PLLV3_USB:
>>   ^~~~
>> drivers/clk/imx/clk-pllv3.c:453:21: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>    pll->denom_offset = PLL_IMX7_DENOM_OFFSET;
>>                      ^
>> drivers/clk/imx/clk-pllv3.c:454:2: note: here
>>   case IMX_PLLV3_AV:
>>   ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> It was sent by Anson already.
> 

Did he address both warnings?

Thanks
--
Gustavo

  reply	other threads:[~2019-04-30 17:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 14:32 Gustavo A. R. Silva
2019-04-30 17:22 ` Stephen Boyd
2019-04-30 17:28   ` Gustavo A. R. Silva [this message]
2019-04-30 18:17     ` Stephen Boyd
2019-05-03 12:58 ` Anson Huang
2019-05-03 16:03 ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d0d12ae-ce67-5480-49be-893fbdbb6998@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome