From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B8E321CC6C for ; Wed, 14 May 2025 09:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747213889; cv=none; b=YKL0TRxyGgRco+zoHCnmZOQbvna/3VDEDVAOx4p+3lUZ07ftLQ8trETYwDwXr1te/FOyDIvWspzQ1cTH0sEHXAyvjyDnm3SS3dbcHP6Am7eOsOM3Ix+6n+WLLz8o4hwBtoQyA4qWXtCEuFfzGJF0sXyhGcvBQMjVoe8zb0Quw/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747213889; c=relaxed/simple; bh=HvyjCbzUd5/Mp1b55Kqz/7qNG+fmJl75hwbZe6oyT5c=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=dPsLVhFMVYPLfTgPB5TiSvfVLZEhPsyl04XO1RCCOL3YhLNlKPfNIrr+iH0LjCBbsF5ijELl3JAI2uKHjuomYsp0bGf1r+r9Z24EJxr1UvvuGJ8GLhCQvQ59OYEgmvv5qm+1UgVzFm338ztLGES76g2or/y097rh1vi0rTvfP6c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZPUJYg+R; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZPUJYg+R" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747213887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mbjkb6JTJAsuy38qD4oeTgqwyUosO6GgDAb+t/G8/WQ=; b=ZPUJYg+RfJi7YUdp+BCS7E6eZ2oMePJ6nNRaA1lqvFPFRWBTo51nLJVV0Zt33YusZh9RLc U57kAKIBMMLXLmy2rNhwQErxSZQo88mgYzuB4ZhpiPa7xfjXqmcfTztOiplyADyml+Pd4t n5HJ4+Ir23qaTZJjhYkz5R036uqo6Uk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-491-0QnoM6JaMn-Q3o4ca29j0Q-1; Wed, 14 May 2025 05:11:25 -0400 X-MC-Unique: 0QnoM6JaMn-Q3o4ca29j0Q-1 X-Mimecast-MFC-AGG-ID: 0QnoM6JaMn-Q3o4ca29j0Q_1747213885 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a0b9bbfa5dso2359816f8f.3 for ; Wed, 14 May 2025 02:11:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747213885; x=1747818685; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mbjkb6JTJAsuy38qD4oeTgqwyUosO6GgDAb+t/G8/WQ=; b=rQtSlSBF9UsiQcuW3uaa8DZxu3FYNas40nhs3+WI6lh1s09Gc1t3zRZcvt1LneyJYd ryTSRBnIFXP99dghMgyq4pNcqVP2F7w0HkWij9Pj+yP3neuvTPSYH+o2mJcRPKNEA01M UNglDm3fqoQBH8zGb43psLeQu17GPnBVaKM6zC3zkCmHehCRiX4gRxkfKwUiU0it2zly 1XkWJHi3jvjSwlJzcxZU3JaED3Uer+p03N+lUIoca37AqSt8h1cfd+sW5edkTf4M7oyf stBzlMk7BfMMhXf8hyJybaQUbFIiY+tQEqNznm5wAi3w/DpRLnYnmr2NjV5zzEUEOH8k Bk3w== X-Forwarded-Encrypted: i=1; AJvYcCVg6izWMOyBVH4p1sU0w2wR/gpEgEXcegaj2YPccTVvYpofo+L+cDdHwTvSAC/qrCZHDToXmf6jij5bDwo=@vger.kernel.org X-Gm-Message-State: AOJu0YwB64m5o2a+8+Kv2c7Kd9W0nblgIHzOOyP8Qk2RD6MaF+23005q d35JUqx1kfoygkxZ0cPybRycApMYI9X3vqO4wWq41fPSzKD4IwUBSzJxwBOZZLLC/sneloNsSP6 V44YQFw2cSVUw9ttwc0EMn9ASxC34zI3r0IJZ3X0hd7HFVqSirvWT7Qzl8I9aoA== X-Gm-Gg: ASbGncvwtudJxVTNDRpKfr5RPOUSnmcPe2ZoVAANlp0zkrSi3tBTWDDUw4Z5FeVK9L0 y2n9uQ5AoDZjb8grFMNdnpDyVLcNJedWK5NJUe4CA5va4S7i+/9V2V4K5AxkGu5xh9uX6fLVUAE rdjRAUnNTqxWRDqhvJL0TKNJPeZMQC9X+NpC9tGjaUf7lVYaWg/MEET+/zYl3hgIDHnEei6yFUK ErvCqbUY0xqPoNb1bTUAMZHr7qp0PMp2You9x5CAnxJbzfL/f/BBvFw1O7MSmdf2G2OYoQtiJTQ EHoZr4nDJnN5kvE2F1wElqhEy7mR/R5ImYLZEb40+Fzn5oYAi1MLmfqJub9Zr1kzK8PDpNyGxx+ 5LdCi13ijNOgzNr+6HpHvCs05GThbzo3ALFERbPA= X-Received: by 2002:a5d:5f91:0:b0:3a0:7017:61f6 with SMTP id ffacd0b85a97d-3a3496a40f6mr2274308f8f.14.1747213884686; Wed, 14 May 2025 02:11:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzKwUpB8LZoEPItaEpiT42Rn95TAirv2fF/YHfvGZfDLHpm/T3BLxuSWtpEUruW+FjHC9Emg== X-Received: by 2002:a5d:5f91:0:b0:3a0:7017:61f6 with SMTP id ffacd0b85a97d-3a3496a40f6mr2274276f8f.14.1747213884315; Wed, 14 May 2025 02:11:24 -0700 (PDT) Received: from ?IPV6:2003:d8:2f15:6200:d485:1bcd:d708:f5df? (p200300d82f156200d4851bcdd708f5df.dip0.t-ipconnect.de. [2003:d8:2f15:6200:d485:1bcd:d708:f5df]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58ec8f1sm18679910f8f.26.2025.05.14.02.11.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 02:11:23 -0700 (PDT) Message-ID: <8d11bb04-2feb-4189-adbd-5f27819d2095@redhat.com> Date: Wed, 14 May 2025 11:11:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: remove WARN_ON_ONCE() in file_has_valid_mmap_hooks() From: David Hildenbrand To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox References: <20250514084024.29148-1-lorenzo.stoakes@oracle.com> <357de3b3-6f70-49c4-87d4-f6e38e7bec11@redhat.com> Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14.05.25 11:10, David Hildenbrand wrote: > On 14.05.25 10:56, Lorenzo Stoakes wrote: >> On Wed, May 14, 2025 at 10:49:57AM +0200, David Hildenbrand wrote: >>> On 14.05.25 10:40, Lorenzo Stoakes wrote: >>>> Having encountered a trinity report in linux-next (Linked in the 'Closes' >>>> tag) it appears that there are legitimate situations where a file-backed >>>> mapping can be acquired but no file->f_op->mmap or file->f_op->mmap_prepare >>>> is set, at which point do_mmap() should simply error out with -ENODEV. >>>> >>>> Since previously we did not warn in this scenario and it appears we rely >>>> upon this, restore this situation, while retaining a WARN_ON_ONCE() for the >>>> case where both are set, which is absolutely incorrect and must be >>>> addressed and thus always requires a warning. >>>> >>>> If further work is required to chase down precisely what is causing this, >>>> then we can later restore this, but it makes no sense to hold up this >>>> series to do so, as this is existing and apparently expected behaviour. >>>> >>>> Reported-by: kernel test robot >>>> Closes: https://lore.kernel.org/oe-lkp/202505141434.96ce5e5d-lkp@intel.com >>>> Signed-off-by: Lorenzo Stoakes >>>> --- >>>> >>>> Andrew - >>>> >>>> Since this series is in mm-stable we should take this fix there asap (and >>>> certainly get it to -next to fix any further error reports). I didn't know >>>> whether it was best for it to be a fix-patch or not, so have sent >>>> separately so you can best determine what to do with it :) >>> >>> A couple more days in mm-unstable probably wouldn't have hurt here, >>> especially given that I recall reviewing + seeing review yesterday? >>> >> >> We're coming close to end of cycle, and the review commentary is essentially >> style stuff or follow up stuff, and also the series has a ton of tags now, so I >> - respectfully (you know I love you man :>) - disagree with this assessment :) >> >> This situation that arose here is just extremely weird, there's really no reason >> anybody should rely on this scenario (yes we should probably try and chase this >> down actually, perhaps though a driver somehow sets f_op->mmap to NULL somewhere >> in some situation?) >> >> So I think this (easily fixed) situation doesn't argue _too_ much against that >> :) > > Again, I am talking about a couple more days, not weeks or months ;) > > At least looking at the report it sounds like something the test bots > would usually find given a bit more time on -next. I might be wrong. > > next-20250500 had the old version without WARN ^ for completeness, next-20250509 -- Cheers, David / dhildenb