From: Paolo Abeni <pabeni@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev
Subject: Re: [PATCH net-next 2/2] vsock/test: check also expected errno on sigpipe test
Date: Tue, 13 May 2025 12:41:17 +0200 [thread overview]
Message-ID: <8d1206d1-1b62-48a4-a304-23e13c1316a3@redhat.com> (raw)
In-Reply-To: <20250508142005.135857-3-sgarzare@redhat.com>
On 5/8/25 4:20 PM, Stefano Garzarella wrote:
> diff --git a/tools/testing/vsock/vsock_test.c b/tools/testing/vsock/vsock_test.c
> index 7de870dee1cf..533d9463a297 100644
> --- a/tools/testing/vsock/vsock_test.c
> +++ b/tools/testing/vsock/vsock_test.c
> @@ -1074,9 +1074,13 @@ static void test_stream_check_sigpipe(int fd)
> do {
> res = send(fd, "A", 1, 0);
> timeout_check("send");
> - } while (res != -1);
> + } while (res != -1 && errno == EINTR);
I'm low on coffee, but should the above condition be:
res != -1 || errno == EINTR
instead?
Same thing below.
/P
next prev parent reply other threads:[~2025-05-13 10:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 14:20 [PATCH net-next 0/2] vsock/test: improve sigpipe test reliability Stefano Garzarella
2025-05-08 14:20 ` [PATCH net-next 1/2] vsock/test: retry send() to avoid occasional failure in sigpipe test Stefano Garzarella
2025-05-13 10:37 ` Paolo Abeni
2025-05-13 13:46 ` Stefano Garzarella
2025-05-08 14:20 ` [PATCH net-next 2/2] vsock/test: check also expected errno on " Stefano Garzarella
2025-05-13 10:41 ` Paolo Abeni [this message]
2025-05-13 13:49 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d1206d1-1b62-48a4-a304-23e13c1316a3@redhat.com \
--to=pabeni@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®