From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A9CC4332B for ; Thu, 4 Mar 2021 16:55:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14A7864F5C for ; Thu, 4 Mar 2021 16:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238695AbhCDQyP (ORCPT ); Thu, 4 Mar 2021 11:54:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238654AbhCDQyK (ORCPT ); Thu, 4 Mar 2021 11:54:10 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C44D5C061761 for ; Thu, 4 Mar 2021 08:53:29 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id u16so10402634wrt.1 for ; Thu, 04 Mar 2021 08:53:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YnxlDtU5po5D1M53NldIE72sMInCUbrZRLnykBeu2V8=; b=Ewxi+OReE6dJAiv1zXYkq05geSl/fq+jZkRgzrMwoyzv7/mX7eQzNkoXLfZA/H4WjA dLxCRUQXjLaUaurQNnE2V1uuSVtL1ssUBtAdfk47+VjVE3TodqBAoyI+HNZr9jaugwih QozPefxrDjjzljWSRoqtM5xVlGU9Pye4vHHgjW0WwQ5jmtTxzIbIessoty315fsV3Pto 3rUuogs9lyEX7c3FT883rgCuhQlAV95l3Ki/0K1GkqZhT2pUmINFxC/lBZLVmiOR6r0I /mSml0hG8PHwm/dAmJQhv/t8QNpecklP1K6I1reeFu194Rh1icR2BB1MMK/v7koexmb3 k6ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YnxlDtU5po5D1M53NldIE72sMInCUbrZRLnykBeu2V8=; b=J4j5Vj74nRYuuaHfEkppMyg17ZqS8nHrZNne8vluyanurWUv+jVqIeG2QVW+5bTtf4 EWc1+tmwhmDFaZw+t1K2bOC1k4H8rM8P/VYIep29B47V51wTNuxgjASU+Yeh8zGKuuyi 1dwSPIN6elQEGVNlRUvEOq8n9L9CyDBOwpxWRF8gyjD7Qxxz2WjTpS+CRHb9nG5pPCyn i9ug4ek8ROQTTzYxTjxlzgmHZrrxSpN82oB63BSfJKHUE4UldSdO0YKuj3kzehMRFkRi 77YwWpKw6C7NrEuG2YBizTxaPgOtveMJpRJ6gDrLljbAX6rK5b/+13kD9HlIZX2yfcnV wGqQ== X-Gm-Message-State: AOAM530ePWSQ9T33Nl4or+i32fT6AC6W8Cn357LC5/mkjz/yb3c/OprT P6ds+aa7qb2GJeP2jPVE7gG6Ng== X-Google-Smtp-Source: ABdhPJxucLioKZo95wCuntF7BE0hNv7s/6tGhLvI6FsbewLBgkboHJnD6mezrJaZmVK15Kbq98zepg== X-Received: by 2002:adf:d1c2:: with SMTP id b2mr4922891wrd.424.1614876808222; Thu, 04 Mar 2021 08:53:28 -0800 (PST) Received: from [192.168.0.41] (lns-bzn-59-82-252-144-192.adsl.proxad.net. [82.252.144.192]) by smtp.googlemail.com with ESMTPSA id b15sm36807595wrr.47.2021.03.04.08.53.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Mar 2021 08:53:27 -0800 (PST) Subject: Re: [PATCH] devfreq: Register devfreq as a cooling device To: Lukasz Luba Cc: cwchoi00@gmail.com, kyungmin.park@samsung.com, myungjoo.ham@samsung.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Chanwoo Choi , Qiang Yu , David Airlie , Daniel Vetter , Rob Clark , Sean Paul , Rob Herring , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , "open list:DRM DRIVERS FOR LIMA" , "moderated list:DRM DRIVERS FOR LIMA" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" References: <20210304125034.28404-1-daniel.lezcano@linaro.org> <5f06e0c5-b2d9-5e11-01b6-fdd0dac635a7@arm.com> From: Daniel Lezcano Message-ID: <8d153937-c5fc-1de2-d510-d3f91f7a9724@linaro.org> Date: Thu, 4 Mar 2021 17:53:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <5f06e0c5-b2d9-5e11-01b6-fdd0dac635a7@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lukasz, thanks for commenting this patch, On 04/03/2021 14:47, Lukasz Luba wrote: > Hi Daniel, > > On 3/4/21 12:50 PM, Daniel Lezcano wrote: >> Currently the default behavior is to manually having the devfreq >> backend to register themselves as a devfreq cooling device. >> >> There are no so many and actually it makes more sense to register the >> devfreq device when adding it. >> >> Consequently, every devfreq becomes a cooling device like cpufreq is. >> >> Having a devfreq being registered as a cooling device can not mitigate >> a thermal zone if it is not bound to this one. Thus, the current >> configurations are not impacted by this change. > > There are also different type of devices, which register into devfreq > framework like NoC buses, UFS/eMMC, jpeg and video accelerators, ISP, > etc. > In some platforms there are plenty of those devices and they all would > occupy memory due to private freq_table in devfreq_cooling, function: > devfreq_cooling_gen_tables(). > > IIRC in OdroidXU4 there are ~20 devfreq devs for NoC buses. I'm curious, do you have a pointer to such kernels having all those devfreq ? > It's true that they will not affect thermal zones, but unnecessarily, > they all will show up in the /sys/class/thermal/ as > thermal-devfreq-X > > > IMO the devfreq shouldn't be tight with devfreq cooling thermal. The energy model is tied with a cooling device initialization. So if we want to do power limitation, the energy model must be initialized with the device, thus the cooling device also. That is the reason why I'm ending up with this change. Chanwoo suggestion makes sense and that will allow to move the initialization to devfreq which is more sane but it does not solve the initial problem with the energy model. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog