From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC99FC678D5 for ; Wed, 8 Mar 2023 11:30:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230064AbjCHLad (ORCPT ); Wed, 8 Mar 2023 06:30:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbjCHLa2 (ORCPT ); Wed, 8 Mar 2023 06:30:28 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F35A39477C for ; Wed, 8 Mar 2023 03:30:26 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id ay14so60696703edb.11 for ; Wed, 08 Mar 2023 03:30:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678275025; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8KH8jGCskjaNO6GyEN+UrKrvr+UwiHKuZCM0jBvEJmU=; b=Hn8D2tuSDeLvUpJemAU3Y2rDaUEXrNGwojqaIuc0E3mH++EWRYxQAUMFjiSGWo8LoP HvWZcWovZEYEo23tpdd2n6XNyDT34/jA2NsrHi+EWA5y23d78SRtJOM8YeQeDFlc1M5b IH8M1ItC+GUhNQxB+WHnB9ORVR+2AxAmPEYyIDvCFm1O6i10aZhEa5qan99tNEToYsXC 4IRxNTmiunc7RMQA798/w56C+54/TXkY1GMG28Evly8psChxm8v5YAyuGFDa2VuhHd+F hzjOei/kiE553pjO/bC/EWtVRhmF4l+1gMCTSvlQoqUssy9fyHxUkAHMvKs3IpaWPzQ+ +4cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678275025; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8KH8jGCskjaNO6GyEN+UrKrvr+UwiHKuZCM0jBvEJmU=; b=R6Utxs5yxIvY9JecK+hOv2c2CEzfJIkT0eon6qm/njt7TRW3aDexKRlaeyfjG694fq frI4JKWqwZFfJhNxIL/9a5V66T7RdQ5V6zWQaWMpfVUlh2GAlCTHxT3WpuaGOr6LbZCv tCBuF2ec7f55Mxpxz/L9+moLnsIbY8cVxAeteEHGFvr1+Anq930v6Ql5JjU86sHYtO38 u7jN0uob/AFCzTDt6v7kzoiu1/V2g/19cEGvN0mF5bDLu0UhSeXY22qi8lOHYK+LTOhQ kgf872AHnfP/pY1MFdelvTTZuRjOuvyegqnxDhEOJ396KloxlwUb+kmOpcaWthdDzOus Z+HQ== X-Gm-Message-State: AO0yUKUFn+LDC1InnG5UZt7xAJbrX2YdZCRW1jQvIR3GVrFvpDOmtcm0 SLIN10yElHYDETzQhmMX9K8xVQ== X-Google-Smtp-Source: AK7set+JDKS84dLj+XNBBSsiuysoWkOblH/R/IWBfCaEcIAnjtKriFx9dlfVOudbggyySIqODUtewg== X-Received: by 2002:a17:906:1846:b0:8b8:c06e:52d8 with SMTP id w6-20020a170906184600b008b8c06e52d8mr16504253eje.36.1678275025487; Wed, 08 Mar 2023 03:30:25 -0800 (PST) Received: from ?IPV6:2a02:810d:15c0:828:ff33:9b14:bdd2:a3da? ([2a02:810d:15c0:828:ff33:9b14:bdd2:a3da]) by smtp.gmail.com with ESMTPSA id y4-20020a170906524400b008d71e08c78dsm7273070ejm.81.2023.03.08.03.30.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 03:30:24 -0800 (PST) Message-ID: <8d20dcfb-480b-3f1a-02b0-294a05a566f7@linaro.org> Date: Wed, 8 Mar 2023 12:30:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v1 1/2] dt-bindings: spi: add loongson spi To: Yinbo Zhu , Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn References: <20230308025908.21491-1-zhuyinbo@loongson.cn> <20230308025908.21491-2-zhuyinbo@loongson.cn> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230308025908.21491-2-zhuyinbo@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/2023 03:59, Yinbo Zhu wrote: > Add the Loongson platform spi binding with DT schema format using > json-schema. > > Signed-off-by: Yinbo Zhu > --- > .../bindings/spi/loongson,ls-spi.yaml | 47 +++++++++++++++++++ > MAINTAINERS | 6 +++ > 2 files changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml Filename matching the compatible. > > diff --git a/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml > new file mode 100644 > index 000000000000..8a13a96b3818 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/spi/loongson,ls-spi.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" Drop the quotes. What was the base of your code here? > + > +title: Loongson SPI controller > + > +maintainers: > + - Yinbo Zhu > + > +allOf: > + - $ref: /schemas/spi/spi-controller.yaml# > + > +properties: > + compatible: > + const: loongson,ls2k-spi > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: boot Drop clock-names, not needed for single entry. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + > +unevaluatedProperties: false Best regards, Krzysztof