From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A8F238F247 for ; Wed, 18 Mar 2026 10:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773830365; cv=none; b=nxtUp/gqZGnyk/K0WAi8+n6CWkvsFZv5ZeNrSWA6CZquG+KqaeoSU0+Fc4yatZ6tIGX2Vb7ePIMz6CKZ4py3Yhhn2ldjW3zu+aNDY4ici6BFN1JahyvJ/6pEEQ8Dh3r2HMm8E/SQezuInwbdwgXNwMkQ7aToaayHl1w+cAXEQ0s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773830365; c=relaxed/simple; bh=Lu/1Gg8AcMocYblP2/duop3ZtFJxThXGBBLZjOrc7z4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QcV1R1fTRdk6VWEEHa0fJ3Mz755Mnr95Gx2lgBhWMKsyVOvbGCOso72N9LULbZsObDcwXFaNYaSBJ+rXRoTZJtGtnCoJ1Gav4V8n+CidCcxP53NmeLVt1zH5lPufC2CR5skITqmgJTdyepJ5RydswB0/22jNrK0HXW4U5pFJqk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GDu7bQQp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DV72IvRa; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GDu7bQQp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DV72IvRa" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62I9I0um2730262 for ; Wed, 18 Mar 2026 10:39:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZHCpdutiIPCDZe+ZxRsP2OGSZ1DdSpbzypkIBafBf9w=; b=GDu7bQQp8kU3xilx vimp/0nqTr3r4KyTjQaIfFFSxP+/Lpv+Evn806VhWahbu+1rRNhxiauk3EiWKOh1 Vni9DfG6utPiv9mOeO4nsocC93yZZYTUyn8aqjvvCZWerCiXy7j1vCnnDUZjmgoi IHDvtf75wPK0yDFT48penoWismdDG6i2y3Vm0AQsVtN4ikXnN46IrYObXbcUp1K8 S3hpapmvBvmaak7zibxupSi1ea31CwRmDUV33UIujA9Ijv4Lq3YPajv0VNFR77TS qkVQeMTnCDXT5B5UwnQ+Oz4vDOHZ/94/dbMlvllGZlYrj/e/tWEcB4X5hVJkgJOg ia5o2w== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy8kjve5u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 10:39:23 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b06395b8deso28045925ad.1 for ; Wed, 18 Mar 2026 03:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773830362; x=1774435162; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZHCpdutiIPCDZe+ZxRsP2OGSZ1DdSpbzypkIBafBf9w=; b=DV72IvRaihcfqn8cXEfgNc9d08CkSCaO1Hic66qSh8l907OsyF53kP9ycsfQdOxydV 2A2G/7/8LFAPPEqfWYmQwCc5pJaCug/YLniqMcVd5h6gRqdyU2MGy+gS/t5PGOUPzezc zRvrBI9sPvyrVm1KPM0g0SEs6tSRMHesEAB6U24nfuh8ryRyCYFiZiWWi2cqTzn5vjFu ZhDpVtdwFJd8FC3t/bH07/j16zVpVhGJFarcdjTkFMPPhQ9FOzZyYFLxwD6bkynTFzzT SS6ZBhZxChhkwxOI98QNxPzd4ESfiYMz1rv1TDTkxMVv4O0ZbIovZd3frjkWbK/WRrMP Be8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773830362; x=1774435162; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZHCpdutiIPCDZe+ZxRsP2OGSZ1DdSpbzypkIBafBf9w=; b=Voc7zgFk7ys0Hhc/3q0CKUs7SImjObs6pP6E6ENG/hjA9rI9/IHzOYb/Zf38nxnNlb lLxDSVU09LXIqDttqLiq9kHDcHJ7H67ORTx3+ESa5neSyynzUeGFw2famEDxSrqfaCxH jQPzYgCgCGcybfcZ9O8UuFmP5F+MvJydv2+Gh4Ug4bFljEmsWXhX6f6u4coujdAlKVpZ yWb1H3pP4r+lHpvyttNhs3TNhqkaQd0Erey2DH6OmX+6ylQZ0x37IiH4WZk3sVYssUOS kFHoImXw0MNDCSAr56WGHVKmAYHrl70yYRWsHHSx2XwGMp9SgmvOLthhNcHAUG927ZIL J43w== X-Forwarded-Encrypted: i=1; AJvYcCW8Wje7nnP7dkaRTk9yf6sunht7YPzq+IPIeieSomATJofU9D/7NLZt1w/Q+GeGzrzyTowY/YwsHCKL7Bs=@vger.kernel.org X-Gm-Message-State: AOJu0YzsPXUT/YeiACFugjx0DZyZo0/zEkJPci0bC99bnkJg5V+dPU3l 4EpgUkFSvB/JB1jQ20fQrgctVlikH0bHJB7orD+oLYMO3mg0oEt51acXc4dxs9Ku3LltuQ3FocW nKz3tQaxN8inhVEqj/KmI3qkQX21FCR4F4JMcHgt9oP1F1mTANu0+eH1VQ9rAzheF1os= X-Gm-Gg: ATEYQzw0v4DVxJ+9Q6DFFOCyNm5HluvaNCnBHClktJDSjE55hnSvIWA2VW7t20yBRlU qLhxcTTSRvwsd6BIyhI2NOT0Cuq8GV+SY8oy2po4aBEi7ttvnE84tfmCeTdAYUJpPc4oD8wjn4F nrn5ZUkcGmLbB1SErzWqJ+hgmwTBXbG1b5A3qaQlzqJXBph43qdHhtWicMMbTKihNKXBICMMFks qRczoIOX4xbPmCCjmK0WtMg0KwOG78lk/r0I70ghVZNU3GNt6uOzZQzfxmwZRt0BsVl8uHxYbAs y0XAJoBD3ugt24fe9QIDkhC+0P/d+Q0h7rb0bZLNjPZCQ/XQTYo9yJG4TFcL9Vxfq/GXJpo9S0i TCm/WWvBlHZN2fvvNTr+9RD0Eh5dBZ11YDwR8axyQ4OrUfZgizKw= X-Received: by 2002:a17:903:1112:b0:2b0:5be9:f423 with SMTP id d9443c01a7336-2b06e40e3b2mr29694705ad.43.1773830362407; Wed, 18 Mar 2026 03:39:22 -0700 (PDT) X-Received: by 2002:a17:903:1112:b0:2b0:5be9:f423 with SMTP id d9443c01a7336-2b06e40e3b2mr29694415ad.43.1773830361919; Wed, 18 Mar 2026 03:39:21 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e419270sm21556485ad.1.2026.03.18.03.39.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 03:39:21 -0700 (PDT) Message-ID: <8d210e75-f471-484e-8a0c-9b8ee7900106@oss.qualcomm.com> Date: Wed, 18 Mar 2026 16:09:12 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/12] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE To: Krzysztof Kozlowski , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Kuldeep Singh References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> <20260317-qcom_ice_power_and_clk_vote-v3-12-53371dbabd6a@oss.qualcomm.com> <8863f38b-51df-43ea-995c-08b9fb04f4dc@kernel.org> Content-Language: en-US From: Harshal Dev In-Reply-To: <8863f38b-51df-43ea-995c-08b9fb04f4dc@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDA4OSBTYWx0ZWRfX+WwuKcGOghza y7T/1Nd8ZmeMTFOprvgXmlN/ELM0Pp2y2ax9szJhPaohhAb4+CsmACBIdmwIudPs4uIl5T2nLDq u510h56x8KWP8TPoqwNbgekPiW08x6dv6tbV02UHziUbA+ees0QvxyC89one694q4u1XN1dWtU9 QgrD7JZ90YyPtIpT7yBBUjhx5AX7zGauRb6y9HH6l3eKARzHuXiJ9Z2iGKZBrrqAyCj0NqFYgW2 c02PvLM9YM4wZhB8CXyXBNNXU2n5fWu4Ue3qaJQiYQDatWGNp6jOGkXC5oqwRrTcjuIJy3KjmLT dXv0ylYC3KR95dn04fmk1coVcqlEj32bNUO6ronmTijzRdtxPWNrwv4DFJUyymUMx3Oj6Oh4fqG ZZqK60WQjZC5pnhw4r5TVImdJgH++jkKluQ6foYW5MkWYy7bAgEq+rQNwefbqRrRyfEkStM92MH XqSxrrnKSTFHEqGTj0A== X-Authority-Analysis: v=2.4 cv=P8I3RyAu c=1 sm=1 tr=0 ts=69ba80db cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=7T9o6mVONip3bYQ_lJkA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 8GMZK_e4YfJvDlPmgZ2OcKatQvjgaJWY X-Proofpoint-GUID: 8GMZK_e4YfJvDlPmgZ2OcKatQvjgaJWY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180089 On 3/18/2026 1:03 PM, Krzysztof Kozlowski wrote: > On 17/03/2026 10:20, Harshal Dev wrote: >> Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver >> de-coupled from the QCOM UFS driver, it explicitly votes for its required >> clocks during probe. For scenarios where the 'clk_ignore_unused' flag is >> not passed on the kernel command line, to avoid potential unclocked ICE >> hardware register access during probe the ICE driver should additionally >> vote on the 'iface' clock. >> Also update the suspend and resume callbacks to handle un-voting and voting >> on the 'iface' clock. >> >> Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver") >> Signed-off-by: Harshal Dev >> --- >> drivers/soc/qcom/ice.c | 17 +++++++++++++++-- > > Why the driver patch is after the DTS patches? It is explicitly > documented as no-go. I will re-order this patch to come after the DT-binding patch and before the DTS patches. Regards, Harshal > > You do not understand how patches are being applied and you think you > can fix inherent problems in bisectability by creating incorrect order > of patches. No, you cannot. Read maintainer soc profile and entire > development-process document, so you understand how patches are applied, > what are branches, what is current RC and how kernel is effectively > released. > > Best regards, > Krzysztof