From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1760218ECC; Wed, 3 Jan 2024 12:22:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="UvrVMDws" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1704284544; bh=lvVhhUPH6kgSD2hH7kfMwPENfYjI5v43CDGfoYJVRe0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UvrVMDwsuNVcANR2Wf07y1FL7XwZ8Qm+ujjQaottzqX+bY65PzxbZmWJQnNGWiJ8N /E3YqU+Li9GVFafwsi77aoAF+/kTCk0EQrqeN16vssbn78S0FaDQK88yFfLdxCCxiS zPXiebjG/5g/lI1xuDibcHbrcEQM/jtpOe49sVpUJOpDb0XLWhNJvE9govjmQDqQ9p WtY1nkayzqCpOC2qd1s3MNbQJLFe2/m3ulrp2ogu856BkjYNFySYqqTDc9MFotfoHT iQUf5t5JlA8oI4vv1r0m2KSBmeQLw3lGF3n0ekk/o/sqvRK+n8m4/PKS9M8pcepDQ2 ELm6KR71o9MDA== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 0A336378104C; Wed, 3 Jan 2024 12:22:22 +0000 (UTC) Message-ID: <8d223e42-7bf0-42c0-8e53-b0425eecfb4d@collabora.com> Date: Wed, 3 Jan 2024 13:22:22 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 12/24] arm64: dts: mediatek: mt8195: Enable cros-ec-spi as wake source Content-Language: en-US To: Mark Hasemeyer , LKML Cc: Sudeep Holla , Rob Herring , Andy Shevchenko , Krzysztof Kozlowski , Konrad Dybcio , Raul Rangel , Tzung-Bi Shih , Conor Dooley , Krzysztof Kozlowski , Matthias Brugger , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20240102210820.2604667-1-markhas@chromium.org> <20240102140734.v4.12.Iee33a7f1f991408cef372744199026f936bf54e2@changeid> From: AngeloGioacchino Del Regno In-Reply-To: <20240102140734.v4.12.Iee33a7f1f991408cef372744199026f936bf54e2@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 02/01/24 22:07, Mark Hasemeyer ha scritto: > The cros_ec driver currently assumes that cros-ec-spi compatible device > nodes are a wakeup-source even though the wakeup-source property is not > defined. > > Some Chromebooks use a separate wake pin, while others overload the > interrupt for wake and IO. With the current assumption, spurious wakes > can occur on systems that use a separate wake pin. It is planned to > update the driver to no longer assume that the EC interrupt pin should > be enabled for wake. > > Add the wakeup-source property to all cros-ec-spi compatible device > nodes to signify to the driver that they should still be a valid wakeup > source. > > Signed-off-by: Mark Hasemeyer Reviewed-by: AngeloGioacchino Del Regno