From: "Huang, Kai" <kai.huang@intel.com>
To: "Hansen, Dave" <dave.hansen@intel.com>,
"seanjc@google.com" <seanjc@google.com>,
"bp@alien8.de" <bp@alien8.de>,
"peterz@infradead.org" <peterz@infradead.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>
Cc: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
"nik.borisov@suse.com" <nik.borisov@suse.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Yamahata, Isaku" <isaku.yamahata@intel.com>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v8 8.2/9] x86/virt/tdx: Reduce TDMR's reserved areas by using CMRs to find memory holes
Date: Wed, 11 Dec 2024 04:34:35 +0000 [thread overview]
Message-ID: <8d2292e69a1076604176e6e8573f26c6cd590075.camel@intel.com> (raw)
In-Reply-To: <86302cfb-7272-4477-b311-e10958ce096f@intel.com>
On Tue, 2024-12-10 at 08:58 -0800, Dave Hansen wrote:
> On 12/9/24 20:24, Huang, Kai wrote:
> > OK. I would like to get the solution agreed. IIUC you prefer to just using
> > CMRs to build TDX-usable memory regions when constructing TDMRs. Please let me
> > know if I have misunderstanding.
> >
> > Please let me know if you are OK with this solution?
>
> I honestly don't know.
>
> What I would prefer is that you take another hard look at the code and
> deeply consider whether there's a simpler solution. My gut says that the
> 8.2/9 patch is too much of a band-aid and adds too much complexity. I'm
> yearning for something simpler.
>
> I'm not going to know whether I'm OK with the solution until the patch
> lands in my inbox. What I do know is that I'd really appreciate if you
> could _explore_ a simpler solution.
Yeah that's the plan. I don't have any simpler solution that doesn't use CMRs
in my mind now but will explore more. Thanks.
next prev parent reply other threads:[~2024-12-11 4:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 11:57 [PATCH v8 0/9] TDX host: metadata reading tweaks and bug fixes Kai Huang
2024-11-13 11:57 ` [PATCH v8 1/9] x86/virt/tdx: Rename 'struct tdx_tdmr_sysinfo' to reflect the spec better Kai Huang
2024-11-13 11:57 ` [PATCH v8 2/9] x86/virt/tdx: Start to track all global metadata in one structure Kai Huang
2024-11-13 11:57 ` [PATCH v8 3/9] x86/virt/tdx: Use auto-generated code to read global metadata Kai Huang
2024-12-13 11:17 ` Huang, Kai
2024-11-13 11:57 ` [PATCH v8 4/9] x86/virt/tdx: Use dedicated struct members for PAMT entry sizes Kai Huang
2024-11-13 11:57 ` [PATCH v8 5/9] x86/virt/tdx: Add missing header file inclusion to local tdx.h Kai Huang
2024-11-13 11:57 ` [PATCH v8 6/9] x86/virt/tdx: Switch to use auto-generated global metadata reading code Kai Huang
2024-11-13 11:57 ` [PATCH v8 7/9] x86/virt/tdx: Trim away tail null CMRs Kai Huang
2024-11-13 11:57 ` [PATCH v8 8/9] x86/virt/tdx: Reduce TDMR's reserved areas by using CMRs to find memory holes Kai Huang
2024-12-04 14:22 ` Huang, Kai
2024-12-05 12:45 ` Huang, Kai
2024-12-05 12:40 ` [PATCH v8 8.1/9] " Kai Huang
2024-12-05 18:10 ` Dave Hansen
2024-12-06 2:45 ` Huang, Kai
2024-12-09 6:57 ` Huang, Kai
2024-12-09 6:50 ` [PATCH v8 8.2/9] " Kai Huang
2024-12-09 22:54 ` Dave Hansen
2024-12-10 2:26 ` Huang, Kai
2024-12-10 2:46 ` Dan Williams
2024-12-10 4:24 ` Huang, Kai
2024-12-10 16:58 ` Dave Hansen
2024-12-11 4:34 ` Huang, Kai [this message]
2024-11-13 11:57 ` [PATCH v8 9/9] x86/virt/tdx: Require the module to assert it has the NO_RBP_MOD mitigation Kai Huang
2024-11-13 22:25 ` [PATCH v8 0/9] TDX host: metadata reading tweaks and bug fixes Edgecombe, Rick P
2024-11-13 22:40 ` Huang, Kai
2024-11-13 22:53 ` Edgecombe, Rick P
2024-11-13 23:35 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d2292e69a1076604176e6e8573f26c6cd590075.camel@intel.com \
--to=kai.huang@intel.com \
--cc=adrian.hunter@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®