mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Atanas Filipov <atanas.filipov@oss.qualcomm.com>,
	linux-media@vger.kernel.org
Cc: mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, andersson@kernel.org,
	konradybcio@kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/4] arm64: dts: qcom: sm8550: Add JPEG encoder node
Date: Sat, 13 Jun 2026 00:14:14 +0100	[thread overview]
Message-ID: <8d230cca-2023-4a13-876f-d5db8eb200a1@kernel.org> (raw)
In-Reply-To: <20260612194417.1737009-3-atanas.filipov@oss.qualcomm.com>

On 12/06/2026 20:44, Atanas Filipov wrote:
> +		qcom_jpeg_enc: jpeg-encoder@ac4e000 {

One key bit of review feedback I gave in the previous leaked version of 
this driver is that since the jpeg-encoder is part of the CAMSS block it 
should be a sub-node of camss as OPE, CSIPHY and other blocks will be.

Please take that feedback onboard in your v2.

---
bod

  reply	other threads:[~2026-06-12 23:14 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 19:44 [PATCH v1 0/4] This series adds support for the Qualcomm JPEG V4L2 mem2mem encoder Atanas Filipov
2026-06-12 19:44 ` [PATCH v1 1/4] dt-bindings: media: qcom: Add JPEG encoder binding Atanas Filipov
2026-06-12 20:42   ` Frank Li
2026-06-12 23:17   ` Bryan O'Donoghue
2026-06-12 23:38   ` Bryan O'Donoghue
2026-06-13 18:42   ` Krzysztof Kozlowski
2026-07-13  7:43     ` Atanas Filipov
2026-06-23  6:41   ` Luca Weiss
2026-06-12 19:44 ` [PATCH v1 2/4] arm64: dts: qcom: sm8550: Add JPEG encoder node Atanas Filipov
2026-06-12 23:14   ` Bryan O'Donoghue [this message]
2026-06-13  9:24     ` Atanas Filipov
2026-06-13  9:52       ` Bryan O'Donoghue
2026-06-13 11:16         ` Atanas Filipov
2026-06-14  1:13           ` Bryan O'Donoghue
2026-06-19 14:38             ` Konrad Dybcio
2026-06-19 14:57               ` Vladimir Zapolskiy
2026-06-12 23:52   ` Bryan O'Donoghue
2026-06-13 16:05     ` Atanas Filipov
2026-06-14  0:53       ` Bryan O'Donoghue
2026-06-14 21:28   ` Dmitry Baryshkov
2026-06-12 19:44 ` [PATCH v1 3/4] arm64: dts: qcom: sm8250: " Atanas Filipov
2026-06-12 19:44 ` [PATCH v1 4/4] media: qcom: jpeg: Add Qualcomm JPEG V4L2 encoder Atanas Filipov
2026-06-12 20:53   ` Frank Li
2026-06-13 18:43   ` Krzysztof Kozlowski
2026-07-13  7:50     ` Atanas Filipov
2026-06-25 13:43 ` [PATCH v1 0/4] This series adds support for the Qualcomm JPEG V4L2 mem2mem encoder Atanas Filipov
2026-06-25 13:53   ` Krzysztof Kozlowski
2026-07-13  7:52     ` Atanas Filipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d230cca-2023-4a13-876f-d5db8eb200a1@kernel.org \
    --to=bod@kernel.org \
    --cc=andersson@kernel.org \
    --cc=atanas.filipov@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome