From: sunran001@208suo.com
To: davem@davemloft.net
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] floppy: add missing put_device()
Date: Tue, 18 Jul 2023 17:02:54 +0800 [thread overview]
Message-ID: <8d2649460d95597d2d4de3777b2043f7@208suo.com> (raw)
In-Reply-To: <20230718090203.17548-1-xujianghui@cdjrlc.com>
The of_find_device_by_node() takes a reference to the underlying device
structure, we should release that reference.
./arch/sparc/include/asm/floppy_64.h:562:1-22: WARNING: Function
"for_each_node_by_name" should have of_node_put() before break around
line 567.
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
arch/sparc/include/asm/floppy_64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sparc/include/asm/floppy_64.h
b/arch/sparc/include/asm/floppy_64.h
index 53e77c0974f9..619255e8c9ac 100644
--- a/arch/sparc/include/asm/floppy_64.h
+++ b/arch/sparc/include/asm/floppy_64.h
@@ -594,7 +594,7 @@ static unsigned long __init sun_floppy_init(void)
if (state_prop && !strncmp(state_prop, "disabled", 8)) {
put_device(&op->dev);
return 0;
- }
+ }
FLOPPY_IRQ = op->archdata.irqs[0];
next parent reply other threads:[~2023-07-18 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230718090203.17548-1-xujianghui@cdjrlc.com>
2023-07-18 9:02 ` sunran001 [this message]
2023-07-18 14:51 ` Sam Ravnborg
[not found] <20230718080812.16801-1-xujianghui@cdjrlc.com>
2023-07-18 8:09 ` sunran001
2023-07-18 8:51 ` Kjetil Oftedal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d2649460d95597d2d4de3777b2043f7@208suo.com \
--to=sunran001@208suo.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®