From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Fedor Pchelkin <pchelkin@ispras.ru>, David Sterba <dsterba@suse.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
Boris Burkov <boris@bur.io>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org,
syzbot+81670362c283f3dd889c@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH] btrfs: qgroup: add missing extent changeset release
Date: Wed, 28 Aug 2024 19:00:03 +0930 [thread overview]
Message-ID: <8d26b493-6bc4-488c-b0a7-f2d129d94089@gmx.com> (raw)
In-Reply-To: <230ede6f-1cbb-4b25-ab1a-a54f7d29c92d@gmx.com>
在 2024/8/28 18:54, Qu Wenruo 写道:
>
>
> 在 2024/8/28 00:42, Fedor Pchelkin 写道:
>> The extent changeset may have some additional memory dynamically
>> allocated
>> for ulist in result of clear_record_extent_bits() execution.
>>
>> Release it after the local changeset is no longer needed in
>> BTRFS_QGROUP_MODE_DISABLED case.
>>
>> Found by Linux Verification Center (linuxtesting.org) with Syzkaller.
>>
>> Reported-by: syzbot+81670362c283f3dd889c@syzkaller.appspotmail.com
>> Closes:
>> https://lore.kernel.org/lkml/000000000000aa8c0c060ade165e@google.com
>> Fixes: af0e2aab3b70 ("btrfs: qgroup: flush reservations during quota
>> disable")
>> Cc: stable@vger.kernel.org # 6.10+
>> Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
>
> Reviewed-by: Qu Wenruo <wqu@suse.com>
>
> In this particular case, the changeset is really only locally utilized,
> thus should always be released.
My bad, after checking your latest reply to David, I think we can go one
step further.
Just do not pass changeset to clear_record_extent_bits().
A changeset is utilized for two reasons:
- To let the caller know how many bytes are changed
Just like what we did for the qgroup enabled case.
- Allow the caller to revert its change
This happens for qgroup_unreserve_range() when we hit an error and
needs to free what we just reserved.
In this particular case, since qgroup is already disabled, we just want
to clear the extent io tree bits, not really bother how many bytes are
released nor keep the info for reverting.
So just pass NULL and everything should be fine.
Thanks,
Qu
>
> Thanks,
> Qu
>> ---
>> fs/btrfs/qgroup.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
>> index 5d57a285d59b..4f1fa5d427e1 100644
>> --- a/fs/btrfs/qgroup.c
>> +++ b/fs/btrfs/qgroup.c
>> @@ -4345,9 +4345,10 @@ static int __btrfs_qgroup_release_data(struct
>> btrfs_inode *inode,
>>
>> if (btrfs_qgroup_mode(inode->root->fs_info) ==
>> BTRFS_QGROUP_MODE_DISABLED) {
>> extent_changeset_init(&changeset);
>> - return clear_record_extent_bits(&inode->io_tree, start,
>> - start + len - 1,
>> - EXTENT_QGROUP_RESERVED, &changeset);
>> + ret = clear_record_extent_bits(&inode->io_tree, start,
>> + start + len - 1,
>> + EXTENT_QGROUP_RESERVED, &changeset);
>> + goto out;
>> }
>>
>> /* In release case, we shouldn't have @reserved */
>
next prev parent reply other threads:[~2024-08-28 9:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 15:12 Fedor Pchelkin
2024-08-27 16:03 ` David Sterba
2024-08-28 9:19 ` Fedor Pchelkin
2024-08-28 9:24 ` Qu Wenruo
2024-08-28 9:30 ` Qu Wenruo [this message]
2024-08-28 16:14 ` [PATCH v2] btrfs: qgroup: don't use extent changeset when not needed Fedor Pchelkin
2024-08-28 16:57 ` Boris Burkov
2024-08-28 21:36 ` Qu Wenruo
2024-08-28 21:56 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d26b493-6bc4-488c-b0a7-f2d129d94089@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=boris@bur.io \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=pchelkin@ispras.ru \
--cc=stable@vger.kernel.org \
--cc=syzbot+81670362c283f3dd889c@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®