From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5D07C3A5A7 for ; Thu, 8 Dec 2022 15:09:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229772AbiLHPJq (ORCPT ); Thu, 8 Dec 2022 10:09:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbiLHPJo (ORCPT ); Thu, 8 Dec 2022 10:09:44 -0500 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6C49349B70; Thu, 8 Dec 2022 07:09:43 -0800 (PST) Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 09 Dec 2022 00:09:42 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id CDA812058B4F; Fri, 9 Dec 2022 00:09:42 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Fri, 9 Dec 2022 00:09:42 +0900 Received: from [10.212.157.17] (unknown [10.212.157.17]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 0E4CE1DA8; Fri, 9 Dec 2022 00:09:42 +0900 (JST) Message-ID: <8d29ddb9-359c-df91-abb6-acdb6927fa95@socionext.com> Date: Fri, 9 Dec 2022 00:09:41 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 01/16] dt-bindings: clock: Fix node descriptions in uniphier-clock example To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski Cc: Masami Hiramatsu , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221207055405.30940-1-hayashi.kunihiko@socionext.com> <20221207055405.30940-2-hayashi.kunihiko@socionext.com> Content-Language: en-US From: Kunihiko Hayashi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/12/08 17:06, Krzysztof Kozlowski wrote: > On 07/12/2022 06:53, Kunihiko Hayashi wrote: >> Prior to adding dt-bindings for SoC-dependent controllers, rename the >> clock nodes their parent nodes to the generic names in the example. >> >> And also fix the missing compatible string. >> >> Signed-off-by: Kunihiko Hayashi >> --- >> .../clock/socionext,uniphier-clock.yaml | 21 +++++++++++-------- >> 1 file changed, 12 insertions(+), 9 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >> b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >> index 9a0cc7341630..672450a1ecda 100644 >> --- >> a/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >> +++ >> b/Documentation/devicetree/bindings/clock/socionext,uniphier-clock.yaml >> @@ -61,11 +61,12 @@ required: >> >> examples: >> - | >> - sysctrl@61840000 { >> - compatible = "socionext,uniphier-sysctrl", "simple-mfd", >> "syscon"; >> + syscon@61840000 { >> + compatible = "socionext,uniphier-ld11-sysctrl", >> + "simple-mfd", "syscon"; >> reg = <0x61840000 0x4000>; >> >> - clock { >> + clock-controller { >> compatible = "socionext,uniphier-ld11-clock"; >> #clock-cells = <1>; >> }; >> @@ -74,11 +75,12 @@ examples: >> }; >> >> - | >> - mioctrl@59810000 { >> - compatible = "socionext,uniphier-mioctrl", "simple-mfd", >> "syscon"; >> + syscon@59810000 { >> + compatible = "socionext,uniphier-ld11-mioctrl", >> + "simple-mfd", "syscon"; >> reg = <0x59810000 0x800>; >> >> - clock { >> + clock-controller { >> compatible = "socionext,uniphier-ld11-mio-clock"; >> #clock-cells = <1>; >> }; >> @@ -87,11 +89,12 @@ examples: >> }; >> >> - | >> - perictrl@59820000 { >> - compatible = "socionext,uniphier-perictrl", "simple-mfd", >> "syscon"; >> + syscon@59820000 { >> + compatible = "socionext,uniphier-ld11-perictrl", >> + "simple-mfd", "syscon"; >> reg = <0x59820000 0x200>; >> >> - clock { > > These are all three same examples (no differences except compatibles), > so you can as well keep only one. You can also skip parent node, > otherwise you might keep getting warnings for this schema. The parent is > not that relevant here and its bindings (e.g. > socionext,uniphier-sysctrl.yaml) should include complete example - > parent with all the children. I understand. I'll keep one and drop the parent node from the example. Thank you, --- Best Regards Kunihiko Hayashi