Re: [PATCH] lockdep: Use info level for lockdep initial info messages

[Waiman Long <llong@redhat.com>]

On 10/7/24 2:54 AM, Jiri Slaby (SUSE) wrote:
> All those:
>   Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar
>   ... MAX_LOCKDEP_SUBCLASSES:  8
>   ... MAX_LOCK_DEPTH:          48
>   ... MAX_LOCKDEP_KEYS:        8192
> and so on are dumped with the KERN_WARNING level. It is due to missing
> KERN_* annotation.
>
> Use pr_info() instead of bare print() to dump the info with the info
> level.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Waiman Long <longman@redhat.com>
> Cc: Boqun Feng <boqun.feng@gmail.com>
> ---
>   kernel/locking/lockdep.c | 22 +++++++++++-----------
>   1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 536bd471557f..ae8750157099 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -6576,17 +6576,17 @@ EXPORT_SYMBOL_GPL(lockdep_unregister_key);
>   
>   void __init lockdep_init(void)
>   {
> -	printk("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
> +	pr_info("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
>   
> -	printk("... MAX_LOCKDEP_SUBCLASSES:  %lu\n", MAX_LOCKDEP_SUBCLASSES);
> -	printk("... MAX_LOCK_DEPTH:          %lu\n", MAX_LOCK_DEPTH);
> -	printk("... MAX_LOCKDEP_KEYS:        %lu\n", MAX_LOCKDEP_KEYS);
> -	printk("... CLASSHASH_SIZE:          %lu\n", CLASSHASH_SIZE);
> -	printk("... MAX_LOCKDEP_ENTRIES:     %lu\n", MAX_LOCKDEP_ENTRIES);
> -	printk("... MAX_LOCKDEP_CHAINS:      %lu\n", MAX_LOCKDEP_CHAINS);
> -	printk("... CHAINHASH_SIZE:          %lu\n", CHAINHASH_SIZE);
> +	pr_info("... MAX_LOCKDEP_SUBCLASSES:  %lu\n", MAX_LOCKDEP_SUBCLASSES);
> +	pr_info("... MAX_LOCK_DEPTH:          %lu\n", MAX_LOCK_DEPTH);
> +	pr_info("... MAX_LOCKDEP_KEYS:        %lu\n", MAX_LOCKDEP_KEYS);
> +	pr_info("... CLASSHASH_SIZE:          %lu\n", CLASSHASH_SIZE);
> +	pr_info("... MAX_LOCKDEP_ENTRIES:     %lu\n", MAX_LOCKDEP_ENTRIES);
> +	pr_info("... MAX_LOCKDEP_CHAINS:      %lu\n", MAX_LOCKDEP_CHAINS);
> +	pr_info("... CHAINHASH_SIZE:          %lu\n", CHAINHASH_SIZE);
>   
> -	printk(" memory used by lock dependency info: %zu kB\n",
> +	pr_info(" memory used by lock dependency info: %zu kB\n",
>   	       (sizeof(lock_classes) +
>   		sizeof(lock_classes_in_use) +
>   		sizeof(classhash_table) +
> @@ -6604,12 +6604,12 @@ void __init lockdep_init(void)
>   		);
>   
>   #if defined(CONFIG_TRACE_IRQFLAGS) && defined(CONFIG_PROVE_LOCKING)
> -	printk(" memory used for stack traces: %zu kB\n",
> +	pr_info(" memory used for stack traces: %zu kB\n",
>   	       (sizeof(stack_trace) + sizeof(stack_trace_hash)) / 1024
>   	       );
>   #endif
>   
> -	printk(" per task-struct memory footprint: %zu bytes\n",
> +	pr_info(" per task-struct memory footprint: %zu bytes\n",
>   	       sizeof(((struct task_struct *)NULL)->held_locks));
>   }
>   

Make sense!

Reviewed-by: Waiman Long <longman@redhat.com>