From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28EFEC43217 for ; Thu, 26 May 2022 06:54:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346267AbiEZGyB (ORCPT ); Thu, 26 May 2022 02:54:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346264AbiEZGx7 (ORCPT ); Thu, 26 May 2022 02:53:59 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 996495DA3F for ; Wed, 25 May 2022 23:53:57 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id n10so1282551ejk.5 for ; Wed, 25 May 2022 23:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=+OlWFNuXubaG+wIbcU6S2PD/trjlRQ/H0QdDAVlC7L8=; b=HTSbKdqa3Nz+rgnORHSDlCCrWGmPxq/uTvVIJ1mdxP93fxi23p4/iaudQGQ0yvJ9qD sVCbrRfo4bBZ9mQRMOESsrCFhgNGIGplr+gRzybCAWSTUbTrkEc8qWTZ4+OL34B9gBo5 dOF8MFYMdEGZrlkLcq9wisY90Wjy5NOu5xRch0PKTnXgXXXoQiEdUGSOr8epjCyfTbVS Dr28G81aHk81OulVCikCIbagbO+Y4eDk0jAdcfnyEEMK2ynz5Uduj5WXS6eh/HElm7AY yhKdPVZCKYG7q/YHZlKZoSErjnkxy2vKC9OXBJfkrBc3mnIe3F9Jp3DD8FlhwnTPS8Hy kCZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+OlWFNuXubaG+wIbcU6S2PD/trjlRQ/H0QdDAVlC7L8=; b=Fmw4IZFZVL1mRVDrN/rrB1LRwB+wyNfUDOXXoCi6Znij5H1V/s+hvcziJgTfNG7G/Q OfK0fnRgC6JIxxjP/nXQwrBmRV30x0Nsf+7wB5ZUFeO0OhD2CPl+wuuYY5JBrLkdWkPE ajJ0/D86vl4SKBn89Ja7J1XoqoadNuVDp/wZs3vsImOoHSgGdFaKTw+P/Eg+vdpmibys avZ6nFhoOQDyIjbTxK56CXqFQFEm/B23dmFybuKfxSseunA1Ee6Pi/3hAZxYzGEMalWU CAHAI2e+XcHv3gYCS8+RXC03Eg0k6nsSIQ4AljkUD/IzEUwn4F18bBZBShuJ5l9qfoh1 hiFw== X-Gm-Message-State: AOAM533mIr9NJAoxd2v4aFfj+MQw82TLYcYe7g3AAf9Re0PR8YHrPWcL p1B661W+ByJAKH7Od/aglZWDFQ== X-Google-Smtp-Source: ABdhPJxK0GdBqnqhHeFKnB17hFODfbqtX8jNbVhbmw+n/G8WMqDopEGaBisjwS7Dq3PBf+ZqYanNVA== X-Received: by 2002:a17:906:9b90:b0:6ff:a02:1f9 with SMTP id dd16-20020a1709069b9000b006ff0a0201f9mr9350097ejc.672.1653548036203; Wed, 25 May 2022 23:53:56 -0700 (PDT) Received: from [192.168.0.177] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id x65-20020a50bac7000000b0042617ba63absm389060ede.53.2022.05.25.23.53.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 May 2022 23:53:55 -0700 (PDT) Message-ID: <8d2c9375-63d7-6d36-8a0b-6c5d117cc213@linaro.org> Date: Thu, 26 May 2022 08:53:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 11/11] arm64: dts: Add Pensando Elba SoC support Content-Language: en-US To: Brad Larson Cc: Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Serge Semin , Adrian Hunter , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-12-brad@pensando.io> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/05/2022 02:19, Brad Larson wrote: > Hi Krzysztof, > > On Thu, Apr 7, 2022 at 12:06 PM Krzysztof Kozlowski > wrote: >> >> On 07/04/2022 01:36, Brad Larson wrote: >>> Add Pensando common and Elba SoC specific device nodes >>> >>> +&spi0 { >>> + num-cs = <4>; >>> + cs-gpios = <0>, <0>, <&porta 1 GPIO_ACTIVE_LOW>, >>> + <&porta 7 GPIO_ACTIVE_LOW>; >>> + status = "okay"; >>> + spi0_cs0@0 { >> >> Generic node name needed matching the class of a devicxe. > > The device on this spi bus is a FPGA with 4 functions and looking at > other projects I've changed it to a resource-controller node name. On > cs0 there is a sub-device reset-controller added in the upcoming > patchset to enable hardware reset of the eMMC device. > >>> + compatible = "semtech,sx1301"; /* Enable spidev */ >> >> This comment is a bit odd... did you just use random compatible from >> spidev instead of defining proper compatible? > > Yes, because adding a compatible was nacked. We have a driver added > (two actually, mfd and reset driver) for the next patch update. Yeah, but using some other one is also not correct. Best regards, Krzysztof