From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794545528; b=fqXWc9+StHPv1rHobYLUq5oSgCq/TT6daQQdv1PD3b3z9zbCAYsOK30Ll46t8Q805IME gBgn6G/Qk4xk90zOObaT0stfAhmrGOxP1tMihtIov7Mt6rcbO6n7mxGupp0QPU3ObwsPX ZPWR9DecAk+HZNC+rlfPHnye1j7QHfHmlHKYBIgP7S4v9J8QKiKQMkvD8bGXYxAbLcO8P zA9ETLRk1B8pLWVqX21IaHXnQsY7YgOMn21PvsU5SlOLFtVaj96tbvT8U/PfVZ4kt3Pc/ fs6v0cXQzXQTway/LunpG36El1X8n9FFV3VuYgs/BoYbDa0d2EJ8W/jc2Q8M3FVLiAQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794545528; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-GUID:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-ORIG-GUID: X-Authority-Analysis:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=UMrXrqjcsDJ3ihciM+V6CPHNii9aPk5xl4qMC0+9WnY=; b=Ou6LnnH9QwT6qAcZmBpGZab+GPDxBcrw5d027a2iuShqTtH7HAu/uxgGu8TNMvKMIJ0R vbFfwiPzjflghw7kK6Neviaj65usBM1pNGRIHY3l0sz/m1MguSsS+x06BzRj+jZMsJOsi WMs6EmzG8d3Xths2955AF5kQPsXzHhNnRexLXMQdiYnOwdUD39imrULz14u1LsNSGK3zl NXPVN8ZK5+Hq5CsAnDUwL5lx1KSKeZ4t2PADFxHPRwWdkHddOQaSVdxwym6AU9Q+lvVCo QlwZH4m230vq/mM9fxBx0l7x1fJP8ixqw95jxkqgFu3V+H8o8YB8kdOkpdX27ofQd6g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=m1uMajdG; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Vek6tlS1; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A3DF606A321 for ; Fri, 13 Nov 2026 04:52:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3A3DF606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=m1uMajdG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=Vek6tlS1 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AD2K9KS2843564 for ; Fri, 13 Nov 2026 04:52:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UMrXrqjcsDJ3ihciM+V6CPHNii9aPk5xl4qMC0+9WnY=; b=m1uMajdGfB8yNmqF Bv6eb/e7HDfPOxU/G29prAYNpGd6MNvArlxR+mYcCDGDpIFi7s0oJPb1y437KXj+ twmqPirPxPyhnYKvCzV+yuAab4993STXKfVw6grkwIjPPDYR0U5Q6w8B6NWdiFU6 8mNbH/JWVuFeDnngEkNj1eSjJkE/Kdo6db4kUuADp8WL7VECjHhEON/OwiTz7z86 WCd1XFUNkvv0vYrWo8aL9TBvMCj1cbJhXrThDa5sQQo8hXTFXbiAYQGiV9kgz2kK TXeosIb/4zNRoBLNdR05/ByEqWorjLDydZoAawNlCOU4AR7pfMCijbQ7mcQMEt7P Vy/Rnw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hwan4up88-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Nov 2026 04:52:06 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3b0a13ae043so700571a91.0 for ; Thu, 12 Nov 2026 20:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794545525; x=1795150325; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UMrXrqjcsDJ3ihciM+V6CPHNii9aPk5xl4qMC0+9WnY=; b=Vek6tlS1ODhMbTc4sWOHoxzoJy43Kapsn26KoJ0rHOEx+7KwWVqSKqYGYkyPSw6UTC Dj86Kna2qw3SooC0ISeaY9xEOKsDattxDfNcmiAGJ2W/qPI5q2mqvTbVDXKe5gv9KKFz vTVe/LsZO4BJ1pUONmZpmfRqUNqcDLzEUVv5RbjqCGHmKfBHH3xMQ3hMoRlF42INbl0j G+IZm8mV6unvJ4QgFHg4/SDP02lY/a5q5Rnpu7JVKuoECeF3pqZPx/GpBs8s5oiCAT5U O6Iqtygv1smaam7WwDVhnCEYMUynPiyzRsQnwhxGjL0KOMA26vrE21eAtElK+MTExk/x qIZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794545525; x=1795150325; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UMrXrqjcsDJ3ihciM+V6CPHNii9aPk5xl4qMC0+9WnY=; b=UcMKRlum/M4kkQETzX1TzjlZ0eUdfStq1l27SzDl2r8CXM459EDRa6Azsuuoh2cCIh ZVS9He9AJEsnC0Sg88/Y31iKg2jB0GzWoIX4C+CZXz5aUvSSRHZIThygH2Nytt7b8Kko klX2NvVD03qJuD1Yqr+b2JSQQQ4Sy3894SC6VPQQ/UFxa6YvhGbkNmJkbBdfCtcySrBG BJmsDxjcPp5DAGvaMHgHEQ8K9/TsH4Hc5gPVYwJR1CrWd7/bn/jgCvx6EpkJ6pOSjIPp GvJzBMPeH6ig0XK/pHmVneGBVu6vRLbt/hDMeCFSWXAzGOTAAzEyUUbf8JCHYtq0oSLh LdJw== X-Forwarded-Encrypted: i=1; AL+hErHAzLjqnZocLD8rjNBzrGpqMEZLSPopxkjtpHvpnh3P179I6+/ASgofou1cbKVRcJBfNn97BQQcDBA18pc=@vger.kernel.org X-Gm-Message-State: APuU4Z9XB145L/n6FW0HxOYXrTw7HIrE3fEohWqFYePGTRCs6faLe0GZ vQ9dnlkpgmD6dD9CpM6tJykZ930jvwz6VrUVo9gMG6lFIoku11gBpFAyaA31TSBBT4Iz8goyFBg GtRC51rashF8Kaz5D0zeVoHFhfTWaG9VnPJa921XwacpTCw8nSO8jW7ziZQuOC2moQds= X-Gm-Gg: AYBFou1tT9dbPFsEL81Supu7Lw4C6owk1ef6NQ3D4lhiYAiMWGla7nBiWFaY30QoKBl MrmFQw3zJPtZQLgUiYYN6WsUeoGIehOcK3MH/5f9ZKh2u+fU0X8Fv1oObsN4SrxxwZbSqlPMJ0J 5btEY6ehGO8MazycfpRIV1aC7CE1c4pBEnGR39VPBuIICNWKnIRv4l1e1XPbEP7gn6fn3/HJg49 58wgmXdfht/RoO1zfK+4ynfTLyAXNTYj8S7lFjGjdhuaZj2moEOtaWqb9GZnyfgQp0Iam9ugY2J uMR8VDHBR1DQ3rDT1A1Hu+iizaG+x/AjNSUJF/n8i6tA4SjUDagMRW5z2s5pFXc+BoHXcrwrZNC WfF517yJjSNd7AKlCCKKf+5Ucv/l+MGM1XiCkMsAN9sxiP7ZG1VLEeRVyWTshFg== X-Received: by 2002:a17:90b:574b:b0:3ac:b145:8f4 with SMTP id 98e67ed59e1d1-3b1b0cc9790mr1123863a91.41.1794545525012; Thu, 12 Nov 2026 20:52:05 -0800 (PST) X-Received: by 2002:a17:90b:574b:b0:3ac:b145:8f4 with SMTP id 98e67ed59e1d1-3b1b0cc9790mr1123826a91.41.1794545524150; Thu, 12 Nov 2026 20:52:04 -0800 (PST) Received: from [10.204.79.100] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b1aec63b9bsm2524494a91.12.2026.11.12.20.51.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2026 20:52:03 -0800 (PST) Message-ID: <8d30551c-38b0-4f4d-a532-f574ebb5373a@oss.qualcomm.com> Date: Fri, 13 Nov 2026 10:21:56 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] phy: qcom: qmp-combo: delay Type-C mux switch while DP PHY is initializing To: Dmitry Baryshkov Cc: vkoul@kernel.org, neil.armstrong@linaro.org, mani@kernel.org, robin.clark@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, sean@poorly.run, marijn.suijten@somainline.org, irlied@gmail.com, simona@ffwll.ch, Saurabh Anand , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, quic_riteshk@quicinc.com, quic_vproddut@quicinc.com, quic_mkuntuma@quicinc.com, mahadevan.p@oss.qualcomm.com References: <20261111104434.2222182-1-naidu.nama@oss.qualcomm.com> <20261111104434.2222182-2-naidu.nama@oss.qualcomm.com> Content-Language: en-US From: Naidu Nama In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: wlaB_Jw3ohmhRbiprFfI1rvYRY6_Wvgq X-Proofpoint-Spam-Info: AW1haW4tMjYxMTEzMDAxOSBTYWx0ZWRfX43pi/SbBGpz/ fYdTMKYl6Xfs3iFnjCvjll1hGf6XQJDsmkrHWRYs5UKnTd9DJjoVRS7rsehn/HKYcN4Wco6qvM/ TNt++CL+o5tzWvq6KaQXPOvrMGqW0CY= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTEzMDAxOSBTYWx0ZWRfX4fkMrUSNz07D hmDQYXYBrMvodvkvsOpsc35YjEizqdoVwIoBK/PCsiNalbJGA+ivTIuEhXCxiYUektubCeCWEej r7Nph9a+Xw7P9DIYyV5rkDJLPnNICtpUm8n26gTfEt5LqdxRaSGo0/BsxBy1vWCgPFb1GsKKvrM jtRGnsRTQPyvGa1gsE8eyOtcCjp6sduwClJEQaeqtvzwtZAKfR2Ef9DM+xOFMIXstm5FlWHocis Ai+Wk1TddxTbQ/+vJbjm9hT87gT3htS6sQAbUr4X7rEUOjtD2jMahSyZb5OwANIlgcn9+o3qTTX JEABFTlqIFXmbovsG6tCyjbizfbdFHmZJzZnn6CWjCSWqjqtv4kFFR8jUv7l4mow86qlPOlgtuQ 8eoFdL8/h3l1AhKOym8FBJlUFEHuK95O4taMTETjdVDEuwC2vrRVePJ+V4FmXWlS3+b+da/sXCn 9o3tpcsyGsqFNYMtilQ== X-Proofpoint-ORIG-GUID: wlaB_Jw3ohmhRbiprFfI1rvYRY6_Wvgq X-Authority-Analysis: v=2.4 cv=Gd+CDgXL c=1 sm=1 tr=0 ts=6af69776 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=GP3zSRAhaBPBpq4jRjIA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-13_01,2026-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611130019 On 11-11-2026 19:36, Dmitry Baryshkov wrote: > On Wed, Nov 11, 2026 at 04:13:53PM +0530, naidu nama wrote: >> From: Saurabh Anand >> >> The Type-C mux switch guard only checked dp_powered_on, which is set in >> qmp_combo_dp_power_on(). However there is a race window between >> qmp_combo_dp_init() and qmp_combo_dp_power_on() during which dp_init_count >> is non-zero but dp_powered_on is still false. A Type-C orientation change >> arriving in this window would proceed with the mux switch while the DP PHY >> is mid-initialization, corrupting the PHY state. > How is going to be handled then? With dp_init_count check, mux_set will be skipped. > >> Extend the guard to also block the mux switch when dp_init_count is >> non-zero, covering the full period from dp_init through dp_power_on. >> >> Signed-off-by: Saurabh Anand > Naidu, you are resending the other people patches, but the SoB is > missing. Sure, I will update in v3. > >> --- >> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >> index 61d8b7a5ce8f..3f93043f94e5 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c >> @@ -5163,7 +5163,8 @@ static int qmp_combo_typec_mux_set(struct typec_mux_dev *mux, struct typec_mux_s >> return 0; >> } >> >> - if (qmp->qmpphy_mode != QMPPHY_MODE_USB3_ONLY && qmp->dp_powered_on) { >> + if (qmp->qmpphy_mode != QMPPHY_MODE_USB3_ONLY && >> + (qmp->dp_powered_on || qmp->dp_init_count)) { > Can dp_powered_on be dropped then? Yes, this can be dropped. > >> dev_dbg(qmp->dev, "typec_mux_set: DP PHY is still in use, delaying switch\n"); >> return 0; >> } >> -- >> 2.43.0 >>