mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: shawn.lin@rock-chips.com, Adrian Hunter <adrian.hunter@intel.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Christian Lohle <CLoehle@hyperstone.com>,
	linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [PATCH 0/3] mmc: core: Avoid hogging the CPU while polling for busy
Date: Tue, 6 Jul 2021 15:05:15 +0800	[thread overview]
Message-ID: <8d310df9-2139-e5ff-e0ee-205ffc1778a2@rock-chips.com> (raw)
In-Reply-To: <20210702134229.357717-1-ulf.hansson@linaro.org>

On 2021/7/2 21:42, Ulf Hansson wrote:
> Step by step, code that have been dealing sending CMD13 to poll the card for
> busy, have been moved to use the common mmc_poll_for_busy() loop. This helps to
> avoid hogging the CPU, for example, as it inserts a small delay in between each
> polling attempt. Additionally, it avoids open coding.
> 
> This series takes the next and final step, by moving the mmc block device layer
> from its own busy polling loop, into using the common code.
> 
> Please test and review!

Hi Ulf,

This patch-set looks good,

Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>

> 
> Kind regards
> Uffe
> 
> Ulf Hansson (3):
>    mmc: core: Avoid hogging the CPU while polling for busy in the I/O err
>      path
>    mmc: core: Avoid hogging the CPU while polling for busy for mmc ioctls
>    mmc: core: Avoid hogging the CPU while polling for busy after I/O
>      writes
> 
>   drivers/mmc/core/block.c   | 74 +++++++++++++++++---------------------
>   drivers/mmc/core/mmc_ops.c |  5 ++-
>   drivers/mmc/core/mmc_ops.h |  1 +
>   3 files changed, 37 insertions(+), 43 deletions(-)
> 



  parent reply	other threads:[~2021-07-06  7:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 13:42 Ulf Hansson
2021-07-02 13:42 ` [PATCH 1/3] mmc: core: Avoid hogging the CPU while polling for busy in the I/O err path Ulf Hansson
2021-07-02 13:42 ` [PATCH 2/3] mmc: core: Avoid hogging the CPU while polling for busy for mmc ioctls Ulf Hansson
2021-07-02 13:42 ` [PATCH 3/3] mmc: core: Avoid hogging the CPU while polling for busy after I/O writes Ulf Hansson
2021-07-06  7:05 ` Shawn Lin [this message]
2021-08-04 11:34 ` [PATCH 0/3] mmc: core: Avoid hogging the CPU while polling for busy Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d310df9-2139-e5ff-e0ee-205ffc1778a2@rock-chips.com \
    --to=shawn.lin@rock-chips.com \
    --cc=CLoehle@hyperstone.com \
    --cc=adrian.hunter@intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®