From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 772B63D0930 for ; Tue, 10 Mar 2026 12:31:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773145886; cv=none; b=QT4Efnkc1cwls4mVDd00S+2Ko7LVcppgckaSM2UkEHxKqAXyxItpVKZYmkAZE1gn/KDmPCAZinEZ/UbqhwXJtjs100d0KWF5OJz1TsDlZCCq6CccCK4G+l2zP+jMJEPb4zd+rv9Lm/W0KzB3z86K3Ew24krGOI4wzg8Hh06d2hM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773145886; c=relaxed/simple; bh=O0qrn9d7S7AyHe7vYAv9x2SN2/8h4evFQLk0vYAxM3o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WOR0e8xcHPwXN1ZmpppgXHyoO14Qa+mQGh0eyc8EHnPqdkfy+PhSfvmbh47hqx/2JoCLUar83/l20c83pv1QtA+EvGWCXmiqdDkg7rU8j12dBMqYRb/oVvbwOtnMSsz8g+dYqR594c1NxDdce8+KS+vWncZAwprhCB+2GBxkGhg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VN/a2bJ6; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Sr7OoWI1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VN/a2bJ6"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Sr7OoWI1" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62ABZJQj2021604 for ; Tue, 10 Mar 2026 12:31:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= O0qrn9d7S7AyHe7vYAv9x2SN2/8h4evFQLk0vYAxM3o=; b=VN/a2bJ6DYYQcqX3 59lsCwHRPJvJduE9vg2qITYSlGUyJrTYg5SSIaoNYGxriVz3VAYjjHhaKmNeq1UF kdkbg4mFOHIAFbpEndafQx95gBRGwKOfBBFyptEj1ZH8P25rUg2XvdmYThLJ9pzA 5C8znk3FOIt4qSDjEMQBrA7pXzVDPyeye9QNsr5AXKAFN8aYyFR9JykcFPqX4KfP rCtCj+r2SFC6WUM87snXcBw/3mha/M1XkEEaUx33eeAHNCNmdL3ztXOtxPYiDQHe rCeZmHMBfe7YfGSi/CmQixGYut6GzNztdtrMQ+MX9v4TQ0UUySaei9Ehn+TRol9B DifKbg== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cte3w9agc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 12:31:24 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5ffce0eabf7so713618137.1 for ; Tue, 10 Mar 2026 05:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773145884; x=1773750684; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=O0qrn9d7S7AyHe7vYAv9x2SN2/8h4evFQLk0vYAxM3o=; b=Sr7OoWI1hvJwjLACl4nwrCIffZeiObjNPz0d0K0hWDmWmpbbErSdVj7aozy4PiYPiT xotPZkM89PU+ZgOmS5PkqKfwB7LI5JkOzG9FctD//1jSwr8QtfGby7a/3knN/Qf7+lBb dqZ3X3wGD4jUcCXX3k9Ybm9q6DyO3BdVrw2ScvdgL4VwxAAsZkKSzMWlVxvABlrBzLAj C2a6m20aFxqmDD0ZzDuCBViDVkeyuajnrALgRVqDJXLZ3jNzrCxBS/Obor1W1f1zld+Q q7/bgZpTOiMlDqyfF3SNsjP3iB0wNioaJ9lp+pecicWTgb1CSXsQfkt1vZkKOC1623Mf mGfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773145884; x=1773750684; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=O0qrn9d7S7AyHe7vYAv9x2SN2/8h4evFQLk0vYAxM3o=; b=t6HjkBMeT+3m1hu5RTv/8TSI/FUHl1yc0TJUHJ9QjV7UJEg41sD4XRqrkgO1MTLP0d sIhAeGCvtaBsghD4xur8nPLPhdG4I6B8AzwuV2wB7KiJGrhVNCzDzTWjNgSBEC8pHyjN cGe071p0KTU7ZYv5LcJY+IVsav3kxc2rHebNykFy6slWPuRBhdZhiFBe5zJGZTixIEU+ Yc8U9g5BMBmdhzi66ysgWsGz+/zMjvYCdOwxjw5gwFA9swW73iYCHRdkqarnc9jz4WLt 0cz9ZeHlLqkPpiqVjRCG6yy1EtEdziPm4UOtFmdClI3GxB3CTwLdjLMijtxpMnn95X4s dm9A== X-Forwarded-Encrypted: i=1; AJvYcCWl45euidy0AEfH3UXnREZeErLpU0OebwQ68/RhJo/+BOW+V642GffNznauYrLohurFB+grLpyASTej3fs=@vger.kernel.org X-Gm-Message-State: AOJu0YycunSHYcLtE0NF+xYtRb1DEobA9Q4k/5ZhysWtA+V0rPuSZzJJ doiLGxxmMtsmntGjdPCswKJUjjquUktbLX3daHm3NXf8TdpCJFbig7xPkPNgSnnP3xyr5mdC9H6 kr+IugizqXCADJxAcP1sj0nMECHepPly62U7slm57Bonw2NoHpRcUSmGMo273aL2Bz14= X-Gm-Gg: ATEYQzzQGTJv/n7f6dZL/G4uuuec++I5yzIaDxOkYvtWkeAVwd20PJQqhIa3x2eiwUA ebTi5oGBT/eEExSei7Ppg8smcdv0dxK/fcRvvW4ye1uBzYf5u8GnAkJTQf5WV8x7C9msO2P2p3e 0hAp+66EaPJTIQDDdmVHbHqqFR6lJQeTKgF2AtQTqRFOXiT+GKOreKX0FsCrpCsGAWs7gmDhu4Y Bm2NQuDeKkqpeRtY8OOezEyF0KlaLe1sd4B7F5L5LLrMIQ5qL5lF2Be/0K1s3B95iNWzxXSXk+L s9eLv6wRnLC21DQHPbwvNfwpdHIjnpBSg/bZYFN9Fqz3zNhp95UHQyJ0OzaQb/v6Jz6Bm3h0iEE wXjUxzAVbJCcAxVozXcDbwiXiP3d9JZf6Sj+3ICCxllzfGkj/DXtvR/5m5z7XNhFLz56kN+R89u ixEok= X-Received: by 2002:a05:6102:3583:b0:5ff:c5c8:273c with SMTP id ada2fe7eead31-5ffe612e395mr2608864137.4.1773145883587; Tue, 10 Mar 2026 05:31:23 -0700 (PDT) X-Received: by 2002:a05:6102:3583:b0:5ff:c5c8:273c with SMTP id ada2fe7eead31-5ffe612e395mr2608858137.4.1773145883123; Tue, 10 Mar 2026 05:31:23 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942ef483f3sm462706466b.9.2026.03.10.05.31.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 05:31:22 -0700 (PDT) Message-ID: <8d327f02-b2c1-431f-8a18-bba99e396223@oss.qualcomm.com> Date: Tue, 10 Mar 2026 13:31:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] arm64: dts: qcom: Add Redmi Go To: barnabas.czeman@mainlining.org Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org, phone-devel@vger.kernel.org References: <20260305-riva-common-v1-0-436f1f4b7399@mainlining.org> <20260305-riva-common-v1-5-436f1f4b7399@mainlining.org> <07b552b4-ecdb-4877-8b45-fcaa6792aee4@oss.qualcomm.com> <390f4c8b89f3465924d6ef95bccccc6a@mainlining.org> <46a3f0ff1a5c20e8bd4a4c1efb16960d@mainlining.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <46a3f0ff1a5c20e8bd4a4c1efb16960d@mainlining.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDEwOCBTYWx0ZWRfXw2MhtQnIV3iV +Tmg2UFl70tayAuFK9V6hzXZXmnxqa7NHlo1sS9iBHNuzDyVtURXH/yOH+dEw3Wn7+VwTDg2Phq Hn75BoSIC/zdsr5KHBmGgQ5twNU0N3FQYaxA6kKDksOeqN/4HwO6y9qqj/HI+1Mkqim/T5HOUT5 fHMJdTorJQSsqE5VfYYvHaTPlMUH6x32nMm/Z29xmUG/7e4ZD0A3Isb4WeV0x5XGXQJ+NguSuet 8uFHgQ8C32po44ECdDcLDHHzDMibBZPE27ZUR7VkNYzpG3TpjM5TT/7OKe4SXsoq2Ff0LhgJxGg mqb6U40Cn83AHwa4rH1f1yaBFlBJNucZJXdKy2+4PK/FwJomlYWLBlY5y3vk4e9omBaqCGkjWJO en6e6WkOpQeiX2i/bgaM9IaNTlg6jMT/5RlskAxprBIxOAXUuZVRQTC7sDAFSXYWX7NRhvpK2bf tHACi5hkQkZEbBUwFsw== X-Authority-Analysis: v=2.4 cv=GtFPO01C c=1 sm=1 tr=0 ts=69b00f1c cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=bAtGagR5AAAA:20 a=OuZLqq7tAAAA:8 a=2cL_a-esRp1aGMuMyq0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 a=AKGiAy9iJ-JzxKVHQNES:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-ORIG-GUID: NYOpdu6TCgikdAvoduHg_lTt5kwyJe9e X-Proofpoint-GUID: NYOpdu6TCgikdAvoduHg_lTt5kwyJe9e X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_02,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100108 On 3/9/26 10:36 PM, barnabas.czeman@mainlining.org wrote: > On 2026-03-09 22:19, barnabas.czeman@mainlining.org wrote: >> On 2026-03-09 13:53, Konrad Dybcio wrote: >>> On 3/5/26 6:28 PM, Barnabás Czémán wrote: >>>> Redmi Go (tiare) is like Redmi 5A with small differences like charging, >>>> fuel gauge and different speaker codec. >>>> >>>> Signed-off-by: Barnabás Czémán >>>> --- >>>>  arch/arm64/boot/dts/qcom/Makefile                 |  1 + >>>>  arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts | 27 +++++++++++++++++++++++ >>>>  2 files changed, 28 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>>> index 20e161e843ed..a74598cf0b47 100644 >>>> --- a/arch/arm64/boot/dts/qcom/Makefile >>>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>>> @@ -83,6 +83,7 @@ dtb-$(CONFIG_ARCH_QCOM)    += msm8916-wingtech-wt88047.dtb >>>>  dtb-$(CONFIG_ARCH_QCOM)    += msm8916-yiming-uz801v3.dtb >>>>  dtb-$(CONFIG_ARCH_QCOM)    += msm8917-xiaomi-riva.dtb >>>>  dtb-$(CONFIG_ARCH_QCOM)    += msm8917-xiaomi-rolex.dtb >>>> +dtb-$(CONFIG_ARCH_QCOM)    += msm8917-xiaomi-tiare.dtb >>>>  dtb-$(CONFIG_ARCH_QCOM)    += msm8929-wingtech-wt82918hd.dtb >>>>  dtb-$(CONFIG_ARCH_QCOM)    += msm8937-xiaomi-land.dtb >>>>  dtb-$(CONFIG_ARCH_QCOM)    += msm8939-asus-z00t.dtb >>>> diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts >>>> new file mode 100644 >>>> index 000000000000..c3a74530c34c >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-tiare.dts >>>> @@ -0,0 +1,27 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-only >>>> +/* >>>> + * Copyright (c) 2026, Barnabas Czeman >>>> + */ >>>> + >>>> +/dts-v1/; >>>> + >>>> +#include "msm8917-xiaomi-riva-common.dtsi" >>>> + >>>> +/ { >>>> +    model = "Xiaomi Redmi Go (tiare)"; >>>> +    compatible = "xiaomi,tiare", "qcom,msm8917"; >>>> + >>>> +    qcom,board-id = <0x1000b 1>; >>> >>> Could you please double-check this? Riva and Rolex seem to have >>> properly different values there, but this one mimics one of the >>> values for Rolex. >> riva value is depends from the bootloader, Oreo bootloader using same value >> like rolex and tiare, 2nd entry in the board-id is not used so i should remove it. >> Here is some more context: >> https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/device/dts/msm8952/msm8917-xiaomi-riva.dts >> https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/device/dts/msm8952/msm8917-xiaomi-common.dts >> > I have find out this qcom,board-id = <0x1000b 1>, <0x1000b 2>; works with both bootloader version > on riva but if i set only one of them, the bootloader version will be limited. These properties exist for the sole reason of making the bootloader happy, so if there's nuance, let's not try being too smart and just stick with what works Konrad