From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from polaris.svanheule.net (polaris.svanheule.net [84.16.241.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C48A354AC7 for ; Thu, 5 Mar 2026 21:49:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=84.16.241.116 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772747385; cv=none; b=VXjuhIR7WioqMGEBppj2JiDNQvN8gxP5deEvMt3k+OvrzRJpogbp+xd2iPRpasT6Bbv3kGq7aT7d5t1Kt3vMvFwSqqHmGWxkClq3WqAuSCBbdvif7ipxopJkACUpwRylVRfNFBI3oqy09CFCYIF/j+OsVne6mo4AxeLYi4Cp22Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772747385; c=relaxed/simple; bh=vH01rYnl/NRZ0Zi/fq7qciHoqCcVv0HrRWQjxLhG6IY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=RTrOF15/jle2RFY4fAP/+P7XS8mdylAsOKvVUzkxJRv9dM5Gog+Jxo4NxwlS+cauoueaaaBPqs9PGnE4rMMHMt/7UjgfeZXddiUWZk1aLFJpxAMVB0aclQ1c9/LVKg/lBNg8fE1fcEg/okOd0FkF+hEp4oJQ2oFRs9IPYtnC5Ow= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=svanheule.net; spf=pass smtp.mailfrom=svanheule.net; dkim=pass (2048-bit key) header.d=svanheule.net header.i=@svanheule.net header.b=SUToCcG5; arc=none smtp.client-ip=84.16.241.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=svanheule.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=svanheule.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=svanheule.net header.i=@svanheule.net header.b="SUToCcG5" Received: from [IPv6:2a02:1812:162c:8f00:19d9:5e35:1cd7:5d5d] (2a02-1812-162c-8f00-19d9-5e35-1cd7-5d5d.ip6.access.telenet.be [IPv6:2a02:1812:162c:8f00:19d9:5e35:1cd7:5d5d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sander@svanheule.net) by polaris.svanheule.net (Postfix) with ESMTPSA id 93CA06F3045; Thu, 5 Mar 2026 22:49:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svanheule.net; s=mail1707; t=1772747381; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mTOLZe0At/Nfe+c5U6L75GPk0yzPzMk6sA5p+V8EDw4=; b=SUToCcG5wmCp2x7KI1RhwTzaLP7teewuytdCFe0IAGE4EvvIqPYQV7slI5ANqHNemi81ke vopXv4RJOkxtjl7o/u2Yml54B+gqiPVu2oFdIbr9HXxvrBtZ8Iara95BgfwdqnVcYFD+v9 gy6PWzCf2+fhOkjoWFBYUe7kgVxxXPmCCSOnjxe4BhUBWkJYVEAKjQ1YiQbtEbcmbWRCjF dYZgv4gBY3+pZeMYNUeCUXpSqa9Qs9XX9zSsDuMM4XNy1QsANSO18XZRmuO0+trUUtNbSS 3dNud4eGofpHycieqpi1X6SOmBZEhW3rObc9CUx+TkV8yEXfgmtanpGE5AXfTA== Message-ID: <8d382a35b5e2304b4c869ced560c0c3880af5b84.camel@svanheule.net> Subject: Re: [PATCH 2/2] gpio: realtek-otto: add rtl9607 support From: Sander Vanheule To: adilov Cc: Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bert Vermeulen , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 05 Mar 2026 22:49:41 +0100 In-Reply-To: <6a8538a1990dc02a6a0bdbf60ebd747f@disroot.org> References: <20260305161106.15999-1-adilov@disroot.org> <20260305161106.15999-3-adilov@disroot.org> <6a8538a1990dc02a6a0bdbf60ebd747f@disroot.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, On Thu, 2026-03-05 at 19:54 +0000, adilov wrote: > On 2026-03-05 19:04, Sander Vanheule wrote: > > On Thu, 2026-03-05 at 21:11 +0500, Rustam Adilov wrote:, > > > + { > > > + .compatible =3D "realtek,rtl9607-gpio", > > > + .data =3D (void *)GPIO_PORTS_REVERSED, > > > + }, > > If I'm not mistaken, this SoC has a MIPS InterAptiv CPU like the=20 > > RTL931x SoC > > series. Were you able to validate that the interrupts are functioning= =20 > > as > > expected? > >=20 > > Best, > > Sander >=20 > Hi Sander, >=20 > Yes, this is correct. I played around with gpio-keys in OpenWrt (though= =20 > it > has its own gpio-button-hotplug but it should not change things) and can > verify that button presses and releases are working. I think this should > confirm that interrupts are functional. Thanks for the info. I was mainly wondering because there seemed to be some initial confusion [1] about the port order. If you get the order wrong, you would be getting spurious interrupts. [1] https://forum.openwrt.org/t/240741/25 If the order is correct, you should see the key GPIO interrupt increase in /proc/interrupts. So, assuming that's the case: Reviewed-by: Sander Vanheule Best, Sander