From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E78C433FE for ; Thu, 24 Feb 2022 18:59:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233157AbiBXTA1 (ORCPT ); Thu, 24 Feb 2022 14:00:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231774AbiBXTAZ (ORCPT ); Thu, 24 Feb 2022 14:00:25 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B636218E42D for ; Thu, 24 Feb 2022 10:59:54 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id y5so2677478pfe.4 for ; Thu, 24 Feb 2022 10:59:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=fyRJwkdEk9dWrbptJefFZUVWbdfjncd85LnmXOcMJA4=; b=koCoOElIvFf2pF9r8KqL81JR7/aEwX4ouLYXauh77CI48GZtPvSVyyuZL/+2Fw1KMN yyhmYZR4KDha4XVqiwktrwJei4UPzgz6ynyBeZ6fE9G32zTS+kU7tyTKj9Vxqw/CIu1Z 1UXYlXoyMXgZKHKjzJ4A2Q/RtQjhWNQQDpNwKUG1K8XaKU5Y6KW2Au2Ks5RGYdeLyYZs nCh0dU0rjhU8dDylVjfzAOjI3GDY4fGTepSXIYHTAC+kS54ZBSP/1ttxd9FZF6D0S4Df h33hEX8nC0jK7vkIan4rNUfYEhdvghFN2o0+kP5Ha5JC2iKhrotsgLwLsWJ70M3gscOE Lh6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=fyRJwkdEk9dWrbptJefFZUVWbdfjncd85LnmXOcMJA4=; b=4iyVDqgUyjGHW2SydBrv3KFHpZYvTirNz2wH4alxtAzSWR7eQQOyb42Ax0Vz0BUDMm nai4d+nMuvRtAwW/JSY+5heIkieEC6VQ3TftJnU/9Fa1X2YAT/uyNVscA0yEFeBw/FSo aWcoNCg7EvRz7Vg2i45rfmHSTfVSNJoi+mtAyLmnODrEAJEUy9s1ZaqwwEyHsnW+9uvW 4BO8xgqGzD08onPkWWIpiFv5BDGP1VP3OuA7lVH5ifxsJ3LAG5RPaAJpEDYisdzZ6Vdf mvurK48I1mOIuChGmCmoEnX0g+Pj5DMefOBcR42dhvvuKTGyEGr1cZ+TMz8bjWIouglA JdZQ== X-Gm-Message-State: AOAM532IUkq1pNicjd7xmMgXGSlJoc9XrjiP9k4yX2Yvo4226/3nIkpI mw7MzN+VweFBssjOKQHb+Bprug== X-Google-Smtp-Source: ABdhPJwFBRKABFChm9nzdPOgbE3WXtr9EPr5XquiOKPJHsMmFjakNuJVob6G0QqvAmGUsUzPa+myAQ== X-Received: by 2002:a05:6a00:140f:b0:4e0:6995:9c48 with SMTP id l15-20020a056a00140f00b004e069959c48mr3962998pfu.59.1645729194251; Thu, 24 Feb 2022 10:59:54 -0800 (PST) Received: from [192.168.254.17] ([50.39.160.154]) by smtp.gmail.com with ESMTPSA id 25-20020a631859000000b00373df766e76sm255444pgy.16.2022.02.24.10.59.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Feb 2022 10:59:53 -0800 (PST) Message-ID: <8d3a11be-a7eb-5ad0-2ef6-abc9276ced2f@linaro.org> Date: Thu, 24 Feb 2022 10:59:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] KVM: x86: Forcibly leave nested virt when SMM state is toggled Content-Language: en-US To: Paolo Bonzini , Sean Christopherson Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+8112db3ab20e70d50c31@syzkaller.appspotmail.com References: <20220125220358.2091737-1-seanjc@google.com> <3561688b-b52c-8858-3da2-afda7c3e681f@linaro.org> <6cef7c8a-10d3-9fc6-f68d-220fdfc079c1@redhat.com> From: Tadeusz Struk In-Reply-To: <6cef7c8a-10d3-9fc6-f68d-220fdfc079c1@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/18/22 10:14, Paolo Bonzini wrote: > On 2/18/22 18:22, Tadeusz Struk wrote: >> On 2/18/22 08:58, Sean Christopherson wrote: >>> This SMM-specific patch fixes something different, the bug that you are still >>> hitting is the FNAME(cmpxchg_gpte) mess.  The uaccess CMPXCHG series[*] that >>> properly fixes that issue hasn't been merged yet. >>> >>>    ================================================================== >>>    BUG: KASAN: use-after-free in ept_cmpxchg_gpte.constprop.0+0x3c3/0x590 >>>    Write of size 8 at addr ffff888010000000 by task repro/5633 >>> >>> [*]https://lore.kernel.org/all/20220202004945.2540433-1-seanjc@google.com >>> >> >> Ok, that's good. I will keep an eye on it and give it a try then. > > I'll poke PeterZ for a review next week. > Paulo, do you know if PeterZ had a chance to look at the uaccess patches yet? -- Thanks, Tadeusz