From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA8BAC7EE2C for ; Tue, 30 May 2023 14:33:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232077AbjE3Od0 convert rfc822-to-8bit (ORCPT ); Tue, 30 May 2023 10:33:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231177AbjE3OdX (ORCPT ); Tue, 30 May 2023 10:33:23 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C49F19C; Tue, 30 May 2023 07:33:21 -0700 (PDT) X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net X-GND-Sasl: hadess@hadess.net Received: by mail.gandi.net (Postfix) with ESMTPSA id 1661F60007; Tue, 30 May 2023 14:33:18 +0000 (UTC) Message-ID: <8d3ba2cf2bf09af9e15a1453212d68bfd41f9399.camel@hadess.net> Subject: Re: [PATCH 1/1] HID: logitech-hidpp: Add USB and Bluetooth IDs for the Logitech G915 TKL Keyboard From: Bastien Nocera To: Stuart Hayhurst Cc: jikos@kernel.org, Filipe =?ISO-8859-1?Q?La=EDns?= , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 30 May 2023 16:33:18 +0200 In-Reply-To: <20230530141628.21290-1-stuart.a.hayhurst@gmail.com> References: <20230530141628.21290-1-stuart.a.hayhurst@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.48.0 (3.48.0-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2023-05-30 at 15:16 +0100, Stuart Hayhurst wrote: > Adds the USB and Bluetooth IDs for the Logitech G915 TKL keyboard, > for device detection > For this device, this provides battery reporting on top of hid- > generic > > Signed-off-by: Stuart Hayhurst You can add my: Reviewed-by: Bastien Nocera to the v2 patch that you should send, otherwise the tree maintainers will get confused. Cheers > --- >  drivers/hid/hid-logitech-hidpp.c | 4 ++++ >  1 file changed, 4 insertions(+) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid- > logitech-hidpp.c > index b2cd7527de19..28761272afe5 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -4403,6 +4403,8 @@ static const struct hid_device_id > hidpp_devices[] = { >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC086) }, >         { /* Logitech G903 Hero Gaming Mouse over USB */ >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC091) }, > +       { /* Logitech G915 TKL Keyboard over USB */ > +         HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC343) }, >         { /* Logitech G920 Wheel over USB */ >           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, > USB_DEVICE_ID_LOGITECH_G920_WHEEL), >                 .driver_data = HIDPP_QUIRK_CLASS_G920 | > HIDPP_QUIRK_FORCE_OUTPUT_REPORTS}, > @@ -4418,6 +4420,8 @@ static const struct hid_device_id > hidpp_devices[] = { >         { /* MX5500 keyboard over Bluetooth */ >           HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb30b), >           .driver_data = HIDPP_QUIRK_HIDPP_CONSUMER_VENDOR_KEYS }, > +       { /* Logitech G915 TKL keyboard over Bluetooth */ > +         HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb35f) }, >         { /* M-RCQ142 V470 Cordless Laser Mouse over Bluetooth */ >           HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb008) }, >         { /* MX Master mouse over Bluetooth */