From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5C8035BDAB for ; Mon, 19 Jan 2026 12:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768826129; cv=none; b=ZG6CrSSdsrEdUv1KHr16tcNNwg5VghrNmO9LSv+aLi4nt30XOWmo1pVbfxn1wUayQl/p0nKtiQHW/q+CPqbHPtpEGP61ZzpMeWIDXd/JtpQ9QGvheT1KNu1nF9g9QTiXcG5RsHMOezIktPxIc2EG5dO6WvyUNM9a40ZQsOtkkno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768826129; c=relaxed/simple; bh=gr9vBwRkdnT64E/OLpJ7TQP/OEJJ/CQLFZaWSKbKyjg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l076hzRXfH+2uC4FgB/e2buCsReyzC+zEWZr/QLJEBtKYbYZmefuDl0fDNuUy9Xr0rL+XBB34YPjzQy9iU1IK7RSD2zBcPMLbnf+Fm6HVlVaxCb7Izg+7NrIU8cRRa2IjiNHI4GwU0iTLAEmJ2+kfuLToB39sEGxQMoALBlVRfg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=jIzJEUq6; arc=none smtp.client-ip=209.85.221.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jIzJEUq6" Received: by mail-wr1-f66.google.com with SMTP id ffacd0b85a97d-430f3ef2d37so3298092f8f.3 for ; Mon, 19 Jan 2026 04:35:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1768826124; x=1769430924; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=z3eT6Bg7ZWijWJ4NFvVulXfOaaoq9EAaYQC3GNm1H3Q=; b=jIzJEUq6n5nW9EijW15b6W38vBoMTJPyARuzOUudc2HcgGhNWuEJ4FgBHxzHhtNTlg R7GznoGCbm3qPpVAo0nTzQWrHbsq90g2KVfqZjzy6Jz0bWiHfQzVZsBHT0SNUbWdDzmH 1YbaxVizHqo5YuIJEy2h9XmymqiZuLxf32qs5zyy72jjNfjshxUOEARzcVbZx+kJ0ELN QPEvqtiz9IDVSReKXLegRHxCDRA4wAjd9G9qwXFaV6LRMS9jb9lRp6oxdAhKc1Uck6Hl 9/yn1mPRlH0kM1KrWLXwtXLo9Wd88MfH/cwYaFc3mJ6HdJ3xlH2kB6mnOx41yBz0xFHR Q+xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768826124; x=1769430924; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z3eT6Bg7ZWijWJ4NFvVulXfOaaoq9EAaYQC3GNm1H3Q=; b=ARfimizTB+oE7GztKJvV5O2NIB8WAQRcTMRaFmKURWWrMKexC/kY/4ujusypD8zMNQ OVfvkltpm6/xaO3jiTRfFPHPbHwfSrHQfmbfQyT9Nb5Ve3igpwHMI2hov8VvnEPRW+MQ 9oJ6KcOn6mqn1zzTtoG6OxzBF6erfLch8dydxh2c/FFLdm/tbJtz2lFVhYvD9rdgysUF 2DIHP1SuHIkI06RDExdjfGlxbgqI/kWnlpRDZkQfiIzbqPTRFGpaUvg9FFXWMSuF2lQA 64oc0N+OrVXdkLUhrEHjB2KTGnzT0o1Sy+I8k0xBgduFKfxmirDGm9gaEXZJ/IPBdc6I uHmg== X-Forwarded-Encrypted: i=1; AJvYcCUPQoZ+8nUmug7vhDLtPjYbLCcWFF1HC7GsEbBQWXEWGXHFxOTM0ZR8zAFsCJ7x9xYIG8rzuG0zmwVLdIA=@vger.kernel.org X-Gm-Message-State: AOJu0YzWoYbghUIZo4esRcAN8ikTm9JVBgPq9fEV4hun1BXu8LA25Kfm NMEsOfwtkKjqd9GUoeLculNUstsWLiphWRHtWFlfyzoivxvYQpBrSicXGm192wHwt9jW9qQmKQi qhupTHcw= X-Gm-Gg: AZuq6aKE024SXKF9bS6XXAP5AtSjJSlEdZ8Z6XrPf/MQUUe2Di7h19Kt7L46wmpBg5B uv1N8HLe5fUBf6/baMTZN6N01EcsE5O6pIJPUaCOt4HON7owS2M0XAxc2zaZ5QDRuX4Ql6oFSLH ZVjbwejIucjGHDxROLwWm1Hinx1kopFCKdeqizRWG+OyieNDbusCktjcx00wm1+tRwr0GD9PvcR +wQo7/SWVYqVjG1BvwByUE3hC7QDd2lGncV0tBqe1JGQBR0g8uprz5yu+oF43lIUwKy3rvxLcS1 GIYjIK9WtXGDpfaV6cjs15vWbtRPkOMGh7PQ4olajhXip6B65QWHnfw2nVWBAeI4U7WSVLeRRtb CW8X5i3a0UTxy432lYF8buBJBSAYwWMPouHNn36M6iE+mAmFysjToqmZc2id8hzWOpPxt2J+mJ/ STPwo+a7dU85h495dl X-Received: by 2002:a05:6000:144b:b0:430:f5dc:d34a with SMTP id ffacd0b85a97d-43569bbb0acmr15961638f8f.29.1768826124241; Mon, 19 Jan 2026 04:35:24 -0800 (PST) Received: from [192.168.1.3] ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356996cefdsm22268489f8f.24.2026.01.19.04.35.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 04:35:23 -0800 (PST) Message-ID: <8d48dd55-d78d-4cbf-88b0-5427a731ba7d@linaro.org> Date: Mon, 19 Jan 2026 12:35:23 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] stm class: Fix Kconfig symbols To: Leo Yan , Alexander Shishkin Cc: linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, Maxime Coquelin , Alexandre Torgue , Greg Kroah-Hartman References: <20251217-fix_stm_kconfig-v1-1-531fb3674549@arm.com> Content-Language: en-US From: James Clark In-Reply-To: <20251217-fix_stm_kconfig-v1-1-531fb3674549@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17/12/2025 9:39 am, Leo Yan via CoreSight wrote: > Kconfig symbols must not include the CONFIG_ prefix. Remove the CONFIG_ > prefix for default values to work. > > Fixes: a02509f301c6 ("stm class: Factor out default framing protocol") > Fixes: d69d5e83110f ("stm class: Add MIPI SyS-T protocol support") > Signed-off-by: Leo Yan > --- > drivers/hwtracing/stm/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig > index eda6b11d40a1f9ab49a1ec1e6faae8ee178c5ed3..cd7f0b0f3fbebc74775d8835187e49e5bd21d646 100644 > --- a/drivers/hwtracing/stm/Kconfig > +++ b/drivers/hwtracing/stm/Kconfig > @@ -13,7 +13,7 @@ if STM > > config STM_PROTO_BASIC > tristate "Basic STM framing protocol driver" > - default CONFIG_STM > + default STM > help > This is a simple framing protocol for sending data over STM > devices. This was the protocol that the STM framework used > @@ -28,7 +28,7 @@ config STM_PROTO_BASIC > > config STM_PROTO_SYS_T > tristate "MIPI SyS-T STM framing protocol driver" > - default CONFIG_STM > + default STM The help below here says "If you don't know what this is, say N." which makes me wonder if this should be on by default or not? Also everything is in an "if STM" block, so "default STM" is a bit redundant. It's not that obvious what the intention was. James > help > This is an implementation of MIPI SyS-T protocol to be used > over the STP transport. In addition to the data payload, it > > --- > base-commit: 40fbbd64bba6c6e7a72885d2f59b6a3be9991eeb > change-id: 20251216-fix_stm_kconfig-a72f40c7612c > > Best regards,