From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbdF3PyA (ORCPT ); Fri, 30 Jun 2017 11:54:00 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:51899 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbdF3Px7 (ORCPT ); Fri, 30 Jun 2017 11:53:59 -0400 Subject: Re: [PATCH] usb: typec: include linux/device.h in ucsi.h To: Arnd Bergmann , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170630154655.3645961-1-arnd@arndb.de> From: Guenter Roeck Message-ID: <8d4a8cfd-55c5-83f3-8b33-7587abbae135@roeck-us.net> Date: Fri, 30 Jun 2017 08:53:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170630154655.3645961-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/30/2017 08:46 AM, Arnd Bergmann wrote: > The new driver causes a build failure in some configurations: > > In file included from /git/arm-soc/drivers/usb/typec/ucsi/trace.h:9:0, > from /git/arm-soc/drivers/usb/typec/ucsi/trace.c:2: > drivers/usb/typec/ucsi/ucsi.h:331:39: error: 'struct device' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > This includes the required header file. > > Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface") > Signed-off-by: Arnd Bergmann Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/ucsi/ucsi.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h > index 6b0d2f0918c6..8a88f45822e3 100644 > --- a/drivers/usb/typec/ucsi/ucsi.h > +++ b/drivers/usb/typec/ucsi/ucsi.h > @@ -3,6 +3,7 @@ > #define __DRIVER_USB_TYPEC_UCSI_H > > #include > +#include > #include > > /* -------------------------------------------------------------------------- */ >